Increase error logging to diagnose server conking (#15662)

* Increase error logging to diagnose server conking

* more logging and db retry

* whoops

* rename error() to log_error() to better reflect what it does
Move a bunch of world.log messages to log_error

* Fix compile error

---------

Co-authored-by: Werner <Arrow768@users.noreply.github.com>
This commit is contained in:
Wildkins
2023-03-13 21:51:39 +00:00
committed by GitHub
co-authored by Werner
parent 62e25f5890
commit c369124fe9
42 changed files with 94 additions and 91 deletions
+3 -3
View File
@@ -100,7 +100,7 @@ var/list/forum_groupids_to_ranks = list()
var/datum/admin_rank/rank_object = admin_ranks[rank]
if (!rank_object)
error("Unrecognized rank in admins.txt: \"[rank]\"")
log_error("Unrecognized rank in admins.txt: \"[rank]\"")
continue
//create the admin datum and store it for later use
@@ -114,7 +114,7 @@ var/list/forum_groupids_to_ranks = list()
else
//The current admin system uses SQL
if(!establish_db_connection(dbcon))
error("AdminRanks: Failed to connect to database in load_admins(). Reverting to legacy system.")
log_error("AdminRanks: Failed to connect to database in load_admins(). Reverting to legacy system.")
log_misc("AdminRanks: Failed to connect to database in load_admins(). Reverting to legacy system.")
config.admin_legacy_system = 1
load_admins()
@@ -134,7 +134,7 @@ var/list/forum_groupids_to_ranks = list()
D.associate(directory[ckey])
if(!admin_datums)
error("AdminRanks: The database query in load_admins() resulted in no admins being added to the list. Reverting to legacy system.")
log_error("AdminRanks: The database query in load_admins() resulted in no admins being added to the list. Reverting to legacy system.")
log_misc("AdminRanks: The database query in load_admins() resulted in no admins being added to the list. Reverting to legacy system.")
config.admin_legacy_system = 1
load_admins()