From c3f65f77d4e5d48ac46565fe31e31ccd03374889 Mon Sep 17 00:00:00 2001 From: Kano <89972582+kano-dot@users.noreply.github.com> Date: Wed, 29 Apr 2026 21:07:42 +0300 Subject: [PATCH] Fixes weapon racks not displaying stored guns roundstart (#22374) ## About PR Instead of directly poking the `overlays` list, uses overlay helper procs to queue the icons properly. Can't really fathom why this became an issue in the first place I didn't observe any layer changes upon testing, it works as it should Screenshot_45 --- code/game/objects/structures/weapons_rack.dm | 4 ++-- html/changelogs/kano-dot-where-are-my-weapons!.yml | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 html/changelogs/kano-dot-where-are-my-weapons!.yml diff --git a/code/game/objects/structures/weapons_rack.dm b/code/game/objects/structures/weapons_rack.dm index 68290d96424..b69b2d16891 100644 --- a/code/game/objects/structures/weapons_rack.dm +++ b/code/game/objects/structures/weapons_rack.dm @@ -147,7 +147,7 @@ #define INTER_OFFSET_RIFLE_SLOT 7 /obj/structure/weapons_rack/update_icon() . = ..() - visual_holder.overlays.Cut() + visual_holder.ClearOverlays() ClearOverlays() for(var/i in 1 to length(src.contents)) @@ -162,7 +162,7 @@ var/mutable_appearance/weapon_appearance = mutable_appearance(G.icon, G.icon_state, plane = src.plane, layer = G.layer) weapon_appearance.transform = transform_matrix - visual_holder.overlays += weapon_appearance + visual_holder.AddOverlays(weapon_appearance) if(locked) AddOverlays(image(src.icon, "locked_overlay", layer = ABOVE_OBJ_LAYER)) diff --git a/html/changelogs/kano-dot-where-are-my-weapons!.yml b/html/changelogs/kano-dot-where-are-my-weapons!.yml new file mode 100644 index 00000000000..7b8bcecb720 --- /dev/null +++ b/html/changelogs/kano-dot-where-are-my-weapons!.yml @@ -0,0 +1,6 @@ +author: Kano + +delete-after: True + +changes: + - bugfix: "Fixed weapon racks not displaying the guns stored inside upon roundstart."