From d9e190744970ebf5ab4ea109994ae8220f6e5114 Mon Sep 17 00:00:00 2001
From: MarinaGryphon <ryfoxx93@gmail.com>
Date: Wed, 5 May 2021 13:23:49 -0500
Subject: [PATCH] Fixes a runtime in /datum/preference/New(). (#11837)

---
 code/modules/client/preferences.dm            |  3 +-
 html/changelogs/MDP-fixes-prefs-runtime-1.yml | 41 +++++++++++++++++++
 2 files changed, 42 insertions(+), 2 deletions(-)
 create mode 100644 html/changelogs/MDP-fixes-prefs-runtime-1.yml

diff --git a/code/modules/client/preferences.dm b/code/modules/client/preferences.dm
index ff1d3455536..c0befa4f6cd 100644
--- a/code/modules/client/preferences.dm
+++ b/code/modules/client/preferences.dm
@@ -190,6 +190,7 @@ datum/preferences
 			load_path(C.ckey)
 			load_preferences()
 			load_and_update_character()
+			update_preview_icon()
 
 /datum/preferences/Destroy()
 	. = ..()
@@ -660,8 +661,6 @@ datum/preferences
 		disabilities = list()
 
 		nanotrasen_relation = "Neutral"
-	
-	update_preview_icon()
 
 // Deletes a character from the database
 /datum/preferences/proc/delete_character_sql(var/client/C)
diff --git a/html/changelogs/MDP-fixes-prefs-runtime-1.yml b/html/changelogs/MDP-fixes-prefs-runtime-1.yml
new file mode 100644
index 00000000000..185943d60d5
--- /dev/null
+++ b/html/changelogs/MDP-fixes-prefs-runtime-1.yml
@@ -0,0 +1,41 @@
+################################
+# Example Changelog File
+#
+# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb.
+#
+# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.)
+# When it is, any changes listed below will disappear.
+#
+# Valid Prefixes:
+#   bugfix
+#   wip (For works in progress)
+#   tweak
+#   soundadd
+#   sounddel
+#   rscadd (general adding of nice things)
+#   rscdel (general deleting of nice things)
+#   imageadd
+#   imagedel
+#   maptweak
+#   spellcheck (typo fixes)
+#   experiment
+#   balance
+#   admin
+#   backend
+#   security
+#   refactor
+#################################
+
+# Your name.
+author: MoondancerPony
+
+# Optional: Remove this file after generating master changelog.  Useful for PR changelogs that won't get used again.
+delete-after: True
+
+# Any changes you've made.  See valid prefix list above.
+# INDENT WITH TWO SPACES.  NOT TABS.  SPACES.
+# SCREW THIS UP AND IT WON'T WORK.
+# Also, all entries are changed into a single [] after a master changelog generation. Just remove the brackets when you add new entries.
+# Please surround your changes in  double quotes ("), as certain characters otherwise screws up compiling. The quotes will not show up in the changelog.
+changes:
+  - backend: "Fixes a runtime in preference creation that caused CI to fail."