mirror of
https://github.com/Aurorastation/Aurora.3.git
synced 2026-07-19 11:58:39 +01:00
TGUI Alert Button List Cleanup (#22207)
* Please describe the intent of your changes in a clear fashion. Fixes [SERVER-PROD-4](https://sentry.io/organizations/aurorastation/issues/7404427517/). The issue was that the `QDEL_NULL` macro was used on a list variable, causing `qdel` to error when a list was passed directly. To resolve this, `QDEL_NULL(buttons)` was replaced with `buttons = null` in `/datum/tgui_alert/Destroy`. This refactors the cleanup of the buttons list during alert destruction. This fix was generated by Seer in Sentry, triggered by Werner. 👁️ Run ID: 13170119. Not quite right? [Click here to continue debugging with Seer.](https://sentry.io/organizations/aurorastation/issues/7404427517/?seerDrawer=true) * Please make sure that, in the case of mapping changes, you include images of these changes in the PR's description. * Please make sure to mark your PR as wip or review required by making a comment with !wip or !review required * If you include sprites/sounds/... (assets) that you have not created yourself specify the license and original author below. * Ensure that you also credit them in the appropriate location / changelog as specified in the contributor guidelines ### Asset Licenses The following assets that **have not** been created by myself are included in this PR: | Path | Original Author | License | | --- | --- | --- | | icons/example.dmi | ExamplePerson (Example Station) | CC0 | --------- Signed-off-by: Arrow768 <1331699+Arrow768@users.noreply.github.com> Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com> Co-authored-by: Arrow768 <1331699+Arrow768@users.noreply.github.com>
This commit is contained in:
@@ -72,7 +72,7 @@
|
||||
|
||||
/datum/tgui_alert/Destroy(force, ...)
|
||||
SStgui.close_uis(src)
|
||||
QDEL_NULL(buttons)
|
||||
QDEL_LIST(buttons)
|
||||
return ..()
|
||||
|
||||
/**
|
||||
|
||||
Reference in New Issue
Block a user