Random new warehouse room options (#21030)

- rscadd: "Added 39 additional options for Horizon warehouse submaps."
- rscadd: "Added 14 additional regular cargo item spawns (flag boxes-
each contain sets of flags associated with a given nation, race, etc.)"
- rscdel: "Removed 'Russian' gimmick closet from warehouse spawn,
increased spawn rate of 'Tacticool' gimmick closet."
- balance: "Warehouse rare RFD random spawn chance slightly increased,
includes one compressed matter block."
- balance: "Warehouse rare clothing spawn now will spawn 1-4 items
(increased from 1-2)."
- balance: "Warehouse 'unusual container' spawn chance slightly
increased."
- balance: "Warehouse chemical dispenser spawn pool now includes coffee
makers, spawn chance slightly increased."
- balance: "Warehouse uncommon phoron sheets spawn chance slightly
decreased."
- refactor: "Updated radioactive greenglow decal to use ssRadiation proc
instead of old direct damage application."

code/modules/cargo/random_stock/large.dm

@@ -1,13 +1,10 @@
-STOCK_ITEM_LARGE(russian, 0.5)
-	new /obj/structure/closet/gimmick/russian(L)
-
 STOCK_ITEM_LARGE(emergency, 2)
 	new /obj/structure/closet/emcloset(L)
 
 STOCK_ITEM_LARGE(firecloset, 2)
 	new /obj/structure/closet/firecloset(L)
 
-STOCK_ITEM_LARGE(tacticool, 0.2)
+STOCK_ITEM_LARGE(tacticool, 0.5)
 	new /obj/structure/closet/gimmick/tacticool(L)
 
 STOCK_ITEM_LARGE(radsuit, 3)
@@ -99,10 +96,12 @@ STOCK_ITEM_LARGE(floorlayer, 2)
 STOCK_ITEM_LARGE(heater, 1.3)
 	new /obj/machinery/space_heater(L)
 
-STOCK_ITEM_LARGE(dispenser, 2.5)
+STOCK_ITEM_LARGE(dispenser, 3.5)
 	var/list/dispensers = list(
 		/obj/machinery/chemical_dispenser/bar_alc/full = 0.6,
 		/obj/machinery/chemical_dispenser/bar_soft/full = 1,
+		/obj/machinery/chemical_dispenser/coffeemaster/full = 0.6,
+		/obj/machinery/chemical_dispenser/coffee/full = 1,
 		/obj/machinery/chemical_dispenser/full = 0.3
 	)
 	var/type = pickweight(dispensers)
@@ -147,5 +146,5 @@ STOCK_ITEM_LARGE(exosuit, 1.2) //A randomly generated exosuit in a very variable
 	new /obj/machinery/mech_recharger(get_turf(L)) // exosuit would die without it otherwise
 	new /mob/living/heavy_vehicle/premade/random/extra(L)
 
-STOCK_ITEM_LARGE(unusualcrate, 0.1) //Like from the unknown object random event
+STOCK_ITEM_LARGE(unusualcrate, 0.3) //Like from the unknown object random event
 	new /obj/structure/closet/crate/loot(L)

code/modules/cargo/random_stock/t1_common.dm

@@ -526,5 +526,25 @@ STOCK_ITEM_COMMON(camera, 1)
 	if(prob(60))
 		new /obj/item/device/camera_film(L)
 
+STOCK_ITEM_COMMON(flagbox, 3)
+	var/list/flagbox_type = list(
+		/obj/item/storage/box/flags/sol,
+		/obj/item/storage/box/flags/biesel,
+		/obj/item/storage/box/flags/coc,
+		/obj/item/storage/box/flags/galataea,
+		/obj/item/storage/box/flags/dominia,
+		/obj/item/storage/box/flags/elyra,
+		/obj/item/storage/box/flags/diona,
+		/obj/item/storage/box/flags/unathi,
+		/obj/item/storage/box/flags/skrell,
+		/obj/item/storage/box/flags/tajara,
+		/obj/item/storage/box/flags/vaurca,
+		/obj/item/storage/box/flags/goldendeep,
+		/obj/item/storage/box/flags/corporate,
+		/obj/item/storage/box/flags/misc
+	)
+	var/type = pick(flagbox_type)
+	new type(L)
+
 STOCK_ITEM_COMMON(nothing, 0)
 	// do nothing

code/modules/cargo/random_stock/t2_uncommon.dm

@@ -14,7 +14,7 @@ STOCK_ITEM_UNCOMMON(plasteel, 3)
 STOCK_ITEM_UNCOMMON(silver, 2)
 	new /obj/item/stack/material/silver(L, rand(5,30))
 
-STOCK_ITEM_UNCOMMON(phoronsheets, 0.5)
+STOCK_ITEM_UNCOMMON(phoronsheets, 0.25)
 	new /obj/item/stack/material/phoron(L, rand(5,20))
 
 STOCK_ITEM_UNCOMMON(phoronglass, 0.5)

code/modules/cargo/random_stock/t3_rare.dm

@@ -110,9 +110,10 @@ STOCK_ITEM_RARE(ipctags, 0.5)
 	else
 		new /obj/item/implanter/ipc_tag(L)
 
-STOCK_ITEM_RARE(rfd, 0.5)
+STOCK_ITEM_RARE(rfd, 0.75)
 	var/obj/item/rfd/rfd_spawn = pick(/obj/item/rfd/construction, /obj/item/rfd/mining, /obj/item/rfd/piping)
 	new rfd_spawn(L)
+	new /obj/item/rfd_ammo(L)
 
 STOCK_ITEM_RARE(xbow, 0.5)
 	if(prob(95))
@@ -142,7 +143,7 @@ STOCK_ITEM_RARE(rare_clothing, 1)
 		/obj/item/clothing/under/lance,
 		/obj/item/clothing/under/dress/lance_dress/male,
 		/obj/item/clothing/under/kilt)
-	for(var/i in 1 to rand(1, 2))
+	for(var/i in 1 to rand(1, 4))
 		var/obj/item/clothing/C = pick(clothing_picks)
 		new C(L)