From ea83d359e4824a1c82c0bc710585489008784cec Mon Sep 17 00:00:00 2001 From: lavillastrangiato <63124803+lavillastrangiato@users.noreply.github.com> Date: Tue, 16 Apr 2024 00:43:48 -0600 Subject: [PATCH] Many Bug Fixes (#18938) Fixeeeeees... * Fixes #17501 * Fixes #15349 * Fixes #18772 * Fixes #15125 * Various incorrect usages of the demonym of Medina (they've been changed to "Madani") * Half-fixes #18878. The flak/plates/helmet are all added to the crates, but I couldn't fix the non-existent wear sprites. --- .../crates_lockers/crates/gear_loadout.dm | 18 +++++ code/modules/background/accent/human.dm | 2 +- code/modules/clothing/factions/elyra.dm | 8 +-- .../human/species/station/vaurca/vaurca.dm | 2 +- .../projectiles/guns/projectile/automatic.dm | 2 +- .../Lavillastrangiato - bugfixes.yml | 62 ++++++++++++++++++ icons/clothing/backpacks/dominia_backpack.dmi | Bin 906 -> 1999 bytes .../ships/pra/headmaster/headmaster_ship.dmm | 15 +++-- .../ships/yacht_civ/yacht_civ_ghostroles.dm | 7 +- 9 files changed, 103 insertions(+), 13 deletions(-) create mode 100644 html/changelogs/Lavillastrangiato - bugfixes.yml diff --git a/code/game/objects/structures/crates_lockers/crates/gear_loadout.dm b/code/game/objects/structures/crates_lockers/crates/gear_loadout.dm index 26899d9b36c..3400c0f6d9f 100644 --- a/code/game/objects/structures/crates_lockers/crates/gear_loadout.dm +++ b/code/game/objects/structures/crates_lockers/crates/gear_loadout.dm @@ -324,6 +324,21 @@ new /obj/item/clothing/head/dominia/fleet/armsman(src) new /obj/item/clothing/head/dominia/fleet/officer(src) new /obj/item/clothing/suit/storage/dominia/fleet(src) + new /obj/item/clothing/suit/armor/carrier/dominia(src) + new /obj/item/clothing/suit/armor/carrier/dominia(src) + new /obj/item/clothing/suit/armor/carrier/dominia(src) + new /obj/item/clothing/suit/armor/carrier/dominia(src) + new /obj/item/clothing/suit/armor/carrier/dominia(src) + new /obj/item/clothing/accessory/armor_plate/heavy/dominia(src) + new /obj/item/clothing/accessory/armor_plate/heavy/dominia(src) + new /obj/item/clothing/accessory/armor_plate/heavy/dominia(src) + new /obj/item/clothing/accessory/armor_plate/heavy/dominia(src) + new /obj/item/clothing/accessory/armor_plate/heavy/dominia(src) + new /obj/item/clothing/head/helmet/dominia(src) + new /obj/item/clothing/head/helmet/dominia(src) + new /obj/item/clothing/head/helmet/dominia(src) + new /obj/item/clothing/head/helmet/dominia(src) + new /obj/item/clothing/head/helmet/dominia/nco(src) new /obj/item/rig/jinxiang/equipped(src) new /obj/item/clothing/head/helmet/space/void/dominia(src) new /obj/item/clothing/head/helmet/space/void/dominia(src) @@ -371,6 +386,9 @@ new /obj/item/gun/projectile/automatic/rifle/dominia(src) new /obj/item/ammo_magazine/a556(src) new /obj/item/ammo_magazine/a556(src) + new /obj/item/clothing/suit/armor/carrier/dominia(src) + new /obj/item/clothing/accessory/armor_plate/heavy/dominia(src) + new /obj/item/clothing/head/helmet/dominia(src) new /obj/item/melee/energy/sword/pirate(src) new /obj/item/shield/energy/dominia(src) new /obj/item/voidsuit_modkit/dominianvoid(src) diff --git a/code/modules/background/accent/human.dm b/code/modules/background/accent/human.dm index 29975e643be..1a4f6d91763 100644 --- a/code/modules/background/accent/human.dm +++ b/code/modules/background/accent/human.dm @@ -367,7 +367,7 @@ /datum/accent/medina name = ACCENT_MEDINA - description = "Medinan Elyran is characterised by its breathy and almost stutter-step characteristics, both of which are thought to result from the elevated altitudes citizens experience living day-to-day in their \ + description = "Madani Elyran is characterised by its breathy and almost stutter-step characteristics, both of which are thought to result from the elevated altitudes citizens experience living day-to-day in their \ sand-skimming cities. The variation has seen little spread outside Medina itself, owing to the planet's relatively minimal footprint on Elyran cinema and television." tag_icon = "medina" text_tag = "MED" diff --git a/code/modules/clothing/factions/elyra.dm b/code/modules/clothing/factions/elyra.dm index cade39f0b15..a2839f23f5f 100644 --- a/code/modules/clothing/factions/elyra.dm +++ b/code/modules/clothing/factions/elyra.dm @@ -1,6 +1,6 @@ /obj/item/clothing/under/elyra_holo name = "elyran holographic suit" - desc = "A marvel of Elyran technology, uses hardlight fabric and masks to transform a skin-tight, cozy suit into cultural apparel of your choosing. Has a dial for Midenean, Aemaqii and Persepolisean clothes respectively." + desc = "A marvel of Elyran technology, uses hardlight fabric and masks to transform a skin-tight, cozy suit into cultural apparel of your choosing. Has a dial for Madani, Aemaqii and Persepolisean clothes respectively." icon = 'icons/clothing/under/uniforms/elyra_holoclothes.dmi' icon_state = "holosuit_fem" item_state = "holosuit_fem" @@ -10,13 +10,13 @@ var/clothing_mode = 0 var/list/names = list( "base holographic suit", - "medinean artisans holo-dress", + "madani artisans holo-dress", "aemaqii ocean holo-dress", "persepolisean desert holo-dress" ) var/list/descriptions = list( - "A form-fitting holographic dress with striking purple and white coloration. It possesses high-fidelity, artistic representation of Elyran Medinean culture markers coating its tightly-woven hardlight fabric.", + "A form-fitting holographic dress with striking purple and white coloration. It possesses high-fidelity, artistic representation of Elyran Madani culture markers coating its tightly-woven hardlight fabric.", "A fine holo-dress which owes its overall design to the chemical seas of Aemaqq, with itself flowing gently in waves. It looks particularly cozy, and protective against a cold ocean breeze.", "A loose, airy holo-dress with clashing earthen and bright colors. The design is iconic among the Elyran Persepolisean native populations due to its expressive contrast and the hot climate." ) @@ -26,7 +26,7 @@ item_state = "holosuit_masc" names = list( "base holographic suit", - "medinean artisans holo-suit", + "madani artisans holo-suit", "aemaqii fur outfit", "persepolisean nomads outfit" ) diff --git a/code/modules/mob/living/carbon/human/species/station/vaurca/vaurca.dm b/code/modules/mob/living/carbon/human/species/station/vaurca/vaurca.dm index bf3281410e7..a040e80c8d3 100644 --- a/code/modules/mob/living/carbon/human/species/station/vaurca/vaurca.dm +++ b/code/modules/mob/living/carbon/human/species/station/vaurca/vaurca.dm @@ -56,7 +56,7 @@ breath_eff_mul = 6 // 1/6 * breath_eff_mul = fraction of gas consumed poison_type = GAS_NITROGEN //a species that breathes plasma shouldn't be poisoned by it. breathing_sound = null //They don't work that way I guess? I'm a coder not a purple man. - mob_size = 13 //their half an inch thick exoskeleton and impressive height, plus all of their mechanical organs. + mob_size = 10 //their half an inch thick exoskeleton and impressive height, plus all of their mechanical organs. natural_climbing = TRUE climb_coeff = 0.75 diff --git a/code/modules/projectiles/guns/projectile/automatic.dm b/code/modules/projectiles/guns/projectile/automatic.dm index 0b9acdc2ac2..1fc0ff9e068 100644 --- a/code/modules/projectiles/guns/projectile/automatic.dm +++ b/code/modules/projectiles/guns/projectile/automatic.dm @@ -119,7 +119,7 @@ /obj/item/gun/projectile/automatic/wt550 name = "machine pistol" - desc = "The NI 550 Saber is a cheap self-defense weapon, mass-produced by Zavodskoi Interstellar for paramilitary and private use." + desc = "The ZI 550 Saber is a cheap self-defense weapon, mass-produced by Zavodskoi Interstellar for paramilitary and private use." icon = 'icons/obj/guns/wt550.dmi' icon_state = "wt550" item_state = "wt550" diff --git a/html/changelogs/Lavillastrangiato - bugfixes.yml b/html/changelogs/Lavillastrangiato - bugfixes.yml new file mode 100644 index 00000000000..602cdc7ce65 --- /dev/null +++ b/html/changelogs/Lavillastrangiato - bugfixes.yml @@ -0,0 +1,62 @@ +################################ +# Example Changelog File +# +# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. +# +# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) +# When it is, any changes listed below will disappear. +# +# Valid Prefixes: +# bugfix +# - (fixes bugs) +# wip +# - (work in progress) +# qol +# - (quality of life) +# soundadd +# - (adds a sound) +# sounddel +# - (removes a sound) +# rscadd +# - (adds a feature) +# rscdel +# - (removes a feature) +# imageadd +# - (adds an image or sprite) +# imagedel +# - (removes an image or sprite) +# spellcheck +# - (fixes spelling or grammar) +# experiment +# - (experimental change) +# balance +# - (balance changes) +# code_imp +# - (misc internal code change) +# refactor +# - (refactors code) +# config +# - (makes a change to the config files) +# admin +# - (makes changes to administrator tools) +# server +# - (miscellaneous changes to server) +################################# + +# Your name. +author: Lavillastrangiato + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit. +# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog. +changes: + - bugfix: "Gives the civvie yacht crew IDs." + - bugfix: "Fixes access problems on the Headmaster ship." + - bugfix: "Fixes some typoes in the ZI machine pistol and various Medina stuff." + - bugfix: "Fixes Vaurca workers causing quakes when they jump." + - bugfix: "Adds Dominian armor and helmets to their gear crates." diff --git a/icons/clothing/backpacks/dominia_backpack.dmi b/icons/clothing/backpacks/dominia_backpack.dmi index 83f1a864b4ab36e0d00a011f4c73e178ec44a413..fc0662509016956e026350f1b4ca2a5746508623 100644 GIT binary patch delta 1852 zcmZ{lc|6;P8^^yP8j-4{Q`C^UkD^*Cj#S)7Db~=-Ib#TEt?Eb|Nh#X2XkTx4EYr79y@}dvLVc|E%(X z_P68D{T)4waDfbjRq+v5foeG#918#TI99YM=&p5RP|33AHaFUHULzG@iqP+I<8Q1UxWt4{!QwE)-L5+>jeY&vubi%y#7ohzZNlCe)to(z$2dm39nvKKVJ0_!JW0#HOOUPu2 z-F4e)!W?*9sR12@&(ZkM_^M9VMKud!>y>Ai*jC9+P#4inS2KV_c3LC!oY|-+{dg>@ zYBI?<=+}L5cbVw=S+!AK=1@W&qG*2p8+kc7cXNa@k@k*2yCu@P56!(Y%VwWZ*P?9uV$lgkeDC~N1%gC%849JY?J};uAKJtNnnr$_I z!3Hqv+Vai^!*4^4WwL=GYQ~HLhFUB+&JV%797vsxN3a%qvb6JK80&sCX3_EX!JWQd z9F}Ne5&cPSWxVF?9|rfY>wPB-VbQOOdK`GPn$7XHHg8Z}hLda_eXM+M*pTTY`_V$L zx_)mgk!`U|*prlZ64=$UMY{GfO9#enRhkx96m2`hc9au z^+)!4f0t`jC5`eN>2Sbgz)m1dWfu$RYsB9q2u;63vA8f#XIeuI7j)A|eQb1aGuasz zJ}c3E!c=ves?`k#cJOJgT{?BSw7@O?;2`p*6N z&Aq8tZmf$y;x4xq9+)5kd?_)R>!`MDJ(tpg>mm%FO0BgA8Tb$>^rwJegUwdy-US0V z8bPRIrvk@fvCktl`>%(_9hSsdlErfPh-QR3urk0D;^kE8w-q>-_*~g@AqyWmObYe{ zCM(m_ETx~+_WAF(-%SYzH|I8^+_nqk#e&b2%S{aOptO$f&qMDWC}Bs0c-AI6Z2{wZ zJHqbq)*T|r>DIX!oOAhAjGLR3kJ~|8d8le9fsp==YJ$&`|EiIZat2*&Hlp>aZ{^bF zWa3qkwO$J4;ZI_u9=T&l%M)6Xl9G&m-VPv@1VZDraH%sL61f_T7@PfO7+KiB7`TienQnBQ`gkA6Q5E@1 zFcsjxU`))vcR|U+hZOL(83@NuCzr$A!>%FM+{0{ z&uo~aci20cXR`(nW(kE)O*^IWP|LW{g6f))fhx#@Se0sUu;CQNk9jSIO`K@!>(hR@ zhJtkS1iL2(sxob}nHL67s~>(uQ(%Q)116U1Js*Wk@e{`D#~!D9UkPN_ za+t`Q7~dEST@&Ia)JsDn*2DL>FZUAe`jkG;w z)NYygSctdScoS;aj;Mo0GIfX+(QSU6+GIFW#1fRmV0`TY~g8<*52e1pOJSzg5!y2mK!eFcjke7ozimd-x{-Cp%Z$Dr^6w F{{f#ZhMoWb delta 749 zcmVH(b3UcJT`4bJ^%mzf`Wo|b#;%Ak5yGwK0ZD(Gc&-z zzOtAIp((jtHhP1^+by!g<>#kq74f`41k#iwYH z6=W8meb*k_&Obk7*VevY@|YFeyY#+pyXSbHviQE6=|1}xxU+MLiaS6ZM1N+(Ln*W2)OwtTKJT`jggfUK1VIplzd*Au%BOANYhRR4 zE5~VbpfKmnfx^fuc>5h-{C^!6D*dwRKVioIujK9zYBR)iG(N!O0-5^*#{XwB_Xlx+ zaUjyiD396u1KR&@Wc0m);runC>BITvj;y`Y{=aeo+V@9~YG3bbzkj$nolpD!GECB9 zz<4>~J20ML*#YkUfcF2H-2H*E<46?oR09vApm6?Qt++qn>^a7!mc2i?`9B@b5{D-% zNHbf1hkJrGfC19{fj(c-UcWSV#T=w^Cm;xdAiNv6(3jKvEVxU(%CIWRrC#Nj6(#hq z()>zZ!N1>u_`mT54R(