Flavour-only height system no longer gives shells away, also grammar tweaks (#16309)

* the pr

* found more problems

* test fix

* returns

* Update examine.dm

* just about

as opposed to around about

* Update sniblet-sameheightyou.yml

* around instead

just obsessing over wording

* Update code/modules/mob/living/carbon/human/examine.dm

Co-authored-by: Matt Atlas <mattiathebest2000@hotmail.it>

* like this?

---------

Co-authored-by: Matt Atlas <mattiathebest2000@hotmail.it>
This commit is contained in:
Sniblet
2023-05-18 11:01:43 -04:00
committed by GitHub
parent 6f87b082c5
commit ecb31f35fd
3 changed files with 21 additions and 6 deletions
@@ -461,7 +461,7 @@
return output_text
/mob/living/carbon/human/assembleHeightString(mob/examiner)
var/heightString = null
var/list/heightString = list()
var/descriptor
if(height == HEIGHT_NOT_USED)
return heightString
@@ -483,7 +483,9 @@
descriptor = "huge"
else
descriptor = "gargantuan"
heightString = "[get_pronoun("He")] look[get_pronoun("end")] [descriptor] for \a [species.name]"
heightString += "[get_pronoun("He")] look[get_pronoun("end")] [descriptor]"
if(!species.hide_name)
heightString += " for a [species.name]"
if(examiner.height == HEIGHT_NOT_USED)
@@ -501,7 +503,7 @@
if(-10 to -6)
descriptor = "slightly shorter than"
if(-5 to 5)
descriptor = "around about the same height"
descriptor = "around the same height as"
if(6 to 10)
descriptor = "slightly taller than"
if(11 to 20)
@@ -513,6 +515,5 @@
else
descriptor = "to tower over"
if(heightString)
return heightString + ", and [get_pronoun("he")] seem[get_pronoun("end")] [descriptor] you."
return heightString += ", and [get_pronoun("he")] seem[get_pronoun("end")] [descriptor] you."
return "[get_pronoun("He")] seem[get_pronoun("end")] [descriptor] you."
+1 -1
View File
@@ -1542,7 +1542,7 @@
if(-49 to -11)
descriptor = "shorter than"
if(-10 to 10)
descriptor = "around about the same height"
descriptor = "about the same height as"
if(11 to 50)
descriptor = "taller than"
if(51 to 100)