cyberpresidentvanellope/Aurora.3
1
0
Fork 0
mirror of https://github.com/Aurorastation/Aurora.3.git synced 2026-08-22 20:43:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix GPS Test Fail (#21760)

Browse Source 
Fixes this test fail. One of our unit tests is randomly spawning a GPS
in a null location, which causes a runtime error when the GPS attempts
to print the coordinates of said null location. I've added sanity
checking to prevent this obnoxious test fail.

<img width="1379" height="759" alt="image"
src="https://github.com/user-attachments/assets/d5c15892-7272-4d24-886b-5c30432a35e5"
/>
This commit is contained in:
VMSolidus
2026-01-28 23:04:09 +00:00
committed by GitHub
parent bcd29944b7
commit ecd88fee14
3 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/telesci/gps.dm
+17 -1
View File
@@ -248,7 +248,23 @@ GLOBAL_LIST_EMPTY(gps_list)
return
var/area/gpsarea = get_area(src)
var/gps_areaname = get_area_display_name(gpsarea, TRUE, FALSE, FALSE, TRUE)
GLOB.gps_list[gpstag] = list("tag" = gpstag, "pos_x" = T.x, "pos_y" = T.y, "pos_z" = T.z, "area" = "[gps_areaname]", "emped" = emped, "compass_color" = compass_color)
// Sanity checking with default locations in case something isn't right with locational data.
// The GPS will prefer the coordinate of its turf, but if the turf is null it will try the coordinate of whoever is holding it.
// And if both fail, it'll default to <0,0,0> so we don't crash.
var/x_coord = 0
var/y_coord = 0
var/z_coord = 0
if (T)
x_coord = T.x
y_coord = T.y
z_coord = T.z
else if (held_by)
x_coord = held_by.x
y_coord = held_by.y
z_coord = held_by.z
GLOB.gps_list[gpstag] = list("tag" = gpstag, "pos_x" = x_coord, "pos_y" = y_coord, "pos_z" = z_coord, "area" = "[gps_areaname]", "emped" = emped, "compass_color" = compass_color)
if(check_held_by && held_by && (held_by.get_active_hand() == src || held_by.get_inactive_hand() == src))
update_compass(TRUE)