From ece73e279b025d82cd97df548908a2f6260d4ba7 Mon Sep 17 00:00:00 2001 From: Doxxmedearly <38594443+Doxxmedearly@users.noreply.github.com> Date: Sun, 20 Aug 2023 10:14:59 -0400 Subject: [PATCH] Alt-title access fixes (#17091) * Alt-title access fixes * Makes life harder for learners --- code/datums/outfits/outfit.dm | 4 ++-- code/game/jobs/job/job.dm | 2 +- html/changelogs/doxxmedearly-alt_title_access_fix.yml | 5 +++++ 3 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 html/changelogs/doxxmedearly-alt_title_access_fix.yml diff --git a/code/datums/outfits/outfit.dm b/code/datums/outfits/outfit.dm index 0fe44d432a2..f0622c5b8ca 100644 --- a/code/datums/outfits/outfit.dm +++ b/code/datums/outfits/outfit.dm @@ -542,10 +542,10 @@ /datum/outfit/proc/get_id_access(mob/living/carbon/human/H) return list() -/datum/outfit/proc/get_id_assignment(mob/living/carbon/human/H) +/datum/outfit/proc/get_id_assignment(mob/living/carbon/human/H, var/ignore_suffix = FALSE) . = GetAssignment(H) - if (. && . != "Unassigned" && H?.mind?.selected_faction) + if (. && . != "Unassigned" && H?.mind?.selected_faction && !ignore_suffix) if (H.mind.selected_faction.title_suffix) . += " ([H.mind.selected_faction.title_suffix])" diff --git a/code/game/jobs/job/job.dm b/code/game/jobs/job/job.dm index e3f7e7d1f02..ea4fe87a22a 100644 --- a/code/game/jobs/job/job.dm +++ b/code/game/jobs/job/job.dm @@ -239,7 +239,7 @@ var/datum/job/J = SSjobs.GetJobType(jobtype) if(!J) J = SSjobs.GetJob(H.job) - return J.get_access(get_id_assignment(H)) + return J.get_access(get_id_assignment(H, TRUE)) /datum/outfit/job/get_id_rank(mob/living/carbon/human/H) var/datum/job/J = SSjobs.GetJobType(jobtype) diff --git a/html/changelogs/doxxmedearly-alt_title_access_fix.yml b/html/changelogs/doxxmedearly-alt_title_access_fix.yml new file mode 100644 index 00000000000..fed5a7417de --- /dev/null +++ b/html/changelogs/doxxmedearly-alt_title_access_fix.yml @@ -0,0 +1,5 @@ +author: Doxxmedearly +delete-after: True +changes: + - bugfix: "Corporate reporters once again have their intended basic access to most departments." + - bugfix: "Fixed an issue with tech support being unable to access certain program functions."