Commit Graph

11866 Commits

Author SHA1 Message Date
Ron
97e8955445 Misc Bug Removal (#2045)
vampire_powers.dm ~ vamps now know if they finished enthralling. Fixes #1705
utility.dm ~unconscious people cant feel things injected anymore. Fixes #606
security.dm ~7 days to play as sec now. Same with detective and warden. might need config option enabled. Fixes #1973
exodus-1.dm ~ removed useless circuit board. Fixes #1991
supplypacks.dm ~ Auxilllary Foensic tools crate spawns with a UV light now. Fixes #1936
tree_networking.dm ~ gave the malf AI more room to type things up. Also fixed typo. Fixes #1914
Made the viral infection outbreak say level 5 all the time so it matches up with sound file.
2017-04-08 19:10:48 +03:00
MarinaGryphon
f849657a62 Fixes #1163 (#2054)
Made the robotics control console check for R.lockcharge instead of !R.canmove to avoid issues with chairs.
Gave silicons their own custom /update_canmove() proc to deal with lockdown.
Made the robotics control console use SetLockdown(), like the lockdown wire.
2017-04-08 17:32:13 +03:00
MarinaGryphon
32b570871f Protohuman Fixes, Transform Procs, and Genetics Fixes (#2059)
Added a Humanize() proc that converts from lesser to greater form.
Made Monkeyize(), Humanize(), handle_post_spawn(), and set_species take a 'keepgenes' argument that tells whether or not to keep or override the gene for lesser or greater form.
Fixed what I presume is a typo in defining the 'hard' genetics bounds.
Made MONKEYBLOCK actually functional.
2017-04-08 17:30:31 +03:00
inselc
238ce7a80c Bugfixes: Drones, Infrared emitters, Implant cases and Limbs (#2049)
This PR contains bugfixes for:

Drones being unable to matter-decompile burnt matches (#717). Burnt matches will be decompiled into a small amount of wood.
Ghosts triggering infrared emitters (#644). Added a check whether the movable passing through the laser beam is actually "visible".
Reagent transfer messages showing up when clicking on chem implant cases, even when the syringe is empty (#704). Added a check whether reagents have actually been transferred. The displayed message will now also display the actual amount transferred. Removed spawn(5)-delay to prevent click-stacking.
Limb relocation messages not showing up for bystanders (#778).
2017-04-07 23:53:21 +03:00
Lohikar
636aef2970 Tactical Holster Fixes & Random Obj Runtime Fix (#2043)
changes:

Fixed some issues with tactical armor's holster.
Made tactical armor qdel its child storage instead of just nulling it out.
Hopefully fixed the runtimes with random voidsuits.
Fixed a bug where random vendors were always depleted.
Fixed a bug where industrials could not set their eye color.
Fixes #2041.
Hopefully fixes #1740.
2017-04-03 22:43:38 +03:00
NanakoAC
af960ce8d1 Pylon succ bugfix (#2010)
Just fixes a small reported issue with pylons, where a ventcrawling creature could get dragged out of the pipe network and stuck under the floor. Adds some safety checks to the sucking mechanic
2017-04-03 22:42:15 +03:00
Lohikar
80fb7af058 IPC Fixes & Nutrition Tweaks (#2037)
changes:

Only normal crew mobs equipped by the job master spawn with randomized nutrition.
Random nutrition's minimum nutrition value has been increased to 50%.
IPC Shells' skin tone and eye color now functions correctly.
Industrials' eyes now work correctly.
Added a nullcheck to random voidsuit spawn.
Fixes #1909.
Fixes #1646.
Fixes #1503.
Probably fixes #1740.
2017-04-02 16:53:53 +03:00
Lohikar
26a189a703 Code cleanup: /obj/random (#2014)
changes:

Cleaned up most random objects to use lists instead of a spawn proc.
Probably fixed a bug where vendors could spawn with fractions of an item.
Probably fixes #1740.
2017-04-02 01:28:10 +03:00
Alberyk
ae5ebc19f1 Ghostrap update and minor fixes (#2019)
-moves skeleton minions,wizard familiars and syndicate borgs to the ghost trap system
-allow syndicate command and deathsquid to deploy their suit fully when equipped
-fix some wrong hardsuit modules names in rd
-fix immortal skeletons being able to spam immortality
-removes the alien death proc
-fix items not dropping when hands, feet or heads are cut off
-removes the paint from cargo spam
2017-04-02 00:10:55 +03:00
Werner
59e7377798 UDP Logging (#1997)
This implements UDP Logging with GELF.
It will allow full text search over all the logs and attributes sent over GELF to the log server.
2017-04-01 23:47:00 +03:00
Alberyk
b5353d1659 Fix loadout dress uniforms and cult book spam (#2013)
-fix #2011
-fix attacking people with cult books having no delay
-nerf frag grenades a bit
-fix #1988 but this may end allowing you to hit people if you use the wrong tool, but, however will make things far easier for borgs or people doing surgery
2017-03-29 18:38:53 +03:00
Lohikar
f3b0edf03e Fix smoke (#1996)
changes:

Smoke no longer leaves mysterious patches of darkness.
Smoke now uses client-side animations instead of while loops.
Fixes #1985.
2017-03-26 12:37:35 +03:00
inselc
2d8739a279 Bugfixes: Fax machines (again), crew record formatting, RnD machines and wallets (#1987)
Trying to work off some of the older bugs on the issues list:

Fix faxmachine getting stuck on "0 seconds remaining". There may be a process scheduler issue which causes a long polling interval for the faxmachine's process()-method.
Replace newline in crew record notes with <BR> when generating the records in the filing cabinets.
Surround crew record notes with "preformatted text" HTML tags on PDA / pAI screens.
When constructing protolathes or circuit imprinters, transfer the reagents contained in the beakers to internal reagent container upon completion.
Fix suspension field generator not clearing the qdel'd suspension_field reference. This fixes being unable to unwrench the generator, too.
Fix wallet sprite still showing an empty wallet when inserting a guest pass.
2017-03-25 23:47:04 +02:00
NanakoAC
7bc50597a7 Vendor Exploit Fix (#1967)
Fixes a pretty severe exploit where spambuying from a vendor allows you to purchase a larger quantity than the vendor has. Coupled with the ability to add things, this is basically infinite item duplication. How did we not notice this before now?

I kept the spam buying, because it's pretty nifty, but added a safety check to ensure there's one remaining to buy

In addition, adds a little exception that allows bluespace technicians to take free stuff from vendors. Largely for debugging. I'm sick of having to spawn as a crewmember to do anything vendor related, this will save a bit of development time in the long run.
2017-03-23 00:58:34 +02:00
NanakoAC
8d323f1b06 fixed pylon things (#1966)
Fix for GC/destroy issues with pylons, as discussed in discord
2017-03-22 20:15:53 +02:00
Alberyk
670adb46a2 Do not Nerf pylons, sadly, and other things (#1962)
-nerfed overall accuracy, and removed burst, of the scout rifle
-removed a fuckton of white space from nanacode
-should fix ipcs being stung by changelings at long last
2017-03-22 20:14:45 +02:00
NanakoAC
791dfda69f Pylon Balance Pass 1 (#1963)
Iterative balancing of pylon turrets based on feedback and observations. Small nerfs in a variety of areas.

Notably, removed armor penetration from the base (non-empowered) turrets.
Slightly reduced damage, range, durability and empower gain
2017-03-22 15:17:50 +02:00
Lohikar
27d328f6fb Lighting fixes (#1952)
Changes:

Fixes #1949.
Removes some pooling in favor of new-qdel.
Lighting startup spam is now correctly sent to R_DEBUG.
Fixes some spark runtimes.
2017-03-21 06:51:21 +02:00
NanakoAC
5898326034 Cooking and Reagent Fixes(#1953)
Went searching for the cause of the reagent runtime issues. I don't think i found it yet, but i found and fixed a couple things that could be causing it.

Most notable is an egregious bug that caused animals' reagent holder to be nulled after they're dropped from a holder.
Also adds a little safety check to recipes which may fix it.

Fixes two cooking bugs as well. One that was allowing extra containers to be inserted into an already-full oven (they nested inside other containers, it was messy) and a tiny issue with batter overlays being incorrect on cooked meats.
2017-03-21 06:50:40 +02:00
Alberyk
3ed3a13548 Fix nooses runtime and food capitalization (#1955)
-fix #1946
-changes most of the capitalization related to food and drinks names
2017-03-21 06:49:44 +02:00
Alberyk
61f50831b4 Lunchbox fixes (#1945)
-fix lunchboxes being borked
-tweaks somethings in the wallet
-fix the locker item and add it to the custom loadout
-adds check to stop mouse from hanging people
2017-03-20 22:24:35 +02:00
skull132
e60ab072fc Merge branch 'development' 2017-03-20 15:33:46 +02:00
NanakoAC
6f15bf2e14 Emergency Cooking Fixes (#1944)
This PR fixes a number of isssues with cooking that were overlooked during testing.

The cause of the infinite loop:
I neglected to add a buffer to hold cooked items to the microwave when i did likewise for other appliances, this is necessary for bulk cooking as it ensures that things which were just cooked, aren't considered as potential ingredients.
The lack of this buffer caused donk pockets to iterate forever, because the result (a cooked donk pocket) is a valid ingredient to create a cooked donk pocket. so it made the same recipe millions of times over. This is now fixed.

Runtime errors.
A few items would throw runtime errors because they override the make_food function which i significantly altered, and return data in the wrong format. This is now fixed. Affected items were: Donk pockets, valid salad, fortune cookies, amanita jelly.

Uncookable items.
A few recipes were impossible to create in appliances due to my neglecting support for adding non-snack items to cooking containers. This mostly affects diona roast and fortune cookies.. For now i've gone with a simple whitelist approach, allowing paper and holders to be added.
2017-03-20 15:32:39 +02:00
Lohikar
449919c905 Fixes (#1943)
changes:

Fixes PDA manifest.
Fixed some bad turfs on the outpost.
Very slightly sped up lighting initialization.
Fixed mine turfs bordering on space turfs having a bad edge.
Possibly sped up asteroid gen slightly.
2017-03-20 08:13:17 +02:00
Alberyk
bb6a5e167e Custom loadout and medal box fix (#1941)
-fix some issues with the custom loadout
-fix #1940
2017-03-19 23:47:33 +02:00
skull132
9885337cab Merge branch 'master' into development 2017-03-19 21:08:28 +02:00
skull132
9c78f5b4c6 Swap memos to be Discord pins instead (#1382)
Intent:
If using a Discord bot, make it so that the game is able to pull and process pinned messages in specific discord channels as memos.
2017-03-19 21:07:29 +02:00
NanakoAC
67bb388a5a Additional Pylons (#1870)
This PR adds a new utility mechanic for the cult. Pylons can now be upgraded into arcane defensive turrets, which fire bolts of demonic energy. These turrets are entirely automated, somewhat-rapid firing, extremely accurate and quite long ranged, but their damage is very low, and thus their total DPS, even with the fire rate, is still far lower than most real ranged weapons.
2017-03-19 00:06:36 +02:00
Alberyk
ae5956fd6e Wizard blade, loadout and general dev tweaks (#1905)
-add reflection and parry to the wizard rune sword
-tweaks and add more things to the custom loadout
-remove the linebin and thermals from cargo
-add exosuit paint kits and some other things to cargo spawn
-re-add the non slip flag to skrells
- Fixes #1890
-adds more hats
-beastmen botanists now get some snowflake gloves
-unathi are now poisoned by alcohol, at jackboot's request
-fix smacking people against toilets having no delay
-fix some visible message issues and wrong date in the sink and shower
-removed being able to select bst gear using chameleon clothing
-fix some grammer
-fix vaurca voidsuits having an outdated species
2017-03-19 00:05:25 +02:00
Lohikar
63eafb3643 Code Cleanup: Destroy() fixes part 1 + Misc Fixes (#1933)
In this PR:

Destroy() fixes backported from PR #1783.
JaniPDA fixes & improvements.
Chickens no longer consume their own eggs.
Language adding in setup is now 100% more sane.
Chemical dispensers now actually check that the user is still alive before renaming.
Ghosts are now marked as non-simulated atoms.
Non-simulated atoms no longer trigger proximity listeners.
Vendors no longer accept synthetic tools as stocking options.
Fixes #812.
Fixes #1877, Fixes #1929.
Fixes #1930.
Fixes #1152, Fixes #1917.
Fixes #1902.
Fixes #1165.
2017-03-18 23:06:24 +02:00
Alberyk
4b93a20a5e Adds ipc loyalty chip (#1934)
By the quest of the lore team, adding an ipc version of the loyalty implant for when synths will be able to be loyalty implanted roles.
2017-03-18 20:52:41 +02:00
Lohikar
31a776b373 Maintenance & Atmos Ambience (#1926)
changes:

soundadd: "Maintenance has 100% more ambience."
soundadd: "Atmos now has its own ambience sound, distinct from the rest of Engineering."
Sounds from /tg/ station, licenced under AGPLv3.
2017-03-18 20:09:13 +02:00
Lohikar
d3242f13a5 Abstract machinery, intercom listener, and directional hardhat lights (#1918)
changes:

Added an abstract-machinery helper type for interacting with power systems without duplicating power code.
Changed intercoms to use abstract machines to handle power state changes instead of polling with process().
Hardhat lights are now directional (LIGHT_WIDE)
Fixes #1922.
2017-03-18 20:06:45 +02:00
NanakoAC
fa12422854 Mining chargers, fruit slices, windoors (#1897)
A bugfix pack of various unrelated stuff. I just poked through the issues list and cherrypicked stuff that looked quick or within my knowledge

Adds some Mech charging pads to the mining outpost. Two inside, one outside near the drills.
I also tweaked the charging pad sprite to remove the background. Basically it had a normal floor tile built into the sprite, which looked dumb on any other kind of floor. i made that part transparent. And the ones in the robotics lab didn't have an actual floor tile under them because of that, someone was lazy when mapping. so i fixed that too.

Fixes fruit slices being inedible. Someone was using Round when dividing their reagents. Protip: never round reagent amounts. the system handles decimals just fine. There was also an error with the loop

Fixes being unable to build multiple windoors on a tile.I fixed it so you can do so, but they cant stack ontop of each other (or existing windows). I also made sure they can't be rotated to stack onto existing border items. And added another rotate verb for windoor assemblies, and fixed their missing ON_BORDER flag.

Nerfed the hallucination chance of paroxetine, to make it less of a meme when prescribed clinically.

Fixes the engiborg inflatables dispenser permanantly breaking if you allow it to run out. That was my fault

fixes #990
fixes #862
fixes #1875
fixes #1842
fixes #1742
2017-03-18 20:04:13 +02:00
Lohikar
263bb7ab8d RnD & Cat fixes (#1913)
changes:

bugfix: "Fixed an issue where some objects could not be deconstructed with RnD."
bugfix: "Helmet lights now actually display the powered-on sprite."
bugfix: "Cats on heads no longer magically turn invisible."
bugfix: "Cyborgs' portable destructive analyzer can no longer steal intercoms or the captain's safe."
imageadd: "Duffle (duffel?) bags now have in-hand sprites."
Fixes #1158 
Fixes #1662
2017-03-12 12:18:58 +02:00
Lohikar
a337279c86 Better area animations (#1900)
changes:

Area lighting effects are now done using animate() calls and color instead of animated sprites.
With this change, these effects can be drawn at the client BYOND's native refresh rate.

The animations are smoother in-game than they are in the GIFs.
2017-03-12 12:17:18 +02:00
NanakoAC
ceff4ae424 Tech Fixes: (#1888)
Fixes #1790 
Fixes #1791 

Fixes a number of issues with robot sprites, chem master machine, and surgery steps

The issue with borg sprites was caused by duplicate calls to ..()
Ive standardised robot module parent calls to the top of the function

Fixed the chemmaster not depositing pills in bottles properly. I added a new add_to_storage proc to storage.dm which is just a simple, safe means of putting stuff in stuff. it handles the checking.

Fixed some issues with surgery. A few surgery steps had incorrect "open" var ranges defined which was causing organ repair surgery to be interfered with

Also removed screwdriver from the list of bone mending tools, and added duct tape instead as the ghetto alternative. And allowed energyswords + chainswords to be used for cutting open ribs. theyre already useable for amputation

Fixed an incorrect return var for surgery that was making surgeons able to attack their patients on help intent. Shouldnt happen anymore

And also fixed the experimental welder being un-makeable at the protolathe.
2017-03-12 11:52:33 +02:00
Lohikar
cd52c36313 Lighting fixes part 307 (#1896)
changes:

Fixes missing icon for powered off night-mode tubes.
Nerfs borg floodlight back to sanity.
Reduces the light power on red-alert level fire alarms a bit.
2017-03-12 11:51:07 +02:00
Werner
1426392904 Price Changes requested by Jackboot (#1892)
Change the prices as requested by Jackboot
2017-03-06 23:56:19 +02:00
skull132
335f3f8261 Merge branch 'master' into development 2017-03-06 01:01:12 +02:00
LordFowl
cb4a941dc1 Sword Reflection (#1637)
Energy swords, shields, and ninja blades can now deflect projectiles.

Energy swords have a fairly moderate chance of reflecting energy weapons.
Energy shields have a much higher chance of reflecting energy weapons.
The ninja blade has the highest chance of reflecting energy weapons.

Energy sword and ninja blade can only effectively reflect shots to the groin, chest, and head.
Energy shield has full body coverage.

Energy sword has less "durability" than shield and blade (Can withstand less shots before shutting off.)

Neither sword, shield, nor blade can deflect shots to the back. Only the ablative vest provides full coverage.

Probably some other stuff I'm forgetting.
2017-03-06 00:35:09 +02:00
skull132
c5b9d75e34 End The Contest (#1887)
It was fun.
2017-03-06 00:26:18 +02:00
Lohikar
e2725ab4cb Computer dark visibility tweaks (#1829)
changes:

Holo-computers' displays now draw above the lighting layer, allowing them to be seen in the dark.
APCs' displays now draw above the lighting layer, allowing them to be seen in the dark.
2017-03-05 22:28:11 +02:00
Alberyk
fd217ec773 Changeling updates and fix (#1765)
- Fixes #1660
-re-added old code changeling features, like non-stealthy sting and arm blades, with proper sprites this time, and shields
-changeling revive will now be only triggered when the ling wants to come back
-lings can't ling monkeys anymore
-fixed ipcs being affected by stings
-removed species transformation skill, now, using transform will turn you also into said species
2017-03-05 22:05:27 +02:00
Lohikar
73c29bd5a7 Miscellaneous Fixes (#1868)
changes:

Engineering now actually gets engineering-type alert consoles instead of the non-functional base type.
Lighting is no longer broken by shuttles.
The ERT shuttle autoannouncer should no longer cause lighting runtimes.
Fixed some bad newlines in some character setup help texts.
Custom loadout tweaks now properly write to SQL.
Custom loadout is now saved as JSON.
Players are now shown a notice when the server was unable to load their custom loadout.
Drowsyness is now clamped to zero.
Added some new tips to the example.
Tweaked some tips' grammar.
Removed some tips that do not apply to our code base.
Probably fixes embraced vampire thralls not getting vampire verbs.
Fixes #1844.
Fixes #1835.
Probably fixes #1687.
Probably fixes #1824.
Fixes #1839
2017-03-05 15:14:28 +02:00
Lohikar
7bc62acb6e Pooling fixes (#1866)
Fixes some bad arguments on getFromPool calls that were causing things to not work correctly.
Fixes #1800.

Damn you butterfly effect.
2017-03-05 02:05:14 +02:00
Lohikar
97856e8735 Improved scheduler (#1864)
changes:

Rewrote scheduler to use a sorted linked-list to store scheduled tasks so that only one element needs to be checked if none of the tasks are ready to fire.
Scheduler now checks tasks every 2 ds.
Adding tasks to an empty scheduler or tasks that are triggered after any existing tasks is fast, but adding tasks that trigger between two existing tasks requires iterating through some of the task list.

It's no addtimer(), but it's something.
2017-03-05 02:01:06 +02:00
printer16
44cb24e4cb Fixes #1841 (#1849) 2017-03-05 00:12:05 +02:00
LordFowl
e00ba48c8f SolRep Uniforms (#1856)
After discussing it with Jackboot, I have decided to give the SolRep their own uniform. In an attempt to differentiate them from the captain, I created a new uniform sprite based off of the US Navy Dress Blue uniform.

Since SolRep's and their alternate title of IAA are very different, I decided it would be best to spawn all of the SA gear on the SolRep specifically, so that the IAA doesn't get greedy with a locker.

The SolRep now spawns with:
A regular pair of sunglasses.
A Lieutenant Sol Navy dress uniform
A Navy cap
Laced dress shoes
A ceremonial sword

They no longer spawn with a briefcase.

I also switched the sprite of the Marine dress cap and the Navy dress cap, because I believe that they better match their source this way.

I also renamed the dress whites uniform to be Sol Navy Commander Dress Uniform, and the Dress blues are Sol Navy Lieutenant Dress Uniform. This is to me the best way to convey rank without creating a whole new insignia accessory.
2017-03-01 08:22:59 +02:00
skull132
9823371e1a Fix whitelists for antag event
Whoever thought that using strings in this, and not var/flag, deserves to be shot.

Hardcoded strings are godawful.
2017-02-28 12:42:08 +02:00