changes:
Added new airlock close sounds.
Added airlock bolt/unbolt sounds.
Airlocks now use audible_message() to print bolt messages instead of for-mob-in-view.
Sounds courtesy of Bay.
Port of Baystation12/Baystation12#13264
Large PR to put into Master, but the bug is really annoying and since it affect a traitor item, an often used one, I'll take the risk.
Fixes#1956
Fixes explosives implants and lawgiver not working.
A bug:
Synthetics are no longer able to authorize warrants. Fixes#2025
Various requests from the suggestions forum:
Removed bootknives from custom loadouts
Added crowbars to all borg modules that were missing them.
Removed flashbangs from the officer lockers and the security vending machine
Some other things:
Warden access is now required to access the armory with the flashbangs, heavy vests, ...
Fixed a issue with udp logging (wrong text in a log message)
.45s now spawn in the officer lockers
Flares now spawn in the officer lockers
The crate containing the door locks has been relocated
Added cadet lockers with essential cadet gear
Replaced two officer lockers with two cadet lockers, so there are now 4 officer and 2 cadet lockers in security
Warrant assistant now shows Location / Suspect for the search warrants (instead of only the location)
Stopped IPCs from being able to see without optics installed.
Made Industrial Frames actually pressure-proof, which allows them to use suit coolers on their back.
(Apologies for accidentally including some old commits. They've already been merged, anyway, so I hope it's not too much trouble.)
This PR is a package of fixes for a few cooking issues, and also (largely unrelated but its been annoying me for weeks) more fixing on the Flash issue.
Fixes the cooking sound not being set on cookers
Very thoroughly re-examines all interactions with cooking machines and their verbs, adds safety checks, alters contexts as intended. This gets rid of all the problems with mouse/ghost/AI fuckery.
Note that AIs can toggle the oven door and the power on cooking machines, this is by design.
Animals can remove food from exposed cooking containers, this is also by design.
Sets cooking containers to NOREACT, to prevent some issues with recipes being unmakeable because ingredients would become dough.
Tweaks oven heat loss a little more
Adjusts the mix flag on several potentially problematic recipes to prevent certain undesireable things ending up in finished products (like flour and eggs causing a lump of dough to be ejected from a finished cake)
Alters quite a few recipes which used a whole egg as an ingredient, to use egg yolk instead. Partly becase it makes more sense in context, and partly because cooking containers don't support adding whole eggs. There are now no fryer/oven recipes that need an intact egg.
Scales up plain bread to be a little closer to the other specialised breads in terms of reagent quantity.
Removes a redundant spellburger recipe because item checks use istype
And the flash issue:
For those who missed it, several months ago we had an issue with an object named "flash" appearing in the rightclick menu anywhere, for anyone with admin/dev powers. It was constantly annoying. After enduring the mysterious thing for months i found the cause, it's a hud element. Setting mouse opacity fixed it.
Anyways my fix wasn't comprehensive enough. Several other huds for non human mobs duplicate this thing. So ive set mouse opacity on them too
Fixes#1932 by adding an 'inuse' variable to airlock electronics and setting/checking whether it's in use when constructing doors.
Converted airlock_electronics.dm to absolute paths from relative paths.
changes:
ChangeTurf no longer breaks lighting when switching from statically lit turfs to dynamically lit turfs.
Human-types' is_noisy value is now updated on spawn; boots should now make footstep SFX without having to take them off and put them back on.
Fixed a logic error in is_noisy calculations which could have lead to false-negatives.
Shells can now wear socks & undershirts.
Fixed a bug where changing the dynamic lighting status on an area would attempt to build lighting overlays for the entire map.
Fixes#2027.
Fixes#1982.
Project partially commissioned by Senpai Jackboot.
This PR adds a new reagent, butanol. It is an alcohol intended for unathi consumption, intoxicating and safe for them. On other species it is also safe, but has a fairly minimal effect, and humans drinking it is generally a waste.
Butanol moonshine can be made in the kitchen by delinquent lizards.
Adds two butanol based drinks, imported from moghes.
Also adds a new Tajaran Gin, slightly weaker than a normal spirit. This is an ordinary ethanol drink with some kitty flavour text.
Kegs of beer and xuizi juice can now be ordered in cargo. Prices may seem low but they come in a non-returnable large wooden crate
Fixes several bugs with alcohol effects not wearing off.
While fixing this I ran into another issue, and the easiest fix was something i've been meaning to do for a while:
Added a verb for bluespace techs to toggle their god mode on and off.
Intoxication with god mode on is now essentially disabled. It was causing too many buggy effects. If bluespace techs want to get drunk for adminbus RP, they can disable godmode first.
Fixes#1748
The Kneebreaker Hammer should no longer do hilarious amounts of damage should you find a way to make it go through the air faster than it would if you threw it.
Well, no more damage than it would if you applied such a thing to any other item.
vampire_powers.dm ~ vamps now know if they finished enthralling. Fixes#1705
utility.dm ~unconscious people cant feel things injected anymore. Fixes#606
security.dm ~7 days to play as sec now. Same with detective and warden. might need config option enabled. Fixes#1973
exodus-1.dm ~ removed useless circuit board. Fixes#1991
supplypacks.dm ~ Auxilllary Foensic tools crate spawns with a UV light now. Fixes#1936
tree_networking.dm ~ gave the malf AI more room to type things up. Also fixed typo. Fixes#1914
Made the viral infection outbreak say level 5 all the time so it matches up with sound file.
Made the robotics control console check for R.lockcharge instead of !R.canmove to avoid issues with chairs.
Gave silicons their own custom /update_canmove() proc to deal with lockdown.
Made the robotics control console use SetLockdown(), like the lockdown wire.
Added a Humanize() proc that converts from lesser to greater form.
Made Monkeyize(), Humanize(), handle_post_spawn(), and set_species take a 'keepgenes' argument that tells whether or not to keep or override the gene for lesser or greater form.
Fixed what I presume is a typo in defining the 'hard' genetics bounds.
Made MONKEYBLOCK actually functional.
This PR contains bugfixes for:
Drones being unable to matter-decompile burnt matches (#717). Burnt matches will be decompiled into a small amount of wood.
Ghosts triggering infrared emitters (#644). Added a check whether the movable passing through the laser beam is actually "visible".
Reagent transfer messages showing up when clicking on chem implant cases, even when the syringe is empty (#704). Added a check whether reagents have actually been transferred. The displayed message will now also display the actual amount transferred. Removed spawn(5)-delay to prevent click-stacking.
Limb relocation messages not showing up for bystanders (#778).
changes:
Fixed some issues with tactical armor's holster.
Made tactical armor qdel its child storage instead of just nulling it out.
Hopefully fixed the runtimes with random voidsuits.
Fixed a bug where random vendors were always depleted.
Fixed a bug where industrials could not set their eye color.
Fixes#2041.
Hopefully fixes#1740.
Just fixes a small reported issue with pylons, where a ventcrawling creature could get dragged out of the pipe network and stuck under the floor. Adds some safety checks to the sucking mechanic
changes:
Only normal crew mobs equipped by the job master spawn with randomized nutrition.
Random nutrition's minimum nutrition value has been increased to 50%.
IPC Shells' skin tone and eye color now functions correctly.
Industrials' eyes now work correctly.
Added a nullcheck to random voidsuit spawn.
Fixes#1909.
Fixes#1646.
Fixes#1503.
Probably fixes#1740.
changes:
Cleaned up most random objects to use lists instead of a spawn proc.
Probably fixed a bug where vendors could spawn with fractions of an item.
Probably fixes#1740.
-moves skeleton minions,wizard familiars and syndicate borgs to the ghost trap system
-allow syndicate command and deathsquid to deploy their suit fully when equipped
-fix some wrong hardsuit modules names in rd
-fix immortal skeletons being able to spam immortality
-removes the alien death proc
-fix items not dropping when hands, feet or heads are cut off
-removes the paint from cargo spam
-fix #2011
-fix attacking people with cult books having no delay
-nerf frag grenades a bit
-fix #1988 but this may end allowing you to hit people if you use the wrong tool, but, however will make things far easier for borgs or people doing surgery
Trying to work off some of the older bugs on the issues list:
Fix faxmachine getting stuck on "0 seconds remaining". There may be a process scheduler issue which causes a long polling interval for the faxmachine's process()-method.
Replace newline in crew record notes with <BR> when generating the records in the filing cabinets.
Surround crew record notes with "preformatted text" HTML tags on PDA / pAI screens.
When constructing protolathes or circuit imprinters, transfer the reagents contained in the beakers to internal reagent container upon completion.
Fix suspension field generator not clearing the qdel'd suspension_field reference. This fixes being unable to unwrench the generator, too.
Fix wallet sprite still showing an empty wallet when inserting a guest pass.
Fixes a pretty severe exploit where spambuying from a vendor allows you to purchase a larger quantity than the vendor has. Coupled with the ability to add things, this is basically infinite item duplication. How did we not notice this before now?
I kept the spam buying, because it's pretty nifty, but added a safety check to ensure there's one remaining to buy
In addition, adds a little exception that allows bluespace technicians to take free stuff from vendors. Largely for debugging. I'm sick of having to spawn as a crewmember to do anything vendor related, this will save a bit of development time in the long run.
-nerfed overall accuracy, and removed burst, of the scout rifle
-removed a fuckton of white space from nanacode
-should fix ipcs being stung by changelings at long last
Iterative balancing of pylon turrets based on feedback and observations. Small nerfs in a variety of areas.
Notably, removed armor penetration from the base (non-empowered) turrets.
Slightly reduced damage, range, durability and empower gain
Went searching for the cause of the reagent runtime issues. I don't think i found it yet, but i found and fixed a couple things that could be causing it.
Most notable is an egregious bug that caused animals' reagent holder to be nulled after they're dropped from a holder.
Also adds a little safety check to recipes which may fix it.
Fixes two cooking bugs as well. One that was allowing extra containers to be inserted into an already-full oven (they nested inside other containers, it was messy) and a tiny issue with batter overlays being incorrect on cooked meats.
-fix lunchboxes being borked
-tweaks somethings in the wallet
-fix the locker item and add it to the custom loadout
-adds check to stop mouse from hanging people
This PR fixes a number of isssues with cooking that were overlooked during testing.
The cause of the infinite loop:
I neglected to add a buffer to hold cooked items to the microwave when i did likewise for other appliances, this is necessary for bulk cooking as it ensures that things which were just cooked, aren't considered as potential ingredients.
The lack of this buffer caused donk pockets to iterate forever, because the result (a cooked donk pocket) is a valid ingredient to create a cooked donk pocket. so it made the same recipe millions of times over. This is now fixed.
Runtime errors.
A few items would throw runtime errors because they override the make_food function which i significantly altered, and return data in the wrong format. This is now fixed. Affected items were: Donk pockets, valid salad, fortune cookies, amanita jelly.
Uncookable items.
A few recipes were impossible to create in appliances due to my neglecting support for adding non-snack items to cooking containers. This mostly affects diona roast and fortune cookies.. For now i've gone with a simple whitelist approach, allowing paper and holders to be added.
changes:
Fixes PDA manifest.
Fixed some bad turfs on the outpost.
Very slightly sped up lighting initialization.
Fixed mine turfs bordering on space turfs having a bad edge.
Possibly sped up asteroid gen slightly.
This PR adds a new utility mechanic for the cult. Pylons can now be upgraded into arcane defensive turrets, which fire bolts of demonic energy. These turrets are entirely automated, somewhat-rapid firing, extremely accurate and quite long ranged, but their damage is very low, and thus their total DPS, even with the fire rate, is still far lower than most real ranged weapons.
-add reflection and parry to the wizard rune sword
-tweaks and add more things to the custom loadout
-remove the linebin and thermals from cargo
-add exosuit paint kits and some other things to cargo spawn
-re-add the non slip flag to skrells
- Fixes#1890
-adds more hats
-beastmen botanists now get some snowflake gloves
-unathi are now poisoned by alcohol, at jackboot's request
-fix smacking people against toilets having no delay
-fix some visible message issues and wrong date in the sink and shower
-removed being able to select bst gear using chameleon clothing
-fix some grammer
-fix vaurca voidsuits having an outdated species
In this PR:
Destroy() fixes backported from PR #1783.
JaniPDA fixes & improvements.
Chickens no longer consume their own eggs.
Language adding in setup is now 100% more sane.
Chemical dispensers now actually check that the user is still alive before renaming.
Ghosts are now marked as non-simulated atoms.
Non-simulated atoms no longer trigger proximity listeners.
Vendors no longer accept synthetic tools as stocking options.
Fixes#812.
Fixes#1877, Fixes#1929.
Fixes#1930.
Fixes#1152, Fixes#1917.
Fixes#1902.
Fixes#1165.
