This makes candles, matches, and cigarettes burn for longer than they
currently do. Matches burn for twice as long, candles for about +1/3 as
long, and cigarettes around twice as long.
Code note: I don't see any problems with this for matches and candles,
but there's a comment in the current code warning strictly not to lower
the smokable burn_rate below 0.01, see the changes. I haven't been able
to hunt down exactly why this is, and it seems like the burn_rate for
the parent type was already lowered down to 0.006 a few years ago by a
previous PR intended to extend cigarette burn times. From what I can
tell reagents are still being absorbed below 0.01 by having the
cigarette on your mask slot, so if there is a serious issue with this it
can be removed under review, but I'm not certain what it would be. I've
removed every subtype modification to burn_rate, which seems to have
been left a setting substantially higher than the parent, causing pipes
and cigars in live to seem to burn out very quickly - like in a little
over a minute.
This fixes borers being permanently mid-ability after first awakening
their host's psionic powers, and thus unable to do anything else for the
remainder of the round.
I also found an issue with the psi ability mirror shade: somehow the
shades target internal borers, including the hosts. I'd like a more
generic fix for this so that they don't attack any internal borers, but
I'm not well versed in mob code.
Also removed an `add_verb` for `write_ambition` that I should've removed
in my last borer-based PR, as it's done above inside a client check, and
could cause RTEs in some circumstances.
A collection of colourable boots added to the loadout:
+boot selection (colourable) / shoe tab
+toeless boot selection (colourable) / xenowear tab
+thigh-high sneakers / shoe selection (colourable)
All onmob sprites by me
Most item sprites borrowed and altered from existing sprites
---------
Signed-off-by: BulletBudgie <52014471+BulletBudgie@users.noreply.github.com>
Adds a new vending machine, along with a modified sprite and a refill
canister for it.
Removes the boba from the dinnerware vendor due to it not making sense.
Adjusts descriptions of some energy weapons to scrub Heph and replace
with NanoTrasen
Due to effecting corporate lore, I'll be passing this by the loremaster.
The removed `qdel` seemed extraneous from what I could gather. There may
be a niche instance that the `qdel` caught, but from what I read of the
code and testing it, the `qdel`s in `activate()` and `small_countdown()`
are sufficient. I could have put it behind an if statement, and still
could, but it looked messy and seemed unnecessary.
I have some small gripe with `DROPLIMB_BLUNT` somehow not causing injury
or a bleeding wound. If someone gets their hand hit so hard with a
baseball bat that they no longer have their hand, I doubt it would be
bloodless. I struggle to think of a scenario where the loss of a limb
does not involve heavy bleeding.
Anyway, I settled for changing it to a `DROPLIMB_EDGE.` I was
considering adding an instant bloodloss (5-10% depending on which limb
was exploded), but that felt a bit much.
Additionally, I would like to make the change from `_BLUNT` to `_EDGE`
for [Greimorian egg-bursting limb
loss](5e69bf50bc/code/game/objects/effects/spiders.dm (L322)),
but I worried it would muddle this PR too much.
Below image shows what a health analyzer scan prints with the new
`_EDGE` limb loss. When `_BLUNT` there is simply no wound, bleeding, or
pain.
Implements a disarm technique to Kis-Khan that "knocks out" simple
animals for a few seconds, allowing you to follow up with other attacks.
This is because shriekers are easy to encounter in the Untouched Lands
as a Kis-Khan master and are too difficult to get away from with Unathi
sprint, making it easy to get overwhelmed by multiple of them,
especially if you're in water. And dying to shriekers is, unfortunately,
not badass as a martial arts master.
Could also pave the way for other simple animal-based attacks for
Kis-Khan or other martial arts, if people are interested in that.
* Fixed AI hologram loadout characters being nude.
This fix worked on my local, but I'm not so sure about live, so I'm
requesting a test merge on this one.
Cyborg mining module now has hailing channel
Cyborg Jetpack Module now requires silver instead of Phoron
Co-authored-by: Ben10083 <Ben10083@users.noreply.github.com>
Skrell are not the best species in physical roles like Paramedic or
Officer for a number of reasons; this is a minor change that I think
will help with that without suddenly making them stronger in combat or
quicker (two of their weaknesses - they are slow (especially Axiori,)
IIRC have bad grab mods, and such.)
The real inspiration behind this was a Discord post that made me think
it'd be funny if they leapt like frogs.
This isn't technically a bugfix as the original PR (#19624) intended for
this behaviour
However, after a discussion in the code channel on the discord, I think
there's near-unanimous agreement that this feature isn't wanted.
Refactored hitby to be in line with TG's version.
Refactored item weight defines to a more clear naming scheme, also in
line with TG's version.
Refactored how the movement bumps are handled, ported signals to handle
them, in preparation for the movement update.
Fixed disposal hit bouncing the hitting atom on the wall.
Items do not push other items anymore if they are tiny.
Unfortunately most of the map is kind of unplayable or not mapped in
mind with stairs being untraversable for roller beds or wheelchairs.
Remapping every map to work with this mechanic is also not something I
am interested in.
---------
Co-authored-by: Matt Atlas <liermattia@gmail.com>
Creates a framework to restrict certain alt titles to certain factions.
As an example and natural logical consequence:
"Corporate Reporter" can only be used by Corporate employees
"Freelance Journalist" can only be used by Independent crew
I plan to use this system in a later PR.
---------
Signed-off-by: FlamingLily <80451102+FlamingLily@users.noreply.github.com>
Diona nymphs can now run correctly, without a weird empty stamina bar,
and stopping as appropriate when their stamina (health) is low, with a
message.
Fixes#14038
tl;dr: instead of just checking if the computer/camera are on map
defined "contact" zlevels (1,2,3 for horizon), computers save the zlevel
they were initialized on, and check for that (check connected zlevels)
so a offship camera works on offship zlevel, but not when brought
outside of it like on a shuttle, and only connects to cameras that are
on that offship zlevel, and same thing, not if flown outside on a
shuttle
this affects only the computer cameras - horizon generally uses camera
program on modular computers (but it works correctly on horizon too)
Co-authored-by: DreamySkrell <>
Seed code DMdoc'ed and code added to allow for custom descriptions and
extended descriptions for produce.
Adhomai plants given descriptions as proof of concept (maybe)
- [x] Foundation code
- [x] Assassinate Almrah Harrlala
- [x] Adhomai Plants descriptions
---------
Co-authored-by: Ben10083 <Ben10083@users.noreply.github.com>
When I made the recent alcohol toxicity changes to Unathi, I made
ethanol much more toxic to Unathi, because previously it wasn't very
damaging to them unless they drank a lot.
However, when I buffed the toxicity, I forgot to take into account
ethanol scrubber gas. I have discovered, quite rudely, that ethanol
scrubber explosions cause Unathi to instantly go into full 100% organ
damage on every organ, and collapse and die in 60 seconds even with
immediate medical attention. Their organs just all go critical
simultaneously.
This changes things back to the way they were. Unathi and Vaurca will
still vomit up alcohol, but will only take 3 toxin damage per unit of
ethanol instead of 12, which, in hindsight, was quite ridiculous.
https://github.com/Aurorastation/Aurora.3/assets/59633984/76c7c7a4-fa06-457c-bf8c-0a9bda733f49
Basically, uses the species' list of skin color presets, if any, to add
a button for body markings to select the same presets. This is only
really useful for Dionae at the moment, or at least I imagine so. Skin
tones and hairstyles were also removed from Dionae, as figuring out how
to add selectable tone for body markings was too much of a hassle and
adding presets for hairstyles as well seemed redundant. I was thinking
of adding a "random body markings" proc to resolve the issue of newly
formed gestalts not spawning with any hair, but let me know if this is
desired.
I discussed this with the Diona lore maintainer beforehand, but the team
is free to change their mind or request more features at any time.
Fixed a runtime with crates animation when closing.
Updated closets door animation code, renamed one var to be more clear,
some minor DMDoc, moved some procs around.
Reverts accessory weight handling, ontop of being exploitable as easily
as attaching the accessories after the clothe is in the bag, it doesn't
make sense that you can store the pieces singularly but not once put
together (for the modular armor, that is), and is ultimately just an
hassle to have to disassemble and reassemble it over and over every time
you have to pull the armor in the backpack and back out
This reduces the explosion radius of standstills. Currently, standstill
landmines blow a hole in the ship so large that it can take engineering
an extremely long time to fix it, even with full staffing. If a
standstill goes off inside service, for instance, nobody is using
service for a very large portion of the round, if ever - between the
venting, the broken floors, walling, windows, furniture, and machines. I
think it'd benefit as a tool without its users having to worry about the
insane blast radius disrupting more than they intended.
This reduces the heavy and light impact ranges, so they'll do less
structural damage, but maintains their devastation range - so, if you're
caught at the epicentre of the blast, you should still be about as
immediately critical as before. Lethality shouldn't be strongly
influenced, just structural damage. The blast radius is still large
enough that, in my testing, it's impossible to fully escape the blast.
Current blast radius:
PR blast radius:
The 'infest_with_parasite' proc was setting the 'parent_organ' variable
of new tumors to the src organ reference. Changed to set the
'parent_organ' variable to the 'limb_name' of the src which allows
surgery code to find it.
