mirror of
https://github.com/Aurorastation/Aurora.3.git
synced 2026-07-18 19:39:42 +01:00
Batrachophreno
0851144182
**Goals:** 1. Delete area definitions no longer used in any map or file. 2. Update area definitions such that everything used in mapping the Horizon exists in 'maps\sccv_horizon\areas' with the parent 'area\horizon\'. 3. Reorganize/rename/restructure those Horizon area definitions to make future mapping easier and code that hooks into area properties easier. 4. Present area names and blurbs in the status panel. This PR only handles Horizon and Runtime areas, for digestibility/ease of reviewing. Offsite areas for another PR. Naming convention reference: The /area/ 'name' variable no longer contains either 'Horizon' or the Deck# of the area or its approx location on the ship. All Horizon areas now have several new variables as metadata-- area names now need only be strictly descriptive, and the appropriate constants used in the area definition, and a new function generates the display name with consistent formatting for us. Detailed documentation to follow after any adjustments are made to mappers' preferences. This also adds area blurbs to most areas- if not bespoke, then general department-wide blurbs to parents. I know feature creep always sucks, but while some areas having pre-existing blurbs, the overwhelming majority of areas don't, and while testing it was very distracting to see them randomly appearing and disappearing. Most blurbs are pretty basic but I feel are entirely presentable- more clever individual ones can follow in a separate PR.
343 lines
9.8 KiB
Plaintext
343 lines
9.8 KiB
Plaintext
/*
|
|
*
|
|
* Zas Unit Tests.
|
|
* Shuttle Pressurized.
|
|
*
|
|
*
|
|
*/
|
|
|
|
#define UT_NORMAL 1 // Standard one atmosphere 20celsius
|
|
#define UT_VACUUM 2 // Vacume on simulated turfs
|
|
#define UT_NORMAL_COLD 3 // Cold but standard atmosphere.
|
|
#define UT_NORMAL_COOL 4 // Cool (5C) but standard atmosphere.
|
|
|
|
#define FAILURE 0
|
|
#define SUCCESS 1
|
|
|
|
#if defined(UNIT_TEST)
|
|
/**
|
|
* A list of string-keyes lists that maps the type of what we put there to the turfs
|
|
*
|
|
* Keys are strings of typepaths, values are lists of turfs
|
|
*
|
|
* list("/datum/map_template/whatever" = list(/turf/simulated, /turf/simulated))
|
|
*/
|
|
GLOBAL_LIST_EMPTY(turfs_to_map_type)
|
|
#endif
|
|
|
|
//
|
|
// Generic check for an area.
|
|
//
|
|
|
|
/datum/unit_test/zas_area_test
|
|
name = "ZAS: Area Test Template"
|
|
groups = list("map")
|
|
|
|
var/area_path = null // Put the area you are testing here.
|
|
var/expectation = UT_NORMAL // See defines above.
|
|
|
|
/datum/unit_test/zas_area_test/start_test()
|
|
var/list/test = test_air_in_area(area_path, expectation)
|
|
|
|
if(isnull(test))
|
|
TEST_FAIL("Check Runtimed")
|
|
|
|
if(test["result"] == SUCCESS)
|
|
TEST_PASS(test["msg"])
|
|
else
|
|
TEST_FAIL(test["msg"])
|
|
return 1
|
|
|
|
// ==================================================================================================
|
|
|
|
//
|
|
// The primary helper proc.
|
|
//
|
|
/proc/test_air_in_area(var/test_area, var/expectation = UT_NORMAL)
|
|
var/test_result = list("result" = FAILURE, "msg" = "")
|
|
|
|
var/area/A = locate(test_area)
|
|
|
|
if(!istype(A, test_area))
|
|
test_result["msg"] = "Unable to get [test_area]"
|
|
return test_result
|
|
|
|
var/list/GM_checked = list()
|
|
|
|
for(var/turf/simulated/T in A)
|
|
|
|
if(!istype(T) || isnull(T.zone) || istype(T, /turf/simulated/floor/airless))
|
|
continue
|
|
if(T.zone.air in GM_checked)
|
|
continue
|
|
|
|
var/t_msg = "Turf: [T] | Location: [T.x] // [T.y] // [T.z]"
|
|
|
|
var/datum/gas_mixture/GM = T.return_air()
|
|
var/pressure = GM.return_pressure()
|
|
var/temp = GM.temperature
|
|
|
|
|
|
if(expectation == UT_VACUUM)
|
|
if(pressure > 10)
|
|
test_result["msg"] = "Pressure out of bounds: [pressure]Pa at [temp]K | [t_msg] | expectation: VACUUM"
|
|
return test_result
|
|
|
|
|
|
if(expectation == UT_NORMAL || expectation == UT_NORMAL_COLD || expectation == UT_NORMAL_COOL)
|
|
if(abs(pressure - ONE_ATMOSPHERE) > 10)
|
|
test_result["msg"] = "Pressure out of bounds: [pressure]Pa | [t_msg]"
|
|
return test_result
|
|
|
|
if(expectation == UT_NORMAL)
|
|
if(abs(temp - T20C) > 10)
|
|
test_result["msg"] = "Temperature out of bounds: [temp]K at [pressure]Pa | [t_msg] | expectation: NORMAL"
|
|
return test_result
|
|
|
|
if(expectation == UT_NORMAL_COLD)
|
|
if(temp > 120)
|
|
test_result["msg"] = "Temperature out of bounds: [temp]K at [pressure]Pa | [t_msg] | expectation: NORMAL_COLD"
|
|
return test_result
|
|
|
|
if(expectation == UT_NORMAL_COOL)
|
|
if(temp > 283)
|
|
test_result["msg"] = "Temperature out of bounds: [temp]K at [pressure]Pa | [t_msg] | expectation: NORMAL_COOL"
|
|
return test_result
|
|
|
|
GM_checked.Add(GM)
|
|
|
|
if(GM_checked.len)
|
|
test_result["result"] = SUCCESS
|
|
test_result["msg"] = "Checked [GM_checked.len] zones"
|
|
else
|
|
test_result["msg"] = "No zones checked."
|
|
|
|
return test_result
|
|
|
|
|
|
// ==================================================================================================
|
|
|
|
/datum/unit_test/zas_area_test/supply_centcomm
|
|
name = "ZAS: Supply Shuttle (CentComm)"
|
|
area_path = /area/supply/dock
|
|
|
|
/datum/unit_test/zas_area_test/ai_chamber
|
|
name = "ZAS: AI Chamber"
|
|
area_path = /area/horizon/ai/chamber
|
|
expectation = UT_NORMAL_COOL
|
|
|
|
/datum/unit_test/zas_area_test/xenobio
|
|
name = "ZAS: Xenobiology"
|
|
area_path = /area/horizon/rnd/xenobiology
|
|
|
|
/*
|
|
/datum/unit_test/zas_area_test/mining_area
|
|
name = "ZAS: Mining Area (Vacuum)"
|
|
area_path = /area/mine/explored
|
|
expectation = UT_VACUUM
|
|
disabled = 1
|
|
why_disabled = "Asteroid Generation disabled"
|
|
*/
|
|
|
|
// ==================================================================================================
|
|
|
|
|
|
// Here we move a shuttle then test it's area once the shuttle has arrived.
|
|
|
|
/datum/unit_test/zas_supply_shuttle_moved
|
|
name = "ZAS: Supply Shuttle (When Moved)"
|
|
groups = list("map")
|
|
|
|
async = TRUE // We're moving the shuttle using built in procs.
|
|
|
|
var/datum/shuttle/autodock/ferry/supply/shuttle = null
|
|
|
|
var/testtime = 0 //Used as a timer.
|
|
|
|
/datum/unit_test/zas_supply_shuttle_moved/start_test()
|
|
if(!SSshuttle)
|
|
TEST_FAIL("The shuttle controller is not setup at time of test.")
|
|
return 1
|
|
if(!SSshuttle.shuttles.len)
|
|
if(length(SSatlas.current_map.map_shuttles))
|
|
TEST_FAIL("This map should have shuttles, but it doesn't!")
|
|
return 1
|
|
else
|
|
TEST_PASS("This map is not supposed to have any shuttles.")
|
|
return 1
|
|
|
|
shuttle = SScargo.shuttle
|
|
if(isnull(shuttle))
|
|
return 1
|
|
|
|
// Initiate the Move.
|
|
SScargo.movetime = 5 // Speed up the shuttle movement.
|
|
shuttle.short_jump(shuttle.get_location_waypoint(!shuttle.location))
|
|
|
|
return 1
|
|
|
|
/datum/unit_test/zas_supply_shuttle_moved/check_result()
|
|
if(!shuttle)
|
|
TEST_PASS("This map has no supply shuttle.")
|
|
return 1
|
|
if(shuttle.moving_status == SHUTTLE_IDLE && !shuttle.at_station())
|
|
TEST_FAIL("Shuttle Did not Move")
|
|
return 1
|
|
|
|
if(!shuttle.at_station())
|
|
return 0
|
|
|
|
if(!testtime)
|
|
testtime = world.time+40 // Wait another 2 ticks then proceed.
|
|
|
|
if(world.time < testtime)
|
|
return 0
|
|
|
|
|
|
for(var/area/A in shuttle.shuttle_area)
|
|
var/list/test = test_air_in_area(A.type)
|
|
if(isnull(test))
|
|
TEST_FAIL("Check Runtimed")
|
|
return 1
|
|
|
|
switch(test["result"])
|
|
if(SUCCESS) TEST_PASS(test["msg"])
|
|
else TEST_FAIL(test["msg"])
|
|
return 1
|
|
|
|
/datum/unit_test/zas_active_edges
|
|
name = "ZAS: Roundstart Active Edges"
|
|
groups = list("map")
|
|
|
|
/datum/unit_test/zas_active_edges/start_test()
|
|
|
|
// Nothing went wrong (this time...)
|
|
if(!(SSair.active_edges.len))
|
|
TEST_PASS("No active ZAS edges at round-start.")
|
|
return UNIT_TEST_PASSED
|
|
|
|
|
|
/*
|
|
Something went wrong
|
|
compose a message and fail the test, let the poor soul try to figure out where the issue is, assuming it's not intermittent
|
|
*/
|
|
var/fail_message = "\n\n\n\n\n[SSair.active_edges.len] edges active at round-start!\n"
|
|
|
|
#if defined(UNIT_TEST)
|
|
var/list/affected_map_types = list()
|
|
#endif
|
|
|
|
for(var/connection_edge/E in SSair.active_edges)
|
|
|
|
//Unsimulated edge
|
|
if(istype(E, /connection_edge/unsimulated))
|
|
var/connection_edge/unsimulated/U = E
|
|
var/turf/T = U.B
|
|
var/zone/zas_zone = U.A
|
|
|
|
fail_message += "Unsimulated edge between [zas_zone] and [T]\n"
|
|
|
|
if(istype(T))
|
|
fail_message += "--> [zas_zone.name] and [T.name] ([T.x], [T.y], [T.z]) have mismatched gas mixtures! <--\n"
|
|
|
|
else
|
|
fail_message += "--> [zas_zone.name] and [T] have mismatched gas mixtures! <--\n"
|
|
|
|
//Let's see if we can get what turfs are on the edge connection
|
|
fail_message += "[zas_zone.name] edge turfs:\n"
|
|
for(var/connection_edge/edge in zas_zone.edges)
|
|
if(edge.sleeping)
|
|
continue
|
|
|
|
for(var/turf/edge_turf in edge.connecting_turfs)
|
|
fail_message += "[edge_turf.type] ([edge_turf.x], [edge_turf.y], [edge_turf.z])\t"
|
|
|
|
|
|
|
|
fail_message += "\n\nMismatching edge gasses: [(zas_zone.air) ? json_encode(zas_zone.air.gas) : "vacuum"] <-----> [(T.air) ? json_encode(T.air.gas) : "vacuum"]\n\n"
|
|
|
|
var/offending_turfs_text = "Problem turfs: \n"
|
|
for(var/turf/simulated/S in zas_zone.contents)
|
|
if(("oxygen" in S.initial_gas) || ("nitrogen" in S.initial_gas))
|
|
offending_turfs_text += "[S.type] ([S.x], [S.y], [S.z])\t"
|
|
|
|
#if defined(UNIT_TEST)
|
|
for(var/type in GLOB.turfs_to_map_type)
|
|
if(S in GLOB.turfs_to_map_type[type])
|
|
affected_map_types |= type
|
|
#endif
|
|
|
|
fail_message += "[offending_turfs_text]\n\n"
|
|
|
|
|
|
//Simulated edge (zone edge)
|
|
else
|
|
var/connection_edge/zone/Z = E
|
|
if(!istype(Z))
|
|
stack_trace("Somehow, an edge is neither an unsimulated edge nor a zone edge!")
|
|
return
|
|
|
|
var/zone/first_zone = Z.A
|
|
var/zone/second_zone = Z.B
|
|
|
|
fail_message += "Simulated edge between [first_zone.name] and [second_zone.name]\n"
|
|
|
|
|
|
//Let's see if we can get what turfs are on the edge connection
|
|
fail_message += "[first_zone.name] and [second_zone.name] edge turfs:\n"
|
|
for(var/connection_edge/edge in (first_zone.edges + second_zone.edges))
|
|
if(edge.sleeping)
|
|
continue
|
|
|
|
for(var/turf/edge_turf in edge.connecting_turfs)
|
|
fail_message += "[edge_turf.type] ([edge_turf.x], [edge_turf.y], [edge_turf.z])\t"
|
|
|
|
//A list of turfs that are related to the found issue
|
|
var/list/turf/problem_turfs = list()
|
|
|
|
|
|
fail_message += "\n\n--> [first_zone.name] and [second_zone.name] have mismatched gas mixtures! <--\n"
|
|
|
|
if(Z.A.air.gas.len && Z.B.air.gas.len)
|
|
fail_message += "--> Both zones have gas mixtures defined; either one is a normally vacuum zone exposed to a breach, or two differing gases are mixing at round-start. <--\n"
|
|
problem_turfs = first_zone.contents + second_zone.contents
|
|
else if(Z.A.air.gas.len)
|
|
problem_turfs = first_zone.contents
|
|
else if(Z.B.air.gas.len)
|
|
problem_turfs = second_zone.contents
|
|
|
|
if(!length(problem_turfs))
|
|
continue
|
|
|
|
fail_message += "Mismatching edge gasses: [(first_zone.air) ? json_encode(first_zone.air.gas) : "vacuum"] <-----> [(second_zone.air) ? json_encode(second_zone.air.gas) : "vacuum"]\n\n"
|
|
|
|
var/offending_turfs_text = "Problem turfs: "
|
|
for(var/turf/simulated/S in problem_turfs)
|
|
if(("oxygen" in S.initial_gas) || ("nitrogen" in S.initial_gas))
|
|
offending_turfs_text += "[S.type] ([S.x], [S.y], [S.z])\t"
|
|
|
|
#if defined(UNIT_TEST)
|
|
for(var/type in GLOB.turfs_to_map_type)
|
|
if(S in GLOB.turfs_to_map_type[type])
|
|
affected_map_types |= type
|
|
#endif
|
|
|
|
fail_message += "[offending_turfs_text]\n\n"
|
|
|
|
|
|
#if defined(UNIT_TEST)
|
|
if(length(affected_map_types))
|
|
TEST_FAIL("Affected map types: [english_list(affected_map_types)]")
|
|
#endif
|
|
|
|
|
|
TEST_FAIL("[fail_message]")
|
|
return UNIT_TEST_FAILED
|
|
|
|
#undef UT_NORMAL
|
|
#undef UT_VACUUM
|
|
#undef UT_NORMAL_COLD
|
|
#undef UT_NORMAL_COOL
|
|
#undef SUCCESS
|
|
#undef FAILURE
|