Files
Aurora.3/code/controllers/subsystems/plants.dm
VMSolidus 1423fcd04e Various Delta Time Fixes (#21871)
Organs were being given ~3 seconds of DT per ~2 seconds of real time,
because they were being hit by Process() TWICE, once during processing
for the "Set of all objects", and again during processing for the "Set
of all mobs". No species was hit harder than this but IPCs, who suffered
from having wildly inconsistent temperature mechanics that seemingly
never matched the expected numbers.

I have actually tested this PR to verify that it works. I even went the
extra mile to more extensively test IPC temperature mechanics to find a
separate bug unrelated to DTs that was causing suit coolers to just
straight up not work at all (space suit or otherwise) on a majority of
all IPC subspecies. I then tested the numbers in the PR for IPC cooling
to verify that things work as intended.

<img width="969" height="623" alt="image"
src="https://github.com/user-attachments/assets/01c3aca7-b436-4e52-86f7-aed847dcba5e"
/>

I also tweaked all the subsystems to have a small performance
improvement.

---------

Signed-off-by: VMSolidus <evilexecutive@gmail.com>
2026-02-27 01:28:20 +00:00

163 lines
5.0 KiB
Plaintext

SUBSYSTEM_DEF(plants)
name = "Seeds & Plants"
flags = 0 // Override parent's flags.
wait = 75
init_order = INIT_ORDER_SEEDS
priority = SS_PRIORITY_PLANTS
runlevels = RUNLEVELS_PLAYING
/// Stores generated fruit descs.
var/list/product_descs = list()
/// All seed data stored here.
var/list/seeds = list()
/// Gene obfuscation for delicious trial and error goodness.
var/list/gene_tag_masks = list()
/// Stores images of growth, fruits and seeds.
var/list/plant_icon_cache = list()
/// List of all harvested product sprites.
var/list/plant_sprites = list()
/// List of all growth sprites plus number of growth stages.
var/list/plant_product_sprites = list()
/// Stores list of masked genes rather than recreating it later
var/list/gene_masked_list = list()
/// Stores gene masked list as datums
var/list/plant_gene_datums = list()
var/list/processing = list()
var/list/current = list()
/datum/controller/subsystem/plants/stat_entry(msg)
msg = "P:[processing.len]"
return ..()
/datum/controller/subsystem/plants/Initialize(timeofday)
// Build the icon lists.
for(var/icostate in icon_states('icons/obj/hydroponics_growing.dmi'))
var/split = findtext(icostate,"-")
if(!split)
// invalid icon_state
continue
var/ikey = copytext(icostate,(split+1))
if(ikey == "dead")
// don't count dead icons
continue
ikey = text2num(ikey)
var/base = copytext(icostate,1,split)
if(!(plant_sprites[base]) || (plant_sprites[base]<ikey))
plant_sprites[base] = ikey
for(var/icostate in icon_states('icons/obj/hydroponics_products.dmi'))
var/split = findtext(icostate,"-")
if(split)
plant_product_sprites |= copytext(icostate,1,split)
// Populate the global seed datum list.
for(var/type in typesof(/datum/seed)-/datum/seed)
var/datum/seed/S = new type
seeds[S.name] = S
S.uid = "[seeds.len]"
S.roundstart = 1
//Might as well mask the gene types while we're at it.
var/list/gene_datums = GET_SINGLETON_TYPE_MAP(/singleton/plantgene)
var/list/used_masks = list()
var/list/plant_traits = ALL_GENES
while(plant_traits && plant_traits.len)
var/gene_tag = pick(plant_traits)
var/gene_mask = "[uppertext(num2hex(rand(0,255), 0))]"
while(gene_mask in used_masks)
gene_mask = "[uppertext(num2hex(rand(0,255), 0))]"
var/singleton/plantgene/G
for(var/D in gene_datums)
var/singleton/plantgene/P = gene_datums[D]
if(gene_tag == P.gene_tag)
G = P
gene_datums -=D
used_masks += gene_mask
plant_traits -= gene_tag
gene_tag_masks[gene_mask] = gene_tag
plant_gene_datums[gene_mask] = G
gene_masked_list += (list(list("tag" = gene_tag, "mask" = gene_mask)))
return SS_INIT_SUCCESS
/datum/controller/subsystem/plants/Recover()
if (istype(SSplants))
src.product_descs = SSplants.product_descs
src.seeds = SSplants.seeds
src.gene_tag_masks = SSplants.gene_tag_masks
src.plant_icon_cache = SSplants.plant_icon_cache
src.plant_sprites = SSplants.plant_sprites
src.plant_product_sprites = SSplants.plant_product_sprites
src.gene_masked_list = SSplants.gene_masked_list
src.plant_gene_datums = SSplants.plant_gene_datums
/datum/controller/subsystem/plants/fire(resumed = 0)
if (!resumed)
var/list/old = current // This should be empty, so might as well just reuse it.
current = processing
processing = old
var/list/queue = current
var/seconds_per_tick = wait * 0.1
while (queue.len)
var/obj/effect/plant/P = queue[queue.len]
queue.len--
if (!QDELETED(P))
P.process(seconds_per_tick)
if (MC_TICK_CHECK)
return
/datum/controller/subsystem/plants/proc/add_plant(obj/effect/plant/plant)
processing[plant] = TRUE
/datum/controller/subsystem/plants/proc/remove_plant(obj/effect/plant/plant)
processing -= plant
/// Proc for creating a random seed type.
/datum/controller/subsystem/plants/proc/create_random_seed(var/survive_on_station)
var/datum/seed/seed = new()
seed.randomize()
seed.uid = seeds.len + 1
seed.name = "[seed.uid]"
seeds[seed.name] = seed
if(survive_on_station)
if(seed.consume_gasses)
seed.consume_gasses[GAS_PHORON] = null
seed.consume_gasses[GAS_CO2] = null
if(seed.chems && !isnull(seed.chems[/singleton/reagent/acid/polyacid]))
seed.chems[/singleton/reagent/acid/polyacid] = null // Eating through the hull will make these plants completely inviable, albeit very dangerous.
seed.chems -= null // Setting to null does not actually remove the entry, which is weird.
SET_SEED_TRAIT(seed, TRAIT_IDEAL_HEAT, 293)
SET_SEED_TRAIT(seed, TRAIT_HEAT_TOLERANCE, 20)
SET_SEED_TRAIT(seed, TRAIT_IDEAL_LIGHT, 8)
SET_SEED_TRAIT(seed, TRAIT_LIGHT_TOLERANCE, 5)
SET_SEED_TRAIT(seed, TRAIT_LOWKPA_TOLERANCE, 25)
SET_SEED_TRAIT(seed, TRAIT_HIGHKPA_TOLERANCE, 200)
return seed
/// Debug for testing seed genes.
/client/proc/show_plant_genes()
set category = "Debug"
set name = "Show Plant Genes"
set desc = "Prints the round's plant gene masks."
if(!holder) return
if(!SSplants || !SSplants.gene_tag_masks)
to_chat(usr, "Gene masks not set.")
return
for(var/mask in SSplants.gene_tag_masks)
to_chat(usr, "[mask]: [SSplants.gene_tag_masks[mask]]")