mirror of
https://github.com/Aurorastation/Aurora.3.git
synced 2025-12-22 08:01:06 +00:00
f1f23e7006
So while I was doing completely different things, I remembered discussing, with Geeves, that our preferences toggles only save 16 bit flags. Despite BYOND now supporting 24 of them. Lo and behold, sanitization is at fault. So I fixed it. Added a define BITFIELDMAX to indicate the max length of a BYOND bitfield. Replaced all relevant uses of 65535 with it. (Need to do a sweep for 0xffff as well, actually.)
149 lines
6.4 KiB
Plaintext
149 lines
6.4 KiB
Plaintext
/datum/category_item/player_setup_item/player_global/settings
|
|
name = "Settings"
|
|
sort_order = 2
|
|
|
|
/datum/category_item/player_setup_item/player_global/settings/load_preferences(var/savefile/S)
|
|
S["lastchangelog"] >> pref.lastchangelog
|
|
S["default_slot"] >> pref.default_slot
|
|
S["toggles"] >> pref.toggles
|
|
S["asfx_togs"] >> pref.asfx_togs
|
|
S["motd_hash"] >> pref.motd_hash
|
|
S["memo_hash"] >> pref.memo_hash
|
|
S["parallax_speed"] >> pref.parallax_speed
|
|
S["toggles_secondary"] >> pref.toggles_secondary
|
|
|
|
/datum/category_item/player_setup_item/player_global/settings/save_preferences(var/savefile/S)
|
|
S["lastchangelog"] << pref.lastchangelog
|
|
S["default_slot"] << pref.default_slot
|
|
S["toggles"] << pref.toggles
|
|
S["asfx_togs"] << pref.asfx_togs
|
|
S["motd_hash"] << pref.motd_hash
|
|
S["memo_hash"] << pref.memo_hash
|
|
S["parallax_speed"] << pref.parallax_speed
|
|
S["toggles_secondary"] << pref.toggles_secondary
|
|
|
|
/datum/category_item/player_setup_item/player_global/settings/gather_load_query()
|
|
return list(
|
|
"ss13_player_preferences" = list(
|
|
"vars" = list(
|
|
"lastchangelog",
|
|
"current_character",
|
|
"toggles",
|
|
"asfx_togs",
|
|
"lastmotd" = "motd_hash",
|
|
"lastmemo" = "memo_hash",
|
|
"toggles_secondary",
|
|
"parallax_speed"
|
|
),
|
|
"args" = list("ckey")
|
|
)
|
|
)
|
|
|
|
/datum/category_item/player_setup_item/player_global/settings/gather_load_parameters()
|
|
return list("ckey" = PREF_CLIENT_CKEY)
|
|
|
|
/datum/category_item/player_setup_item/player_global/settings/gather_save_query()
|
|
return list(
|
|
"ss13_player_preferences" = list(
|
|
"lastchangelog",
|
|
"current_character",
|
|
"toggles",
|
|
"asfx_togs",
|
|
"lastmotd",
|
|
"lastmemo",
|
|
"ckey" = 1,
|
|
"toggles_secondary",
|
|
"parallax_speed"
|
|
)
|
|
)
|
|
|
|
/datum/category_item/player_setup_item/player_global/settings/gather_save_parameters()
|
|
return list(
|
|
"ckey" = PREF_CLIENT_CKEY,
|
|
"lastchangelog" = pref.lastchangelog,
|
|
"current_character" = pref.current_character,
|
|
"toggles" = pref.toggles,
|
|
"asfx_togs" = pref.asfx_togs,
|
|
"lastmotd" = pref.motd_hash,
|
|
"lastmemo" = pref.memo_hash,
|
|
"toggles_secondary" = pref.toggles_secondary,
|
|
"parallax_speed" = pref.parallax_speed
|
|
)
|
|
|
|
/datum/category_item/player_setup_item/player_global/settings/sanitize_preferences(var/sql_load = 0)
|
|
if (sql_load)
|
|
pref.current_character = text2num(pref.current_character)
|
|
pref.current_character = validate_current_character()
|
|
|
|
pref.lastchangelog = sanitize_text(pref.lastchangelog, initial(pref.lastchangelog))
|
|
pref.default_slot = sanitize_integer(text2num(pref.default_slot), 1, config.character_slots, initial(pref.default_slot))
|
|
pref.toggles = sanitize_integer(text2num(pref.toggles), 0, BITFIELDMAX, initial(pref.toggles))
|
|
pref.asfx_togs = sanitize_integer(text2num(pref.asfx_togs), 0, BITFIELDMAX, initial(pref.toggles))
|
|
pref.motd_hash = sanitize_text(pref.motd_hash, initial(pref.motd_hash))
|
|
pref.memo_hash = sanitize_text(pref.memo_hash, initial(pref.memo_hash))
|
|
pref.parallax_speed = sanitize_integer(text2num(pref.parallax_speed), 1, 10, initial(pref.parallax_speed))
|
|
pref.toggles_secondary = sanitize_integer(text2num(pref.toggles_secondary), 0, BITFIELDMAX, initial(pref.toggles_secondary))
|
|
|
|
/datum/category_item/player_setup_item/player_global/settings/content(mob/user)
|
|
var/list/dat = list(
|
|
"<b>Play admin midis:</b> <a href='?src=\ref[src];toggle=[SOUND_MIDI]'><b>[(pref.toggles & SOUND_MIDI) ? "Yes" : "No"]</b></a><br>",
|
|
"<b>Play lobby music:</b> <a href='?src=\ref[src];toggle=[SOUND_LOBBY]'><b>[(pref.toggles & SOUND_LOBBY) ? "Yes" : "No"]</b></a><br>",
|
|
"<b>Ghost ears:</b> <a href='?src=\ref[src];toggle=[CHAT_GHOSTEARS]'><b>[(pref.toggles & CHAT_GHOSTEARS) ? "All Speech" : "Nearest Creatures"]</b></a><br>",
|
|
"<b>Ghost sight:</b> <a href='?src=\ref[src];toggle=[CHAT_GHOSTSIGHT]'><b>[(pref.toggles & CHAT_GHOSTSIGHT) ? "All Emotes" : "Nearest Creatures"]</b></a><br>",
|
|
"<b>Ghost radio:</b> <a href='?src=\ref[src];toggle=[CHAT_GHOSTRADIO]'><b>[(pref.toggles & CHAT_GHOSTRADIO) ? "All Chatter" : "Nearest Speakers"]</b></a><br>",
|
|
"<b>Space Parallax:</b> <a href='?src=\ref[src];paratoggle=[PARALLAX_SPACE]'><b>[(pref.toggles_secondary & PARALLAX_SPACE) ? "Yes" : "No"]</b></a><br>",
|
|
"<b>Space Dust:</b> <a href='?src=\ref[src];paratoggle=[PARALLAX_DUST]'><b>[(pref.toggles_secondary & PARALLAX_DUST) ? "Yes" : "No"]</b></a><br>",
|
|
"<b>Progress Bars:</b> <a href='?src=\ref[src];paratoggle=[PROGRESS_BARS]'><b>[(pref.toggles_secondary & PROGRESS_BARS) ? "Yes" : "No"]</b></a><br>",
|
|
"<b>Floating Messages:</b> <a href='?src=\ref[src];paratoggle=[FLOATING_MESSAGES]'><b>[(pref.toggles_secondary & FLOATING_MESSAGES) ? "Yes" : "No"]</b></a><br>",
|
|
"<b>Static Space:</b> <a href='?src=\ref[src];paratoggle=[PARALLAX_IS_STATIC]'><b>[(pref.toggles_secondary & PARALLAX_IS_STATIC) ? "Yes" : "No"]</b></a><br>"
|
|
)
|
|
|
|
. = dat.Join()
|
|
|
|
/datum/category_item/player_setup_item/player_global/settings/OnTopic(var/href,var/list/href_list, var/mob/user)
|
|
if(href_list["toggle"])
|
|
var/toggle_flag = text2num(href_list["toggle"])
|
|
pref.toggles ^= toggle_flag
|
|
if(toggle_flag == SOUND_LOBBY && isnewplayer(user))
|
|
if(pref.toggles & SOUND_LOBBY)
|
|
user << sound(SSticker.login_music, repeat = 0, wait = 0, volume = 85, channel = 1)
|
|
else
|
|
user << sound(null, repeat = 0, wait = 0, volume = 85, channel = 1)
|
|
return TOPIC_REFRESH
|
|
|
|
if(href_list["paratoggle"])
|
|
var/flag = text2num(href_list["paratoggle"])
|
|
pref.toggles_secondary ^= flag
|
|
return TOPIC_REFRESH
|
|
|
|
return ..()
|
|
|
|
/datum/category_item/player_setup_item/player_global/settings/proc/validate_current_character()
|
|
if (!establish_db_connection(dbcon))
|
|
return pref.current_character
|
|
|
|
var/DBQuery/is_ours = dbcon.NewQuery("SELECT COUNT(*) as valid_id FROM ss13_characters WHERE ckey = :ckey: AND id = :curr_char: AND deleted_at IS NULL")
|
|
is_ours.Execute(list("ckey" = pref.client.ckey, "curr_char" = pref.current_character))
|
|
|
|
if (!is_ours.NextRow())
|
|
return pref.current_character
|
|
|
|
var/found = text2num(is_ours.item[1])
|
|
|
|
if (!found)
|
|
return select_default_character()
|
|
else
|
|
return pref.current_character
|
|
|
|
/datum/category_item/player_setup_item/player_global/settings/proc/select_default_character()
|
|
if (!establish_db_connection(dbcon))
|
|
return 0
|
|
|
|
var/DBQuery/first_char = dbcon.NewQuery("SELECT id FROM ss13_characters WHERE ckey = :ckey: AND deleted_at IS NULL LIMIT 1")
|
|
first_char.Execute(list("ckey" = pref.client.ckey))
|
|
|
|
if (!first_char.NextRow())
|
|
return 0
|
|
|
|
return text2num(first_char.item[1])
|