mirror of
https://github.com/Aurorastation/Aurora.3.git
synced 2026-07-30 09:15:22 +01:00
sentry[bot]
32fbb7d965
* Please describe the intent of your changes in a clear fashion. This PR addresses SERVER-PROD-75, where the `set_turf_examine_tab` and `return_object_images` procs in the statpanels subsystem would crash due to attempting to access `client.obj_window.atoms_to_show` when `client.obj_window` was null. The root cause was a lifecycle desync: `client.obj_window` is primarily initialized within `/mob/set_listed_turf` and can be explicitly nulled by `/datum/object_window_info/Destroy()`. However, the statpanels subsystem would still attempt to update the turf examine tab if `mob.listed_turf` was set, even if `client.obj_window` had become null (e.g., after a mob transfer, relogin, or `obj_window` destruction without a subsequent `set_listed_turf` call). The fix involves lazy-initializing `client.obj_window` within both `set_turf_examine_tab` and `return_object_images`. This ensures that `client.obj_window` is always a valid `/datum/object_window_info` instance before its properties are accessed, preventing the null dereference crash. * Please make sure that, in the case of mapping changes, you include images of these changes in the PR's description. * Please make sure to mark your PR as wip or review required by making a comment with !wip or !review required * If you include sprites/sounds/... (assets) that you have not created yourself specify the license and original author below. * Ensure that you also credit them in the appropriate location / changelog as specified in the contributor guidelines ### Asset Licenses The following assets that **have not** been created by myself are included in this PR: | Path | Original Author | License | | --- | --- | --- | | icons/example.dmi | ExamplePerson (Example Station) | CC0 | Fixes SERVER-PROD-75 --------- Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com> Co-authored-by: VMSolidus <evilexecutive@gmail.com>