mirror of
https://github.com/Aurorastation/Aurora.3.git
synced 2026-07-27 07:46:54 +01:00
sentry[bot]
a1723313df
* Please describe the intent of your changes in a clear fashion. This PR addresses the "bad usr: proc name: get status tab items" error (SERVER-PROD-CK). The root cause was identified as the `statpanel(S.panel)` call within `/mob/proc/get_status_tab_items()` (code/modules/mob/mob.dm:1449). The `statpanel()` built-in implicitly relies on `usr` to determine which stat panel is active. However, `get_status_tab_items()` is frequently called by the `statpanels` subsystem's background update loop, where `usr` is `null`. To fix this, the `!statpanel(S.panel)` condition has been removed from the `if` statement. This eliminates the call to the `usr`-dependent built-in in a context where `usr` is null, resolving the runtime error. The `statpanel()` check was unnecessary as the web-based stat panel handles its own display logic, making this server-side filtering redundant. * Please make sure that, in the case of mapping changes, you include images of these changes in the PR's description. * Please make sure to mark your PR as wip or review required by making a comment with !wip or !review required * If you include sprites/sounds/... (assets) that you have not created yourself specify the license and original author below. * Ensure that you also credit them in the appropriate location / changelog as specified in the contributor guidelines ### Asset Licenses The following assets that **have not** been created by myself are included in this PR: | Path | Original Author | License | | --- | --- | --- | | icons/example.dmi | ExamplePerson (Example Station) | CC0 | Fixes SERVER-PROD-CK --------- Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com> Co-authored-by: VMSolidus <evilexecutive@gmail.com>