mirror of
https://github.com/Aurorastation/Aurora.3.git
synced 2026-08-19 02:50:08 +01:00
260f744906
This PR is a revisit to the previously derelict PR #20159 that has been unfinished for sometime now. More details about it in general can be found here: https://github.com/orgs/Aurorastation/projects/2?pane=issue&itemId=53167153 For awhile I've been talking about "Things I've been doing but it would be really nice to do them with a skills system", or "And here's how I would put this into the skills system when it's done". The main thing that was stopping me from building it myself was having poor real life skills in UI code and in DB code. However, I've gotten permission to resume this PR, which has already completed the steps I would not have been able to do myself. The rest of the PR fits well into my skillset as a dev. I'm opening this PR as a draft so as to enable my dev environment to locally track all the previously modified files. I'll take this PR out of draft and give this a full writeup when I have more work to show for the PR this weekend. ### TODO - [x] Rework a decent chunk of the currently existing skills to no longer require hardcoded inserts into other systems. EG, converting from classical ss13 methods, to modern /tg/-style ECS coding methods that work off of component-signal patterns. - [x] Make sure all of the existing skills have actual game functionality (I won't PR a 2016 Baystation12 situation where 90% of the skills are fluff only) - [x] Add the various skills not yet made but are necessary for completion sake, EG: Pilot (Spacecraft), Gunnery, Pilot (Walkers). - [x] Examine each existing job in the game and assess whether it should have a skill made with it in mind, or if it's covered by an existing skill. - [x] TO DISCUSS, BUT NOT ESSENTIAL: Additional skill proposals not currently in the pre-existing TODO list, proposing subcategories. - [x] Ensure that the previous TODO list is completed. ### Current Skills The current list of skills, checkmarked for if I've completed them/they have actual game mechanics. Or if we're just relegating them to separate PRs. Originally this list was going to be forced to visit for a bare minimum "does at least one thing" requirement, but now that is being forgone due to this PR ballooning out of control and in complexity, as well as development time overruns. - [x] Bartending - [x] Cooking - [x] Gardening - [x] Entertaining - [x] Electrical Engineering - [x] Mechanical Engineering - [x] Atmospherics Systems - [x] Reactor Systems - [x] Medicine - [x] Surgery - [x] Pharmacology - [x] Anatomy - [x] Forensics - [x] Robotics - [x] Pilot: Spacecraft - [x] Pilot: Exosuits - [x] Research - [x] Xenobotany - [x] Xenoarchaeology - [x] Xenobiology - [x] Unarmed Combat - [x] Armed Combat - [x] Firearms - [x] Leadership --------- Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: Matt Atlas <liermattia@gmail.com> Co-authored-by: FabianK3 <21039694+FabianK3@users.noreply.github.com> Co-authored-by: Matt Atlas <mattiathebest2000@hotmail.it>
33 lines
1.6 KiB
Plaintext
33 lines
1.6 KiB
Plaintext
SUBSYSTEM_DEF(skills)
|
|
name = "Skills"
|
|
flags = SS_NO_FIRE
|
|
|
|
/// This is essentially the list we use to read skills in the character setup.
|
|
var/list/skill_tree = list()
|
|
|
|
/// The set of all skills that are "forced" in order to guarantee necessary components are applied.
|
|
var/list/required_skills = list()
|
|
|
|
/datum/controller/subsystem/skills/Initialize()
|
|
// Initialize the skill category lists first.
|
|
// This creates linked lists as follows: "Science" -> empty list
|
|
for(var/singleton/skill_category/skill_category as anything in GET_SINGLETON_SUBTYPE_LIST(/singleton/skill_category))
|
|
skill_tree[skill_category] = list()
|
|
|
|
// Now, initialize all the skills.
|
|
// What actually goes on here: we want a tree that we can traverse programmatically.
|
|
// To do that, we first of all make empty lists above with all the categories (they're singletons so we can easily iterate over them).
|
|
// Next, we add the empty subcategory lists if they're not present. At this point, the tree would look like "Combat" -> "Melee" -> empty list
|
|
// After that's done, if our skill is not present, add it to the empty list of the subcategory.
|
|
for(var/singleton/skill/skill as anything in GET_SINGLETON_SUBTYPE_LIST(/singleton/skill))
|
|
if (skill.required)
|
|
required_skills += skill.type
|
|
var/singleton/skill_category/skill_category = GET_SINGLETON(skill.category)
|
|
if(!(skill.subcategory in skill_tree[skill_category]))
|
|
skill_tree[skill_category] |= skill.subcategory
|
|
skill_tree[skill_category][skill.subcategory] = list()
|
|
|
|
if(!(skill in skill_tree[skill_category][skill.subcategory]))
|
|
skill_tree[skill_category][skill.subcategory] |= skill
|
|
return SS_INIT_SUCCESS
|