mport2004@gmail.com 0d3be5d606 Reverting r4296. This is not a bug this is intentional you should really read the code and figure out exactly what it is doing before making changes, something I seem to be seeing quite a bit less of these days. ...

The FillHeadPosition proc makes sure there will almost always be at least one head by grabbing a list of everyone who has the job set to high, if no one has it set to high it will check the next job until it either gets at least one player or runs out of jobs.  If it has at least one player it picks a random player out of the list then terminates as we now have one head.  If we ran out of jobs we now check the jobs again using the medium setting.  If that does not work then we use low.
After this proc has been ran you likely have one head, if wanted it could easily force a head by checking the return however that was deemed unnecessary.  Next the code runs nearly the exact same code but for AI checking.  After that it proceeds with the standard job selection code, the rest of the heads are in here.

tl;dr It was working fine, you will end up with at least one head so long as a single player has a head set above never.  Using this for all heads overrides the entire point of having a low/med/high for heads and will cause low pop servers to have a very high head to crew ratio.  Also please read over and try to understand what code is doing and why before you start messing with it.





git-svn-id: http://tgstation13.googlecode.com/svn/trunk@4297 316c924e-a436-60f5-8080-3fe189b3f50e

2012-08-03 04:04:04 +00:00

..

area

-OPTIMIZATION TIME

2012-07-26 03:04:05 +00:00

asteroid

Updated space carp, walking mushrooms and killer tomatos to use simple_animal instead of critter code.

2012-07-31 21:22:42 +00:00

gamemodes

-Fixed floor tile inhands

2012-08-02 19:33:24 +00:00

jobs

Reverting r4296. This is not a bug this is intentional you should really read the code and figure out exactly what it is doing before making changes, something I seem to be seeing quite a bit less of these days.

2012-08-03 04:04:04 +00:00

machinery

-Mining will now have the proper frequencies.

2012-08-02 20:02:31 +00:00

magic

- Categorized invisibility stuff into #defines. If any errors appear - let me know.

2012-07-30 16:24:45 +00:00

mecha

-Borgs can now have 1 key installed into their radio, and can handle channels just like any other headset

2012-08-02 03:02:43 +00:00

objects

-Fixed issue 726, not the best fix but I could find no other solution.

2012-08-02 21:42:43 +00:00

vehicles

-Make holodeck eswords a child of obj/item/weapon/holo instead of regular eswords, clumsy check removed as a result, and you can no longer do things like cutting through walls or doors or what have you. (Fixes Issue 665)

2012-07-23 00:48:51 +00:00

verbs

-Redid admin_list to be based off clients rather than mobs (Why I did it with mobs first, I'll never know). This fixes AdminWho and Asay and such not working pre-game.

2012-07-31 02:02:30 +00:00

algorithm.dm

Created global lists for hair and facial_hair datums since they are referenced frequently. This means those datums are only ever created once. Also, the list is indexed by hairstyle name. This means means we only need to store one variable to find the hair datum. It also means admins can change h_style and f_style to the name of the hair and use the Regenerate Icons function in viewvars to update a human's hair icon. If an incorrect f_style or h_style is input it won't affect anything adversely (besides hair not showing for that mob).

2012-08-01 13:40:43 +00:00

atom_procs.dm

Forgot to add clean_prints back into clean_blood

2012-08-01 19:35:18 +00:00

cellautomata.dm

-Make holodeck eswords a child of obj/item/weapon/holo instead of regular eswords, clumsy check removed as a result, and you can no longer do things like cutting through walls or doors or what have you. (Fixes Issue 665)

2012-07-23 00:48:51 +00:00

chemistry.dm

-Make holodeck eswords a child of obj/item/weapon/holo instead of regular eswords, clumsy check removed as a result, and you can no longer do things like cutting through walls or doors or what have you. (Fixes Issue 665)

2012-07-23 00:48:51 +00:00

communications.dm

…

dna.dm

Created global lists for hair and facial_hair datums since they are referenced frequently. This means those datums are only ever created once. Also, the list is indexed by hairstyle name. This means means we only need to store one variable to find the hair datum. It also means admins can change h_style and f_style to the name of the hair and use the Regenerate Icons function in viewvars to update a human's hair icon. If an incorrect f_style or h_style is input it won't affect anything adversely (besides hair not showing for that mob).

2012-08-01 13:40:43 +00:00

hud.dm

- Added UI buttons which appear only when you have certain items on you to make toggling some stuff easier and lessen the need to juggle a million items all the time.

2012-07-27 15:20:44 +00:00

landmarks.dm

…

master_controller.dm

Welp, fix for me accidentally re-adding the MC failsafe, and a stat check for metroids, so now they won't process targets, their friend list, or any of that other shit when dead.

2012-07-28 16:36:22 +00:00

prisonshuttle.dm

-Make holodeck eswords a child of obj/item/weapon/holo instead of regular eswords, clumsy check removed as a result, and you can no longer do things like cutting through walls or doors or what have you. (Fixes Issue 665)

2012-07-23 00:48:51 +00:00

shuttle_engines.dm

-Make holodeck eswords a child of obj/item/weapon/holo instead of regular eswords, clumsy check removed as a result, and you can no longer do things like cutting through walls or doors or what have you. (Fixes Issue 665)

2012-07-23 00:48:51 +00:00

skincmd.dm

…

smoothwall.dm

-Make holodeck eswords a child of obj/item/weapon/holo instead of regular eswords, clumsy check removed as a result, and you can no longer do things like cutting through walls or doors or what have you. (Fixes Issue 665)

2012-07-23 00:48:51 +00:00

sound.dm

…

specops_shuttle.dm

-Make holodeck eswords a child of obj/item/weapon/holo instead of regular eswords, clumsy check removed as a result, and you can no longer do things like cutting through walls or doors or what have you. (Fixes Issue 665)

2012-07-23 00:48:51 +00:00

status.dm

-OPTIMIZATION TIME

2012-07-26 03:04:05 +00:00

step_triggers.dm

A fix for the step trigger to stop treating turfs like atom/movables. This should stop transit-related server crashes once and for all.

2012-07-16 19:23:34 +00:00

supplyshuttle.dm

-OPTIMIZATION TIME

2012-07-26 03:04:05 +00:00

syndicate_shuttle.dm

-Make holodeck eswords a child of obj/item/weapon/holo instead of regular eswords, clumsy check removed as a result, and you can no longer do things like cutting through walls or doors or what have you. (Fixes Issue 665)

2012-07-23 00:48:51 +00:00

syndicate_specops_shuttle.dm

-Make holodeck eswords a child of obj/item/weapon/holo instead of regular eswords, clumsy check removed as a result, and you can no longer do things like cutting through walls or doors or what have you. (Fixes Issue 665)

2012-07-23 00:48:51 +00:00

throwing.dm

ugh...this was horrible. I'm really sorry if I fucked anything up, I was literally going braindead towards the end.

2012-06-23 21:24:45 +00:00

topic.dm

Created global lists for hair and facial_hair datums since they are referenced frequently. This means those datums are only ever created once. Also, the list is indexed by hairstyle name. This means means we only need to store one variable to find the hair datum. It also means admins can change h_style and f_style to the name of the hair and use the Regenerate Icons function in viewvars to update a human's hair icon. If an incorrect f_style or h_style is input it won't affect anything adversely (besides hair not showing for that mob).

2012-08-01 13:40:43 +00:00

turf.dm

- Added MICE! Sprites by our insanely talented Cheridan :)

2012-07-29 07:14:59 +00:00

vote.dm

-OPTIMIZATION TIME

2012-07-26 03:04:05 +00:00