[MIRROR] Fixes NtosNet Downloader & App themes [MDB IGNORE] (#19433)

* Fixes NtosNet Downloader & App themes (#73500)

## About The Pull Request

NtOS' downloading app is the only application where PC device theme is
actually used by the app directly, instead of handled by NtOS Window. I
forgot about this, and removed it from the data, breaking the TGUI page.

Also two edits;
- NtosWindow now takes their theme directly from PC_device_theme, this
means we're not relying anymore on apps to individually give the theme
they want to have, and tablets will get alerts of downloading illegal
programs if they are on any theme but the syndicate one (instead of not
getting the message if theyre on any but the nt one).
- Removes bad uses of ``as anything`` on stored files, because it holds
more than just programs (like ordnance data).

## Why It's Good For The Game

the NtOS app now works again, sorry for the issue.

Closes https://github.com/tgstation/tgstation/issues/73493
Closes https://github.com/tgstation/tgstation/issues/73507

## Changelog

🆑
fix: NtOS program downloader now works again, and will now properly
alert you of downloading illegal ROMs if you change your theme to
anything that isn't Syndicate.
fix: NtOS themes are now recognized by all windows.
/🆑

* Fixes NtosNet Downloader & App themes

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
This commit is contained in:
SkyratBot
2023-02-19 07:17:52 +01:00
committed by GitHub
parent 94aa2f4bd6
commit 01584fbe92
6 changed files with 10 additions and 10 deletions

View File

@@ -50,7 +50,6 @@
/obj/item/modular_computer/ui_data(mob/user)
var/list/data = get_header_data()
data["device_theme"] = device_theme
data["login"] = list(
IDName = saved_identification || "Unknown",
@@ -71,7 +70,7 @@
data["removable_media"] += "intelliCard"
data["programs"] = list()
for(var/datum/computer_file/program/program as anything in stored_files)
for(var/datum/computer_file/program/program in stored_files)
data["programs"] += list(list(
"name" = program.filename,
"desc" = program.filedesc,

View File

@@ -175,7 +175,7 @@
/obj/item/modular_computer/pda/proc/get_detomatix_difficulty()
var/detomatix_difficulty
for(var/datum/computer_file/program/downloaded_apps as anything in stored_files)
for(var/datum/computer_file/program/downloaded_apps in stored_files)
detomatix_difficulty += downloaded_apps.detomatix_resistance
return detomatix_difficulty