From 015fe4e994a95c55ef54f0bc7034602dd465ac7a Mon Sep 17 00:00:00 2001 From: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Sun, 4 Jan 2026 06:54:02 +0100 Subject: [PATCH] Fish weight is now measured in "kiloclam" instead of grams (#94624) Alternative Title: Fish are no longer comically underweight from real-life unit of measurements. ## About the Pull Request Instead of mentioning grams, fish weight now uses a fictitious unit called ~~kilokrill~~ kiloclam. ## Why It's Good For The Game Realistically, weight increases exponentially with size, however, for the sake of keeping this niche part of the game """simple""", we/I have always avoided delving into it and stuck to length alone. Not that it's hard, if you've a high school diploma of any kind, you should be able to come with a more satisfying (albeit box-y) approximation of weight if you add a few more variables like height, width and density, but do we have to make fishing a bit more annoying to maintain because of it? Maybe we should just replace "gram" with some punny make-believe unit of mass instead. This closes #93794 ## Changelog :cl: spellcheck: fish weight is now measured in "kiloclam" instead of grams. Like, imagine being slown down by a big lake fish that only weighs "800 grams", bruh... /:cl: --- code/modules/autowiki/pages/fishing.dm | 2 +- code/modules/fishing/fish/_fish.dm | 6 +++--- tgui/packages/tgui/interfaces/FishAnalyzer.tsx | 4 ++-- tgui/packages/tgui/interfaces/FishCatalog.tsx | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/code/modules/autowiki/pages/fishing.dm b/code/modules/autowiki/pages/fishing.dm index 57ce95712fd..8dfd661cf15 100644 --- a/code/modules/autowiki/pages/fishing.dm +++ b/code/modules/autowiki/pages/fishing.dm @@ -50,7 +50,7 @@ "name" = full_capitalize(escape_value(fish::name)), "icon" = filename, "description" = description, - "size_weight" = "[fish::average_size]cm / [fish::average_weight]g", + "size_weight" = "[fish::average_size] cm / [fish::average_weight] kiloclam", "fluid" = escape_value(fish::required_fluid_type), "temperature" = "Doesn't matter", "stable_population" = fish::stable_population, diff --git a/code/modules/fishing/fish/_fish.dm b/code/modules/fishing/fish/_fish.dm index 4906f97ba30..4cbd21dc35f 100644 --- a/code/modules/fishing/fish/_fish.dm +++ b/code/modules/fishing/fish/_fish.dm @@ -138,9 +138,9 @@ GLOBAL_LIST_INIT(fish_compatible_fluid_types, list( /// The maximum size this fish can reach, calculated the first time update_size_and_weight() is called. var/maximum_size - /// Weight in grams. Null until update_size_and_weight is called. Grind results scale with it. Don't think too hard how a trout could fit in a blender. + /// Weight in "kiloclam". Null until update_size_and_weight is called. Grind results scale with it. Don't think too hard how a trout could fit in a blender. var/weight - /// Average weight for this fish type in grams + /// Average weight for this fish type in "kiloclam" var/average_weight = 1000 /// Temporarily stores the new weight of the fish from randomize_size_and_weight() to be used by update_size_weight() later, so that it can be deferred. var/temp_weight @@ -549,7 +549,7 @@ GLOBAL_LIST_INIT(fish_compatible_fluid_types, list( if(HAS_MIND_TRAIT(user, TRAIT_EXAMINE_FISH) || HAS_TRAIT(loc, TRAIT_EXAMINE_FISH)) . += span_notice("[p_theyre(TRUE)] [size] cm long.") - . += span_notice("[p_they(TRUE)] weighs [weight] g.") + . += span_notice("[p_they(TRUE)] weighs [weight] [span_tooltip("the standard unit of measurement for space age fish", "kiloclam")].") if(HAS_TRAIT(src, TRAIT_FISH_GENEGUNNED)) . += span_warning("[p_theyve(TRUE)] been edited by a fish genegun. [p_they(TRUE)]'ll die if edited again.") diff --git a/tgui/packages/tgui/interfaces/FishAnalyzer.tsx b/tgui/packages/tgui/interfaces/FishAnalyzer.tsx index ebd1957465b..76912135539 100644 --- a/tgui/packages/tgui/interfaces/FishAnalyzer.tsx +++ b/tgui/packages/tgui/interfaces/FishAnalyzer.tsx @@ -142,10 +142,10 @@ const FishItem = (props) => { /> - {fish.fish_weight}g + {fish.fish_weight} kiloclam - {fish.fish_size}cm + {fish.fish_size} cm diff --git a/tgui/packages/tgui/interfaces/FishCatalog.tsx b/tgui/packages/tgui/interfaces/FishCatalog.tsx index deb7d83d97d..24f437c40ae 100644 --- a/tgui/packages/tgui/interfaces/FishCatalog.tsx +++ b/tgui/packages/tgui/interfaces/FishCatalog.tsx @@ -92,7 +92,7 @@ export const FishCatalog = (props) => { {currentFish.size} cm - {currentFish.weight} g + {currentFish.weight} kiloclam {currentFish.beauty}