cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 05:00:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

fixes seed ruin logic preventing forced ruins from spawning when budget is zero, fixes map_logging CI test (#87910)

Browse Source 
## About The Pull Request

The ruins get added to forced_ruins, quite often after all ruin budget
is exhausted and thus they don't get spawned.

This adjusts the logic to ignore the budget when there's forced_ruins to
be had.

Also apparently fixes map_logging CI test which was broken by the logic,
and makes the stacked_lights test scream at you with the area name for
the sake of easier debugging as it can proc on the ruins now

## Why It's Good For The Game

Adjusts some logic to allow multi-ruins to spawn correctly, and to make
sure our mappers make good space ruins too

## Changelog

🆑
fix: Ruins will now correctly spawn their tied ruins in
fix: The map_logging test now runs proper
code: The stacked_lights test now screams with area names too.
/🆑
This commit is contained in:
Waterpig
2024-12-05 01:19:52 -08:00
committed by Majkl-J
parent 22bdc2db42
commit 016c3ed21a
8 changed files with 6 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/mapping/ruins.dm
+1 -1
View File
@@ -115,7 +115,7 @@
if(R.unpickable)
continue
ruins_available[R] = R.placement_weight
while((budget > 0 || mineral_budget > 0) && (ruins_available.len || forced_ruins.len))
while(((budget > 0 || mineral_budget > 0) && ruins_available.len) || forced_ruins.len)
var/datum/map_template/ruin/current_pick
var/forced = FALSE
var/forced_z //If set we won't pick z level and use this one instead.