mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-24 21:48:39 +01:00
Fixes character slots not updating (#96808)
## About The Pull Request Moves `"character_profiles"` out of `ui_static_data()`. We already have the `tainted_character_profiles` to prevent unnecessary updates, and this data is not static. <details><summary>Before, button doesn't update</summary> <img width="661" height="629" alt="061mR8KEUA" src="https://github.com/user-attachments/assets/4fc362f5-25e8-42a3-a0f0-4e17418506fd" /> </details> <details><summary>After</summary> <img width="679" height="639" alt="dreamseeker_vpIRPDgDKp" src="https://github.com/user-attachments/assets/42f5457c-f471-468b-a391-87a8762d44bd" /> </details> <details><summary>Deletion is functional and updates as well</summary> <img width="568" height="559" alt="obZYCZ5A1K" src="https://github.com/user-attachments/assets/a5a375fe-84ca-4b52-99fb-095c149a9c4c" /> </details> <details><summary>Quirks update when switching slots</summary> <img width="920" height="770" alt="mJJGxYTvPj" src="https://github.com/user-attachments/assets/6260a862-e59d-4fc7-9ff8-3140e7122283" /> </details> ## Why It's Good For The Game Fixes a bug/oversight ## Changelog 🆑 fix: in prefs menu, changing your character name will now update your slot button correctly fix: fixes an issue where switching slots would carry over the quirks of a previous slot until you add or remove a quirk /🆑
This commit is contained in:
@@ -96,6 +96,7 @@
|
||||
|
||||
/datum/preference_middleware/quirks/on_new_character(mob/user)
|
||||
tainted = TRUE
|
||||
preferences.update_static_data(user, always_instant = TRUE)
|
||||
|
||||
/datum/preference_middleware/quirks/proc/give_quirk(list/params, mob/user)
|
||||
var/quirk_name = params["quirk"]
|
||||
|
||||
Reference in New Issue
Block a user