From 04552deb5ca3cb2e424eac1fa669505dff8f6bc4 Mon Sep 17 00:00:00 2001 From: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Fri, 17 Dec 2021 03:57:48 -0800 Subject: [PATCH] Fix missing SIGNAL_HANDLERs (#63404) More missing signal handlers caught by dm-lua --- code/modules/mob/living/carbon/carbon.dm | 1 - .../living/simple_animal/hostile/mining_mobs/elites/elite.dm | 2 ++ code/modules/wiremod/components/atom/hear.dm | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/code/modules/mob/living/carbon/carbon.dm b/code/modules/mob/living/carbon/carbon.dm index 583af9f8fc4..3e708903db8 100644 --- a/code/modules/mob/living/carbon/carbon.dm +++ b/code/modules/mob/living/carbon/carbon.dm @@ -8,7 +8,6 @@ ADD_TRAIT(src, TRAIT_AGEUSIA, NO_TONGUE_TRAIT) GLOB.carbon_list += src - RegisterSignal(src, COMSIG_LIVING_DEATH, .proc/attach_rot) var/static/list/loc_connections = list( COMSIG_CARBON_DISARM_PRESHOVE = .proc/disarm_precollide, COMSIG_CARBON_DISARM_COLLIDE = .proc/disarm_collision, diff --git a/code/modules/mob/living/simple_animal/hostile/mining_mobs/elites/elite.dm b/code/modules/mob/living/simple_animal/hostile/mining_mobs/elites/elite.dm index 580cb98e2d9..96f6e586a20 100644 --- a/code/modules/mob/living/simple_animal/hostile/mining_mobs/elites/elite.dm +++ b/code/modules/mob/living/simple_animal/hostile/mining_mobs/elites/elite.dm @@ -191,6 +191,7 @@ While using this makes the system rely on OnFire, it still gives options for tim INVOKE_ASYNC(src, .proc/arena_checks) /obj/structure/elite_tumor/proc/mychild_gone_missing() + SIGNAL_HANDLER mychild = null /obj/structure/elite_tumor/proc/return_elite() @@ -222,6 +223,7 @@ While using this makes the system rely on OnFire, it still gives options for tim RegisterSignal(user, COMSIG_PARENT_QDELETING, .proc/clear_activator) /obj/structure/elite_tumor/proc/clear_activator(mob/source) + SIGNAL_HANDLER if(!activator) return activator = null diff --git a/code/modules/wiremod/components/atom/hear.dm b/code/modules/wiremod/components/atom/hear.dm index 1c6c0f3eb1a..af660d2d67c 100644 --- a/code/modules/wiremod/components/atom/hear.dm +++ b/code/modules/wiremod/components/atom/hear.dm @@ -36,6 +36,7 @@ REMOVE_TRAIT(shell, TRAIT_HEARING_SENSITIVE, CIRCUIT_HEAR_TRAIT) /obj/item/circuit_component/hear/proc/on_shell_hear(datum/source, list/arguments) + SIGNAL_HANDLER return Hear(arglist(arguments)) /obj/item/circuit_component/hear/Hear(message, atom/movable/speaker, datum/language/message_language, raw_message, radio_freq, list/spans, list/message_mods)