cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-26 14:39:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Reset Thunderdome Respects Closing The Alert (bonus qol) (#72028)

Browse Source 
Similar vein to #70449.

## About The Pull Request

I was training an admin yesterday, and they accidentally reset the
thunderdome when they tried to cancel out of it by closing out of it
since they didn't hit the "cancel" button, but rather the big red X.
That's silly, let's have this respect that potential user entry.

Also, the log_admin call here had an excessive number of arguments?
Probably cruft that never got cleaned up, I just patched it up while I
was in the area. I also changed the name of the title to not be so
vague.
## Why It's Good For The Game

Better UX is always a good thing. It's silly to have this happen more
than once.
## Changelog
🆑
admin: The "Reset Thunderdome" option in the Secrets Menu now respects
you closing out of the confirmation screen as a way of cancelling your
potential thunderdome reset, rather than proceeding immediately. It
should also be easier to comprehend as well.
/🆑
This commit is contained in:
san7890
2022-12-19 16:58:04 -08:00
committed by GitHub
parent a91472045d
commit 0483fe820d
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/admin/verbs/secrets.dm
+5 -4
View File
@@ -126,12 +126,12 @@ GLOBAL_DATUM(everyone_a_traitor, /datum/everyone_is_a_traitor_controller)
toggle_id_ctf(holder, "centcom")
if("tdomereset")
var/delete_mobs = tgui_alert(usr,"Clear all mobs?","Confirm",list("Yes","No","Cancel"))
if(delete_mobs == "Cancel")
var/delete_mobs = tgui_alert(usr, "Clear all mobs?", "Thunderdome Reset", list("Yes", "No", "Cancel"))
if(!delete_mobs || delete_mobs == "Cancel")
return
log_admin("[key_name(holder)] reset the thunderdome to default with delete_mobs==[delete_mobs].", 1)
message_admins(span_adminnotice("[key_name_admin(holder)] reset the thunderdome to default with delete_mobs==[delete_mobs]."))
log_admin("[key_name(holder)] reset the thunderdome to default with delete_mobs marked as [delete_mobs].")
message_admins(span_adminnotice("[key_name_admin(holder)] reset the thunderdome to default with delete_mobs marked as [delete_mobs]."))
var/area/thunderdome = GLOB.areas_by_type[/area/centcom/tdome/arena]
if(delete_mobs == "Yes")
@@ -144,6 +144,7 @@ GLOBAL_DATUM(everyone_a_traitor, /datum/everyone_is_a_traitor_controller)
var/datum/map_template/thunderdome_template = SSmapping.map_templates[THUNDERDOME_TEMPLATE_FILE]
var/turf/thunderdome_corner = locate(thunderdome.x - 3, thunderdome.y - 1, 1) // have to do a little bit of coord manipulation to get it in the right spot
thunderdome_template.load(thunderdome_corner)
if("set_name")
var/new_name = input(holder, "Please input a new name for the station.", "What?", "") as text|null
if(!new_name)