From 04c1d233d0e6965950cdafdc5b9eaaa5929dc9fe Mon Sep 17 00:00:00 2001 From: Lucy Date: Tue, 15 Apr 2025 05:19:07 -0400 Subject: [PATCH] Disable screentip images for clients on BYOND 516.1657+ (#90613) --- code/__DEFINES/client.dm | 6 ++++++ code/game/atom/_atom.dm | 3 +++ 2 files changed, 9 insertions(+) diff --git a/code/__DEFINES/client.dm b/code/__DEFINES/client.dm index 17571b5270b..fc70fa9dbca 100644 --- a/code/__DEFINES/client.dm +++ b/code/__DEFINES/client.dm @@ -4,3 +4,9 @@ /// Checks to see if a /client has fully gone through New() as a safeguard against certain operations. /// Should return the boolean value of the fully_created var, which should be TRUE if New() has finished running. FALSE otherwise. #define VALIDATE_CLIENT_INITIALIZATION(target) (target.fully_created) + +/// The minimum client BYOND build to disable screentip icons for. +#define MIN_BYOND_BUILD_DISABLE_SCREENTIP_ICONS 1657 +/// The maximum client BYOND build to disable screentip icons for. +/// Update this whenever https://www.byond.com/forum/post/2967731 is fixed. +#define MAX_BYOND_BUILD_DISABLE_SCREENTIP_ICONS 1699 diff --git a/code/game/atom/_atom.dm b/code/game/atom/_atom.dm index 06728752c2a..b39db347f69 100644 --- a/code/game/atom/_atom.dm +++ b/code/game/atom/_atom.dm @@ -896,6 +896,9 @@ if (contextual_screentip_returns & CONTEXTUAL_SCREENTIP_SET) var/screentip_images = active_hud.screentip_images + // Disable screentip images for clients affected by https://www.byond.com/forum/post/2967731 + if(ISINRANGE(client?.byond_build, MIN_BYOND_BUILD_DISABLE_SCREENTIP_ICONS, MAX_BYOND_BUILD_DISABLE_SCREENTIP_ICONS)) + screentip_images = FALSE // LMB and RMB on one line... var/lmb_text = build_context(context, SCREENTIP_CONTEXT_LMB, screentip_images) var/rmb_text = build_context(context, SCREENTIP_CONTEXT_RMB, screentip_images)