cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-19 20:15:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

flame_range and flash_range autoset fix (#77118)

Browse Source 
## About The Pull Request
From #27184 flame_range and flash_range should automatically default to
light_impact_range and devastation_range

https://github.com/tgstation/tgstation/blob/4abf35e4a7fba8bcee5633f0fefe438baba2f046/code/controllers/subsystem/explosions.dm#L285-L288

But it was broken, probably after moving to subsystem, because now
functions set arguments to 0.

Please note I don't play tg and haven't tested this change. Fix changes
default behavior and may cause unwanted effects.
This commit is contained in:
Alexander V
2023-07-27 21:27:04 +03:00
committed by GitHub
parent efbee95214
commit 076bc3eb42
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/controllers/subsystem/explosions.dm
+2 -2
View File
@@ -199,7 +199,7 @@ SUBSYSTEM_DEF(explosions)
* - smoke: Whether to generate a smoke cloud provided the explosion is powerful enough to warrant it.
* - explosion_cause: [Optional] The atom that caused the explosion, when different to the origin. Used for logging.
*/
/proc/explosion(atom/origin, devastation_range = 0, heavy_impact_range = 0, light_impact_range = 0, flame_range = 0, flash_range = 0, adminlog = TRUE, ignorecap = FALSE, silent = FALSE, smoke = FALSE, atom/explosion_cause = null)
/proc/explosion(atom/origin, devastation_range = 0, heavy_impact_range = 0, light_impact_range = 0, flame_range = null, flash_range = null, adminlog = TRUE, ignorecap = FALSE, silent = FALSE, smoke = FALSE, atom/explosion_cause = null)
. = SSexplosions.explode(arglist(args))
@@ -219,7 +219,7 @@ SUBSYSTEM_DEF(explosions)
* - smoke: Whether to generate a smoke cloud provided the explosion is powerful enough to warrant it.
* - explosion_cause: [Optional] The atom that caused the explosion, when different to the origin. Used for logging.
*/
/datum/controller/subsystem/explosions/proc/explode(atom/origin, devastation_range = 0, heavy_impact_range = 0, light_impact_range = 0, flame_range = 0, flash_range = 0, adminlog = TRUE, ignorecap = FALSE, silent = FALSE, smoke = FALSE, atom/explosion_cause = null)
/datum/controller/subsystem/explosions/proc/explode(atom/origin, devastation_range = 0, heavy_impact_range = 0, light_impact_range = 0, flame_range = null, flash_range = null, adminlog = TRUE, ignorecap = FALSE, silent = FALSE, smoke = FALSE, atom/explosion_cause = null)
var/list/arguments = list(
EXARG_KEY_ORIGIN = origin,
EXARG_KEY_DEV_RANGE = devastation_range,