cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2025-12-09 16:05:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes a runtime in Job Intern code (#4543)

Browse Source 
## About The Pull Request
This PR changes the code for job interns to prevent a runtime related to
jobs that have no real /datum/job as a department head (such as NTC and
Blueshield.) Now, if the job doesn't have a department head, it'll just
move on instead of runtiming.

## Why It's Good For The Game
Fixes an error, no player facing changes

## Proof Of Testing
I sadly cannot test this. It compiles

<details>
<summary>Screenshots/Videos</summary>

</details>

## Changelog

🆑 ReturnToZender
fix: A runtime in Job Intern code for jobs lacking a department head to
reference
/🆑
This commit is contained in:
Return
2025-08-26 09:57:51 -05:00
committed by GitHub
parent b2bae939bf
commit 082417d036
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modular_zubbers/code/modules/job_interns/job_interns.dm
View File

@@ -78,7 +78,7 @@
return FALSE
playtime = play_records[title] ? text2num(play_records[title]) : 0
required_time = get_intern_time_threshold()
else if(CONFIG_GET(flag/use_intern_master_job_unlock_threshold) && length(department_head))
else if(CONFIG_GET(flag/use_intern_master_job_unlock_threshold) && length(department_head) && SSjob.get_job(department_head[1]))
// Use first department head job as our master job to compare to
var/datum/job/master_job = SSjob.get_job(department_head[1])
playtime = player_client?.calc_exp_type(master_job.get_exp_req_type())