From 087f993fb1951fcb0bbc6aa804c5312c5ee74fe5 Mon Sep 17 00:00:00 2001
From: Tim <timothymtorres@gmail.com>
Date: Tue, 15 Jul 2025 09:39:23 -0500
Subject: [PATCH] `map_export` now saves welded airlocks and paper on
 noticeboards (#91960)

When using `map-export`:
- Exports the welded state of an airlock to the welded airlock mapping
helper
- Exports the paper inside of a noticeboard to pop out and be saved on
the same turf

Both `airlocks` and `noticeboards` handle the outside objects already in
their `Initialization()` procs so I didn't have to change anything. Also
I cleaned up the paper code and added some better code documentation to
`on_object_saved()`.

We convert this:

![dreamseeker_h4gQeOTaSC](https://github.com/user-attachments/assets/356b976f-b597-4492-96b0-7169b22e1845)

To this:

![StrongDMM_lQ5B1i8lH5](https://github.com/user-attachments/assets/b5360967-3e36-4e32-b94d-a51245eab867)

## Why It's Good For The Game
There weren't any good examples of using `on_object_saved()` and the
documentation was lacking so I wanted to include some proof of concept
for a few objects. Also airlocks already save their welded state, but I
think it looks better to have it as a mapping helper since it shows up
in StrongDMM instead of being a VV edit.
---
 code/game/machinery/doors/door.dm           | 11 +++++++----
 code/game/objects/structures/noticeboard.dm | 17 +++++++++++++----
 code/modules/admin/verbs/map_export.dm      |  5 ++++-
 3 files changed, 24 insertions(+), 9 deletions(-)

diff --git a/code/game/machinery/doors/door.dm b/code/game/machinery/doors/door.dm
index 08a8c8a8eb9..b6bb0c0a514 100644
--- a/code/game/machinery/doors/door.dm
+++ b/code/game/machinery/doors/door.dm
@@ -82,10 +82,13 @@
 	fire = 80
 	acid = 70
 
-/obj/machinery/door/get_save_vars()
-	. = ..()
-	. += NAMEOF(src, welded)
-	return .
+/obj/machinery/door/on_object_saved()
+	var/data
+
+	if(welded)
+		data += "[data ? ",\n" : ""][/obj/effect/mapping_helpers/airlock/welded]"
+
+	return data
 
 /obj/machinery/door/Initialize(mapload)
 	AddElement(/datum/element/blocks_explosives)
diff --git a/code/game/objects/structures/noticeboard.dm b/code/game/objects/structures/noticeboard.dm
index c7089e631b7..c352f1f48ef 100644
--- a/code/game/objects/structures/noticeboard.dm
+++ b/code/game/objects/structures/noticeboard.dm
@@ -13,18 +13,27 @@
 
 MAPPING_DIRECTIONAL_HELPERS(/obj/structure/noticeboard, 32)
 
+/obj/structure/noticeboard/on_object_saved()
+	var/data
+
+	for(var/obj/item/paper/paper in contents)
+		var/metadata = generate_tgm_metadata(paper)
+		data += "[data ? ",\n" : ""][paper.type][metadata]"
+
+	return data
+
 /obj/structure/noticeboard/Initialize(mapload)
 	. = ..()
 
 	if(!mapload)
 		return
 
-	for(var/obj/item/I in loc)
+	for(var/obj/item/paper/paper in loc)
 		if(notices >= MAX_NOTICES)
 			break
-		if(istype(I, /obj/item/paper))
-			I.forceMove(src)
-			notices++
+
+		paper.forceMove(src)
+		notices++
 	update_appearance(UPDATE_ICON)
 	find_and_hang_on_wall()
 
diff --git a/code/modules/admin/verbs/map_export.dm b/code/modules/admin/verbs/map_export.dm
index eea48ae8b2b..0546eb3723c 100644
--- a/code/modules/admin/verbs/map_export.dm
+++ b/code/modules/admin/verbs/map_export.dm
@@ -45,7 +45,10 @@ ADMIN_VERB(map_export, R_DEBUG, "Map Export", "Select a part of the map by coord
 
 /**
  * A procedure for saving non-standard properties of an object.
- * For example, saving ore into a silo, and further spavn by coordinates of metal stacks objects
+ * Examples:
+ * Saving material stacks (ie. ore in a silo)
+ * Saving variables that can be shown as mapping helpers (ie. welded airlock mapping helper)
+ * Saving objects inside of another object (ie. paper inside a noticeboard)
  */
 /obj/proc/on_object_saved()
 	return null