Audits and cleans up Trigger() parent calls (#95548)

## About The Pull Request

``/datum/action/proc/Trigger(mob/clicker, trigger_flags)`` has a lot of
children, many of which use mixed ``. = ..()`` or no parent calls at
all.


https://github.com/tgstation/tgstation/blob/d65ee47f6ebd0384d463a1f2a044c321ff2d912f/code/datums/actions/action.dm#L163-L170

This PR attempts to standardize all the children procs to call parent in
a uniform way, or cements that they *shouldnt* call parent for whatever
reason.
## Why It's Good For The Game

Base proc calls are important, yanno?

The base proc has the action button signals and availability proc on it,
so its technically possible for children procs of trigger() to have
check_flags enabled, but never blocked (i.e AB_CHECK_CONSCIOUS,
AB_CHECK_HANDS_BLOCKED).

Some children procs have IsAvailable on them, but its possible they can
be skipped over if a coder is not paying attention. This reduces that
risk.
This commit is contained in:
Tsar-Salat
2026-04-07 15:23:25 -04:00
committed by GitHub
parent 1e9ad25ad6
commit 0917d44cc8
22 changed files with 123 additions and 25 deletions
@@ -226,6 +226,8 @@
return ..()
/datum/action/innate/bci_charge_action/Trigger(mob/clicker, trigger_flags)
if(!..())
return
var/obj/item/stock_parts/power_store/cell/cell = circuit_component.parent.cell
if (isnull(cell))