Optimize cardboard cutouts saving 1.5s+ on init times (#73404)

Browse Source

New regression in init times. Closes
https://github.com/tgstation/dev-cycles-initiative/issues/32. CC @Fikou

- Instead of creating a human and icon for *every* cardboard cutout when
initialized, only creates the one we're actually using. When you're
about to use a crayon, creates all of them.
- Instead of using getFlatIcon, uses appearances directly.

...

This commit is contained in:

Mothblocks

2023-02-18 22:58:35 -07:00

committed by GitHub

parent 1191bce9b0

commit 09cfba5feb

23 changed files with 124 additions and 74 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

code/modules/unit_tests/screenshots/cardboard_cutouts_normal_cutout.png

BIN

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 319 B

code/modules/unit_tests/screenshots/cardboard_cutouts_nukie_cutout.png

BIN

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 575 B

code/modules/unit_tests/screenshots/cardboard_cutouts_nukie_cutout_pushed.png

BIN

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 229 B

code/modules/unit_tests/screenshots/cardboard_cutouts_xenomorph_cutout.png

BIN

Binary file not shown.

Side by Side After Width:  |  Height:  |  Size: 458 B