From 0a0d8e11d50bf86cd01c9f9ea5716e3141c90eee Mon Sep 17 00:00:00 2001 From: Bloop <13398309+vinylspiders@users.noreply.github.com> Date: Sat, 8 Mar 2025 14:47:59 -0500 Subject: [PATCH] Stops anomalies from running off during CI and causing a flaky mapping nearstation error (#89796) ## About The Pull Request The anomaly ruin has several anomalies floating in space. They have a nearstation area on their tile, but the problem is there is a chance that they can move before the mapping_nearstation unit test completes, causing them to be in a non-area and ruining the run. This PR just ensures that they stay in place during unit tests. --- code/game/objects/effects/anomalies/_anomalies.dm | 2 ++ code/game/objects/effects/anomalies/anomalies_hallucination.dm | 2 ++ 2 files changed, 4 insertions(+) diff --git a/code/game/objects/effects/anomalies/_anomalies.dm b/code/game/objects/effects/anomalies/_anomalies.dm index 10644a01dd2..3cf2ee6a8f5 100644 --- a/code/game/objects/effects/anomalies/_anomalies.dm +++ b/code/game/objects/effects/anomalies/_anomalies.dm @@ -75,8 +75,10 @@ return ..() /obj/effect/anomaly/proc/anomalyEffect(seconds_per_tick) +#ifndef UNIT_TESTS // These might move away during a CI run and cause a flaky mapping nearstation errors if(SPT_PROB(move_chance, seconds_per_tick)) move_anomaly() +#endif /// Move in a direction /obj/effect/anomaly/proc/move_anomaly() diff --git a/code/game/objects/effects/anomalies/anomalies_hallucination.dm b/code/game/objects/effects/anomalies/anomalies_hallucination.dm index 01b8716e81d..5acc772c1bc 100644 --- a/code/game/objects/effects/anomalies/anomalies_hallucination.dm +++ b/code/game/objects/effects/anomalies/anomalies_hallucination.dm @@ -85,8 +85,10 @@ ) /obj/effect/anomaly/hallucination/decoy/anomalyEffect(seconds_per_tick) +#ifndef UNIT_TESTS // These might move away during a CI run and cause a flaky mapping nearstation errors if(SPT_PROB(move_chance, seconds_per_tick)) move_anomaly() +#endif /obj/effect/anomaly/hallucination/decoy/analyzer_act(mob/living/user, obj/item/analyzer/tool) to_chat(user, span_notice("You activate [tool]. [replacetext(report_text, "%TOOL%", "[tool]")]"))