Unit test material checks are now performed on all crafting recipes by default. All stack recipes now transfer mats to the results (#92620)

## About The Pull Request
Extends the part of the crafting unit test that ensures consistency
between the total mats of the components of a recipe (or rather, the
result of said recipe) and a generic instance of the same type as its
result, previously only implemented on food recipes.

## Why It's Good For The Game
This ensures a degree of consistency with the material composition of
various objects in the game. I couldn't do it in the original PR as that
one was too big already and it took months to get it merged, and have
the relative bugs fixed.

Currently a WIP as I slowly deal with the unit test reports.

## Changelog

🆑
refactor: Follow-up to the crafting/material refactor from months ago.
All objects crafted with stacks now inherit their mat composition (not
necessarily the effects and color) by default, while previously only a
few things like chair, sinks and toilets did. Report any object looking
or behaving weirdly as a result.
fix: The material composition of ammo boxes is no longer a 1/10 of what
it's supposed to be. It was a shitty hack to make it harder to recycle
empty ammo boxes. Instead, they lose materials as they're emptied now.
/🆑
This commit is contained in:
Ghom
2025-12-03 00:29:01 +01:00
committed by GitHub
parent 085007eae1
commit 0b0c5ea91e
272 changed files with 850 additions and 280 deletions
@@ -194,6 +194,7 @@
heat_protection = CHEST|GROIN|LEGS|FEET|ARMS
max_heat_protection_temperature = SPACE_SUIT_MAX_TEMP_PROTECT
resistance_flags = FIRE_PROOF
custom_materials = list(/datum/material/bone = SHEET_MATERIAL_AMOUNT * 6)
/obj/item/clothing/suit/armor/bone/Initialize(mapload)
. = ..()
@@ -214,6 +215,7 @@
max_heat_protection_temperature = SPACE_SUIT_MAX_TEMP_PROTECT
armor_type = /datum/armor/hooded_explorer
resistance_flags = FIRE_PROOF
custom_materials = list(/datum/material/bone = SHEET_MATERIAL_AMOUNT * 4)
/obj/item/clothing/head/helmet/skull/Initialize(mapload)
. = ..()
@@ -181,6 +181,7 @@
attack_verb_simple = list("slash", "impale", "stab", "slice")
sharpness = SHARP_EDGED
item_flags = CRUEL_IMPLEMENT
custom_materials = list(/datum/material/bone = SHEET_MATERIAL_AMOUNT * 4, /datum/material/iron = SMALL_MATERIAL_AMOUNT * 0.5)
/obj/item/shovel/serrated/Initialize(mapload)
. = ..()
@@ -322,6 +323,7 @@
item_flags = SLOWS_WHILE_IN_HAND | IMMUTABLE_SLOW
slowdown = 3
attack_speed = 1.2 SECONDS
custom_materials = list(/datum/material/iron = SHEET_MATERIAL_AMOUNT * 6.6, /datum/material/alloy/plasteel = SHEET_MATERIAL_AMOUNT * 5)
/// The factor at which the recoil becomes less.
var/recoil_factor = 3
/// Wether we knock down and launch away out enemies when we attack.
@@ -417,6 +417,7 @@
icon_state = "mushroom_bowl"
fill_icon_state = "fullbowl"
fill_icon = 'icons/obj/mining_zones/ash_flora.dmi'
custom_materials = null
/obj/item/reagent_containers/cup/bowl/mushroom_bowl/update_icon_state()
if(!reagents.total_volume)
@@ -5,6 +5,7 @@
desc = "The gathered remains of a drake. It still crackles with heat, and smells distinctly of brimstone."
icon = 'icons/obj/clothing/head/helmet.dmi'
icon_state = "dragon"
custom_materials = list(/datum/material/bone = SHEET_MATERIAL_AMOUNT * 10)
/obj/item/drake_remains/Initialize(mapload)
. = ..()
@@ -27,6 +28,7 @@
max_heat_protection_temperature = FIRE_IMMUNITY_MAX_TEMP_PROTECT
resistance_flags = FIRE_PROOF | ACID_PROOF
transparent_protection = HIDEGLOVES|HIDESUITSTORAGE|HIDEJUMPSUIT|HIDESHOES
custom_materials = list(/datum/material/bone = SHEET_MATERIAL_AMOUNT * 10)
/datum/armor/cloak_drake
melee = 65
@@ -134,3 +134,4 @@
icon = 'icons/obj/mining_zones/artefacts.dmi'
icon_state = "skeleton_key"
w_class = WEIGHT_CLASS_SMALL
custom_materials = list(/datum/material/bone = SHEET_MATERIAL_AMOUNT * 5)
+1 -1
View File
@@ -116,7 +116,7 @@
GLOBAL_LIST_INIT(sand_recipes, list(\
new /datum/stack_recipe("pile of dirt", /obj/machinery/hydroponics/soil, 3, time = 1 SECONDS, crafting_flags = CRAFT_CHECK_DENSITY | CRAFT_ONE_PER_TURF | CRAFT_ON_SOLID_GROUND, category = CAT_TOOLS), \
new /datum/stack_recipe("sandstone", /obj/item/stack/sheet/mineral/sandstone, 1, 1, 50, crafting_flags = NONE, category = CAT_MISC),\
new /datum/stack_recipe("sandstone", /obj/item/stack/sheet/mineral/sandstone, 1, 1, 50, crafting_flags = CRAFT_NO_MATERIALS, category = CAT_MISC),\
new /datum/stack_recipe("aesthetic volcanic floor tile", /obj/item/stack/tile/basalt, 2, 1, 50, crafting_flags = NONE, category = CAT_TILES)\
))
+1
View File
@@ -8,6 +8,7 @@
desc = "A heavy wooden box, which can be filled with a lot of ores or boulders"
density = TRUE
pressure_resistance = 5 * ONE_ATMOSPHERE
custom_materials = list(/datum/material/wood = SHEET_MATERIAL_AMOUNT * 4)
/obj/structure/ore_box/Initialize(mapload)
. = ..()