remove useless view_variables verb from stat panel (#92040)

## About The Pull Request

Make `VV` verb Context Menu only.
As it's very annoing when clicked on, because it's forming the list of
all atoms in world which causes nasty client freeze.

## Why It's Good For The Game

No more accidentally clicking VV when trying to click View Runtimes 😠 

## Changelog

🆑
admin: VV verb is removed from Debug tab. Who is even using it?
/🆑
This commit is contained in:
Gaxeer
2025-07-09 09:39:23 -04:00
committed by GitHub
parent 8925c9c184
commit 0c10a3684d
4 changed files with 13 additions and 8 deletions
+2 -1
View File
@@ -71,7 +71,8 @@ ADMIN_VERB(debug_controller, R_DEBUG, "Debug Controller", "Debug the various per
if (!istype(controller))
return
SSadmin_verbs.dynamic_invoke_verb(user, /datum/admin_verb/debug_variables, controller)
user.debug_variables(controller)
BLACKBOX_LOG_ADMIN_VERB("Debug Controller")
message_admins("Admin [key_name_admin(user)] is debugging the [controller] controller.")
+8 -1
View File
@@ -224,11 +224,18 @@ ADMIN_VERB(cmd_controller_view_ui, R_SERVER|R_DEBUG, "Controller Overview", "Vie
return TRUE
if("view_variables")
if(!check_rights_for(ui.user.client, R_DEBUG))
message_admins(
"[key_name(ui.user)] tried to view master controller variables while having improper rights, \
this is potentially a malicious exploit and worth noting."
)
var/datum/controller/subsystem/subsystem = locate(params["ref"]) in subsystems
if(isnull(subsystem))
to_chat(ui.user, span_warning("Failed to locate subsystem."))
return
SSadmin_verbs.dynamic_invoke_verb(ui.user, /datum/admin_verb/debug_variables, subsystem)
ui.user.client.debug_variables(subsystem)
return TRUE
/datum/controller/master/proc/check_and_perform_fast_update()