cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-22 12:41:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

[NO GBP] Fix-up a line I missed during refactoring in my icon_exists optimization PR (#89374)

Browse Source 
## About The Pull Request
While porting https://github.com/tgstation/tgstation/pull/89357 over to
monkestation, I found that I missed refactoring a couple lines in
`code\modules\asset_cache\assets\vending.dm`. This PR fixes that.

The changed code is all behind `if
(PERFORM_ALL_TESTS(focus_only/invalid_vending_machine_icon_states))`.
This means the changed code will only be executed if unit tests are
enabled *and* `invalid_vending_machine_icon_states` is a test that will
be run.

Despite that, I feel this code may be marginally faster, as the use of
`icon_states()` is now behind `!icon_exists()`.

## Why It's Good For The Game
Gotta go ever so slightly faster.
This commit is contained in:
MichiRecRoom
2025-02-08 15:19:53 -08:00
committed by GitHub
parent 9dd0220470
commit 0d3c813c67
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/asset_cache/assets/vending.dm
+2 -3
View File
@@ -30,10 +30,9 @@
continue
if (PERFORM_ALL_TESTS(focus_only/invalid_vending_machine_icon_states))
var/icon_states_list = icon_states(icon_file)
if (!(icon_state in icon_states_list))
if (!icon_exists(icon_file, icon_state))
var/icon_states_string
for (var/an_icon_state in icon_states_list)
for (var/an_icon_state in icon_states(icon_file))
if (!icon_states_string)
icon_states_string = "[json_encode(an_icon_state)]([text_ref(an_icon_state)])"
else