diff --git a/code/datums/ai/oldhostile/hostile_tameable.dm b/code/datums/ai/oldhostile/hostile_tameable.dm index 04ee10fd908..1e64280eb45 100644 --- a/code/datums/ai/oldhostile/hostile_tameable.dm +++ b/code/datums/ai/oldhostile/hostile_tameable.dm @@ -44,6 +44,7 @@ return ..() //Run parent at end /datum/ai_controller/hostile_friend/proc/on_prebuckle(mob/source, mob/living/buckler, force, buckle_mob_flags) + SIGNAL_HANDLER if(force || ai_status == AI_STATUS_OFF) return if(WEAKREF(buckler) != blackboard[BB_HOSTILE_FRIEND]) diff --git a/code/datums/alarm.dm b/code/datums/alarm.dm index 17ac80abc67..1cc9b883399 100644 --- a/code/datums/alarm.dm +++ b/code/datums/alarm.dm @@ -122,6 +122,8 @@ ///Adds an alarm to our alarms list, you shouldn't be calling this manually ///It should all be handled by the signal listening we do, unless you want to only send an alarm to one listener /datum/alarm_listener/proc/add_alarm(datum/source, datum/alarm_handler/handler, alarm_type, area/source_area, source_z, optional_camera) + SIGNAL_HANDLER + if (!accepting_alarm_changes) return @@ -156,6 +158,8 @@ ///Removes an alarm to our alarms list, you probably shouldn't be calling this manually ///It should all be handled by the signal listening we do, unless you want to only remove an alarm to one listener /datum/alarm_listener/proc/clear_alarm(datum/source, datum/alarm_handler/handler, alarm_type, area/source_area) + SIGNAL_HANDLER + if(!accepting_alarm_changes) return diff --git a/code/datums/components/rot.dm b/code/datums/components/rot.dm index c8a2d04e83e..5a1cabcff29 100644 --- a/code/datums/components/rot.dm +++ b/code/datums/components/rot.dm @@ -95,6 +95,7 @@ start_up(REAGENT_BLOCKER) /datum/component/rot/proc/check_for_temperature(datum/source, old_temp, new_temp) + SIGNAL_HANDLER if(new_temp <= T0C-10) rest(TEMPERATURE_BLOCKER) return diff --git a/code/datums/components/trapdoor.dm b/code/datums/components/trapdoor.dm index 62e0089aa07..a04ca5f9ca6 100644 --- a/code/datums/components/trapdoor.dm +++ b/code/datums/components/trapdoor.dm @@ -74,6 +74,7 @@ ///called by linking remotes to tie an assembly to the trapdoor /datum/component/trapdoor/proc/on_link_requested(datum/source, obj/item/assembly/trapdoor/assembly) + SIGNAL_HANDLER if(get_dist(parent, assembly) > TRAPDOOR_LINKING_SEARCH_RANGE) return . = LINKED_UP diff --git a/code/datums/elements/basic_body_temp_sensitive.dm b/code/datums/elements/basic_body_temp_sensitive.dm index 9f3709d918f..bfdfcbafe28 100644 --- a/code/datums/elements/basic_body_temp_sensitive.dm +++ b/code/datums/elements/basic_body_temp_sensitive.dm @@ -36,6 +36,8 @@ /datum/element/basic_body_temp_sensitive/proc/on_life(datum/target, delta_time, times_fired) + SIGNAL_HANDLER + var/mob/living/basic/basic_mob = target var/gave_alert = FALSE diff --git a/code/datums/quirks/neutral.dm b/code/datums/quirks/neutral.dm index 392a37fe19e..06b6357451b 100644 --- a/code/datums/quirks/neutral.dm +++ b/code/datums/quirks/neutral.dm @@ -69,6 +69,7 @@ RegisterSignal(human_holder, COMSIG_SPECIES_GAIN, .proc/on_species_gain) /datum/quirk/vegetarian/proc/on_species_gain(datum/source, datum/species/new_species, datum/species/old_species) + SIGNAL_HANDLER new_species.liked_food &= ~MEAT new_species.disliked_food |= MEAT @@ -108,6 +109,7 @@ RegisterSignal(human_holder, COMSIG_SPECIES_GAIN, .proc/on_species_gain) /datum/quirk/pineapple_liker/proc/on_species_gain(datum/source, datum/species/new_species, datum/species/old_species) + SIGNAL_HANDLER new_species.liked_food |= PINEAPPLE /datum/quirk/pineapple_liker/remove() @@ -132,6 +134,7 @@ RegisterSignal(human_holder, COMSIG_SPECIES_GAIN, .proc/on_species_gain) /datum/quirk/pineapple_hater/proc/on_species_gain(datum/source, datum/species/new_species, datum/species/old_species) + SIGNAL_HANDLER new_species.disliked_food |= PINEAPPLE /datum/quirk/pineapple_hater/remove() @@ -158,6 +161,7 @@ RegisterSignal(human_holder, COMSIG_SPECIES_GAIN, .proc/on_species_gain) /datum/quirk/deviant_tastes/proc/on_species_gain(datum/source, datum/species/new_species, datum/species/old_species) + SIGNAL_HANDLER var/liked = new_species.liked_food new_species.liked_food = new_species.disliked_food new_species.disliked_food = liked diff --git a/code/modules/admin/verbs/SDQL2/SDQL_spells/spells.dm b/code/modules/admin/verbs/SDQL2/SDQL_spells/spells.dm index 7716b0b07c6..093e4e8dd16 100644 --- a/code/modules/admin/verbs/SDQL2/SDQL_spells/spells.dm +++ b/code/modules/admin/verbs/SDQL2/SDQL_spells/spells.dm @@ -9,10 +9,11 @@ RegisterSignal(src, COMSIG_PROJECTILE_ON_HIT, .proc/on_projectile_hit) /obj/effect/proc_holder/spell/aimed/sdql/proc/on_projectile_hit(source, firer, target) + SIGNAL_HANDLER var/datum/component/sdql_executor/executor = GetComponent(/datum/component/sdql_executor) if(!executor) CRASH("[src]'s SDQL executor component went missing!") - executor.execute(list(target), owner.resolve()) + INVOKE_ASYNC(executor, /datum/component/sdql_executor/proc/execute, list(target), owner.resolve()) /obj/effect/proc_holder/spell/aoe_turf/sdql name = "AoE SDQL Spell" @@ -140,7 +141,8 @@ user.update_inv_hands() /obj/effect/proc_holder/spell/targeted/touch/sdql/proc/on_touch_attack(source, target, user) + SIGNAL_HANDLER var/datum/component/sdql_executor/executor = GetComponent(/datum/component/sdql_executor) if(!executor) CRASH("[src]'s SDQL executor component went missing!") - executor.execute(list(target), user) + INVOKE_ASYNC(executor, /datum/component/sdql_executor/proc/execute, list(target), user) diff --git a/code/modules/atmospherics/machinery/components/binary_devices/valve.dm b/code/modules/atmospherics/machinery/components/binary_devices/valve.dm index 08c3f2d665c..e9c92cae73c 100644 --- a/code/modules/atmospherics/machinery/components/binary_devices/valve.dm +++ b/code/modules/atmospherics/machinery/components/binary_devices/valve.dm @@ -124,6 +124,7 @@ It's like a regular ol' straight pipe, but you can turn it on and off. return ..() /obj/item/circuit_component/digital_valve/proc/handle_valve_toggled(datum/source, on) + SIGNAL_HANDLER is_open.set_output(on) if(on) opened.set_output(COMPONENT_SIGNAL) diff --git a/code/modules/experisci/experiment/handlers/experiment_handler.dm b/code/modules/experisci/experiment/handlers/experiment_handler.dm index 2e680305977..4cf93bc9484 100644 --- a/code/modules/experisci/experiment/handlers/experiment_handler.dm +++ b/code/modules/experisci/experiment/handlers/experiment_handler.dm @@ -247,7 +247,8 @@ * * user - The user to show the experiment configuration panel to */ /datum/component/experiment_handler/proc/configure_experiment_click(datum/source, mob/user) - ui_interact(user) + SIGNAL_HANDLER + INVOKE_ASYNC(src, /datum/proc/ui_interact, user) /** * Attempts to link this experiment_handler to a provided techweb diff --git a/code/modules/mafia/roles.dm b/code/modules/mafia/roles.dm index a48f890d108..f19272f2ab8 100644 --- a/code/modules/mafia/roles.dm +++ b/code/modules/mafia/roles.dm @@ -545,6 +545,7 @@ role_flags |= ROLE_VULNERABLE /datum/mafia_role/hos/proc/internal_affairs(datum/mafia_controller/game) + SIGNAL_HANDLER to_chat(body,span_userdanger("You have been killed by Nanotrasen Internal Affairs!")) reveal_role(game, verbose = TRUE) kill(game,src,FALSE) //you technically kill yourself but that shouldn't matter diff --git a/code/modules/wiremod/core/port.dm b/code/modules/wiremod/core/port.dm index ca668bc6842..304dc506917 100644 --- a/code/modules/wiremod/core/port.dm +++ b/code/modules/wiremod/core/port.dm @@ -133,6 +133,7 @@ disconnect(output) /datum/port/input/proc/disconnect(datum/port/output/output) + SIGNAL_HANDLER connected_ports -= output UnregisterSignal(output, COMSIG_PORT_SET_VALUE) UnregisterSignal(output, COMSIG_PORT_SET_TYPE) diff --git a/code/modules/wiremod/shell/moneybot.dm b/code/modules/wiremod/shell/moneybot.dm index 998f304f5b0..50474b91b0a 100644 --- a/code/modules/wiremod/shell/moneybot.dm +++ b/code/modules/wiremod/shell/moneybot.dm @@ -149,4 +149,5 @@ * * new_value - A boolean that determines if the circuit is locked or not. **/ /obj/item/circuit_component/money_bot/proc/on_set_locked(datum/source, new_value) + SIGNAL_HANDLER attached_bot.locked = new_value diff --git a/code/modules/wiremod/shell/scanner_gate.dm b/code/modules/wiremod/shell/scanner_gate.dm index db27885467a..7c40e8bfaf4 100644 --- a/code/modules/wiremod/shell/scanner_gate.dm +++ b/code/modules/wiremod/shell/scanner_gate.dm @@ -76,4 +76,5 @@ * * new_value - A boolean that determines if the circuit is locked or not. **/ /obj/item/circuit_component/scanner_gate/proc/on_set_locked(datum/source, new_value) + SIGNAL_HANDLER attached_gate.locked = new_value