mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-30 16:47:13 +01:00
Persistent Map Vote Tallies (#86788)
## About The Pull Request Changes map votes to be based on a persistent tally count. Tallies for maps are cached between rounds and are added to by map votes. When a map is chosen, and it wasn't the only valid one, the tallies for said chosen map will be reset. Refactors map vote handling and moves it from SSmapping to SSmap_vote. Rock the Vote has been removed as a result of this refactor. ## Why It's Good For The Game Makes it more likely that all maps will be played over the course of a server instead of always being truly random. Removes some clutter off of SSmapping. 🆑 refactor: Map Votes are now carried over between rounds. When a map vote is actually a contest, the winning map will have its votes reset. /🆑
This commit is contained in:
@@ -26,14 +26,14 @@ SUBSYSTEM_DEF(library)
|
||||
|
||||
/datum/controller/subsystem/library/proc/load_shelves()
|
||||
var/list/datum/callback/load_callbacks = list()
|
||||
|
||||
|
||||
for(var/obj/structure/bookcase/case_to_load as anything in shelves_to_load)
|
||||
if(!case_to_load)
|
||||
stack_trace("A null bookcase somehow ended up in SSlibrary's shelves_to_load list. Did something harddel?")
|
||||
continue
|
||||
load_callbacks += CALLBACK(case_to_load, TYPE_PROC_REF(/obj/structure/bookcase, load_shelf))
|
||||
shelves_to_load = null
|
||||
|
||||
|
||||
//Load all of the shelves asyncronously at the same time, blocking until the last one is finished.
|
||||
callback_select(load_callbacks, savereturns = FALSE)
|
||||
|
||||
@@ -59,6 +59,6 @@ SUBSYSTEM_DEF(library)
|
||||
|
||||
/datum/controller/subsystem/library/proc/prepare_library_areas()
|
||||
library_areas = typesof(/area/station/service/library) - /area/station/service/library/abandoned
|
||||
var/list/additional_areas = SSmapping.config.library_areas
|
||||
var/list/additional_areas = SSmapping.current_map.library_areas
|
||||
if(additional_areas)
|
||||
library_areas += additional_areas
|
||||
|
||||
Reference in New Issue
Block a user