Remove hideous inline tab indentation, and bans it in contributing guidelines (#56912)

Done using this command sed -Ei 's/(\s*\S+)\s*\t+/\1 /g' code/**/*.dm

We have countless examples in the codebase with this style gone wrong, and defines and such being on hideously different levels of indentation. Fixing this to keep the alignment involves tainting the blames of code your PR doesn't need to be touching at all. And ultimately, it's hideous.

There are some files that this sed makes uglier. I can fix these when they are pointed out, but I believe this is ultimately for the greater good of readability. I'm more concerned with if any strings relied on this.

Hi codeowners!

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>

code/modules/instruments/instrument_data/_instrument_data.dm

@@ -96,7 +96,7 @@
 		var/to_key = real_keys[i+1]
 		var/sample1 = real_samples[num2text(from_key)]
 		var/sample2 = real_samples[num2text(to_key)]
-		var/pivot = FLOOR((from_key + to_key) / 2, 1)			//original code was a round but I replaced it because that's effectively a floor, thanks Baystation! who knows what was intended.
+		var/pivot = FLOOR((from_key + to_key) / 2, 1) //original code was a round but I replaced it because that's effectively a floor, thanks Baystation! who knows what was intended.
 		for(var/key in from_key to pivot)
 			samples[num2text(key)] = new /datum/instrument_key(sample1, key, key - from_key)
 		for(var/key in (pivot + 1) to to_key)

code/modules/instruments/instrument_data/hardcoded.dm

@@ -5,7 +5,7 @@
 	abstract_type = /datum/instrument/hardcoded
 	category = "Non-Synthesized"
 	instrument_flags = INSTRUMENT_LEGACY
-	volume_multiplier = 1		//not as loud as synth'd
+	volume_multiplier = 1 //not as loud as synth'd
 
 /datum/instrument/hardcoded/accordion
 	name = "Accordion"

code/modules/instruments/items.dm

@@ -17,14 +17,14 @@
 /obj/item/instrument/Initialize(mapload)
 	. = ..()
 	song = new(src, allowed_instrument_ids, instrument_range)
-	allowed_instrument_ids = null			//We don't need this clogging memory after it's used.
+	allowed_instrument_ids = null //We don't need this clogging memory after it's used.
 
 /obj/item/instrument/Destroy()
 	QDEL_NULL(song)
 	return ..()
 
 /obj/item/instrument/proc/should_stop_playing(mob/user)
-	return user.incapacitated() || !((loc == user) || (isturf(loc) && Adjacent(user)))		// sorry, no more TK playing.
+	return user.incapacitated() || !((loc == user) || (isturf(loc) && Adjacent(user))) // sorry, no more TK playing.
 
 /obj/item/instrument/suicide_act(mob/user)
 	user.visible_message("<span class='suicide'>[user] begins to play 'Gloomy Sunday'! It looks like [user.p_theyre()] trying to commit suicide!</span>")

code/modules/instruments/songs/_song.dm

@@ -265,7 +265,7 @@
  */
 /datum/song/proc/tempodiv_to_delay(tempodiv)
 	if(!tempodiv)
-		tempodiv = 1		// no division by 0. some song converters tend to use 0 for when it wants to have no div, for whatever reason.
+		tempodiv = 1 // no division by 0. some song converters tend to use 0 for when it wants to have no div, for whatever reason.
 	return max(1, round((tempo/tempodiv) / world.tick_lag, 1))
 
 /**

code/modules/instruments/songs/editor.dm

@@ -112,7 +112,7 @@
 				lines.Remove(l)
 			else
 				linenum++
-		updateDialog(usr)		// make sure updates when complete
+		updateDialog(usr) // make sure updates when complete
 
 /datum/song/Topic(href, href_list)
 	if(!usr.canUseTopic(parent, TRUE, FALSE, FALSE, FALSE))
@@ -228,7 +228,7 @@
 		var/choice = input(usr, "Select Instrument", "Instrument Selection") as null|anything in instruments
 		if(!choice)
 			return
-		choice = instruments[choice]		//get id
+		choice = instruments[choice] //get id
 		if(choice)
 			set_instrument(choice)
 

code/modules/instruments/songs/play_legacy.dm

@@ -4,7 +4,7 @@
 /datum/song/proc/compile_legacy()
 	if(!length(src.lines))
 		return
-	var/list/lines = src.lines		//cache for hyepr speed!
+	var/list/lines = src.lines //cache for hyepr speed!
 	compiled_chords = list()
 	var/list/octaves = list(3, 3, 3, 3, 3, 3, 3)
 	var/list/accents = list("n", "n", "n", "n", "n", "n", "n")
@@ -17,7 +17,7 @@
 			var/len = length(notes_tempodiv)
 			if(len >= 2)
 				tempodiv = text2num(notes_tempodiv[2])
-			if(len)			//some dunkass is going to do ,,,, to make 3 rests instead of ,/1 because there's no standardization so let's be prepared for that.
+			if(len) //some dunkass is going to do ,,,, to make 3 rests instead of ,/1 because there's no standardization so let's be prepared for that.
 				var/list/notes = splittext(notes_tempodiv[1], "-")
 				for(var/note in notes)
 					if(length(note) == 0)
@@ -29,12 +29,12 @@
 					for(var/i in 2 to length(note))
 						var/oct_acc = copytext(note, i, i + 1)
 						var/num = text2num(oct_acc)
-						if(!num)		//it's an accidental
-							accents[key] = oct_acc		//if they misspelled it/fucked up that's on them lmao, no safety checks.
-						else	//octave
+						if(!num) //it's an accidental
+							accents[key] = oct_acc //if they misspelled it/fucked up that's on them lmao, no safety checks.
+						else //octave
 							octaves[key] = clamp(num, octave_min, octave_max)
 					compiled_chord[++compiled_chord.len] = list(key, accents[key], octaves[key])
-			compiled_chord += tempodiv		//this goes last
+			compiled_chord += tempodiv //this goes last
 			if(length(compiled_chord))
 				compiled_chords[++compiled_chords.len] = compiled_chord
 

code/modules/instruments/songs/play_synthesized.dm

@@ -4,7 +4,7 @@
 /datum/song/proc/compile_synthesized()
 	if(!length(src.lines))
 		return
-	var/list/lines = src.lines		//cache for hyepr speed!
+	var/list/lines = src.lines //cache for hyepr speed!
 	compiled_chords = list()
 	var/list/octaves = list(3, 3, 3, 3, 3, 3, 3)
 	var/list/accents = list("n", "n", "n", "n", "n", "n", "n")
@@ -17,7 +17,7 @@
 			var/len = length(notes_tempodiv)
 			if(len >= 2)
 				tempodiv = text2num(notes_tempodiv[2])
-			if(len)			//some dunkass is going to do ,,,, to make 3 rests instead of ,/1 because there's no standardization so let's be prepared for that.
+			if(len) //some dunkass is going to do ,,,, to make 3 rests instead of ,/1 because there's no standardization so let's be prepared for that.
 				var/list/notes = splittext(notes_tempodiv[1], "-")
 				for(var/note in notes)
 					if(length(note) == 0)
@@ -29,12 +29,12 @@
 					for(var/i in 2 to length(note))
 						var/oct_acc = copytext(note, i, i + 1)
 						var/num = text2num(oct_acc)
-						if(!num)		//it's an accidental
-							accents[key] = oct_acc		//if they misspelled it/fucked up that's on them lmao, no safety checks.
-						else	//octave
+						if(!num) //it's an accidental
+							accents[key] = oct_acc //if they misspelled it/fucked up that's on them lmao, no safety checks.
+						else //octave
 							octaves[key] = clamp(num, octave_min, octave_max)
 					compiled_chord += clamp((note_offset_lookup[key] + octaves[key] * 12 + accent_lookup[accents[key]]), key_min, key_max)
-			compiled_chord += tempodiv		//this goes last
+			compiled_chord += tempodiv //this goes last
 			if(length(compiled_chord))
 				compiled_chords[++compiled_chords.len] = compiled_chord
 
@@ -47,7 +47,7 @@
 		key = clamp(key + note_shift, key_min, key_max)
 	if((world.time - MUSICIAN_HEARCHECK_MINDELAY) > last_hearcheck)
 		do_hearcheck()
-	var/datum/instrument_key/K = using_instrument.samples[num2text(key)]			//See how fucking easy it is to make a number text? You don't need a complicated 9 line proc!
+	var/datum/instrument_key/K = using_instrument.samples[num2text(key)] //See how fucking easy it is to make a number text? You don't need a complicated 9 line proc!
 	//Should probably add channel limiters here at some point but I don't care right now.
 	var/channel = pop_channel()
 	if(isnull(channel))
@@ -94,7 +94,7 @@
  * Pops a channel we have reserved so we don't have to release and re-request them from SSsounds every time we play a note. This is faster.
  */
 /datum/song/proc/pop_channel()
-	if(length(channels_idle))			//just pop one off of here if we have one available
+	if(length(channels_idle)) //just pop one off of here if we have one available
 		. = text2num(channels_idle[1])
 		channels_idle.Cut(1,2)
 		return

code/modules/instruments/stationary.dm

@@ -20,7 +20,7 @@
 		return TRUE
 	if(!user)
 		return FALSE
-	return !user.canUseTopic(src, FALSE, TRUE, FALSE, FALSE)		//can play with TK and while resting because fun.
+	return !user.canUseTopic(src, FALSE, TRUE, FALSE, FALSE) //can play with TK and while resting because fun.
 
 /obj/structure/musician/ui_interact(mob/user)
 	. = ..()