From 100bbdefc5606ecdb2665d86b1a78bb5dceb18b4 Mon Sep 17 00:00:00 2001
From: BurgerLUA <8602857+BurgerLUA@users.noreply.github.com>
Date: Tue, 28 May 2024 01:07:45 -0700
Subject: [PATCH] The maintenance loot scarcity station trait now only spawns
 very rare loot  (#1500)

## About The Pull Request

The maintenance loot scarcity trait now only spawns very rare loot, with
only 1 instance being spawned.
This does not affect trash piles.

## Why It's Good For The Game

The station trait that removes maint loot is painful and boring to the
round because it means I can't powergame. This PR makes it so that the
trait isn't painful entirely.

## Proof Of Testing

If it compiles, it werks.

## Changelog

:cl: BurgerBB
balance: The maintenance loot scarcity station trait now only spawns
very rare loot
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
---
 code/game/objects/effects/spawners/random/maintenance.dm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/code/game/objects/effects/spawners/random/maintenance.dm b/code/game/objects/effects/spawners/random/maintenance.dm
index 3388f6252c8..ea434cb416d 100644
--- a/code/game/objects/effects/spawners/random/maintenance.dm
+++ b/code/game/objects/effects/spawners/random/maintenance.dm
@@ -17,6 +17,10 @@
 
 /obj/effect/spawner/random/maintenance/Initialize(mapload)
 	loot = GLOB.maintenance_loot
+	//BUBBERSTATION CHANGE START: EMPTY MAINT LOOT TRAIT ONLY SPAWNS THE BEST LOOT
+	if(HAS_TRAIT(SSstation, STATION_TRAIT_EMPTY_MAINT))
+		loot = prob(80) ? GLOB.rarity_loot : GLOB.oddity_loot
+	//BUBBERSTATION CHANGE END
 	return ..()
 
 /obj/effect/spawner/random/maintenance/proc/hide()
@@ -39,7 +43,7 @@
 		effective_lootcount = FLOOR(spawn_loot_count * 1.5, 1)
 
 	else if(HAS_TRAIT(SSstation, STATION_TRAIT_EMPTY_MAINT))
-		effective_lootcount = FLOOR(spawn_loot_count * 0.5, 1)
+		effective_lootcount = 1 //BUBBERSTATION CHANGE: ALWAYS JUST ONE.
 
 	return effective_lootcount