From 10cc9294b47e83eb69bffeaed41566e00d568aca Mon Sep 17 00:00:00 2001 From: KorPhaeron Date: Wed, 14 Dec 2016 18:44:23 -0500 Subject: [PATCH] Adds explaining the rationale behind your PR as a requirement in contributing.md (#22174) * Use your words * Updates the template * Make it hidden --- CONTRIBUTING.md | 2 ++ PULL_REQUEST_TEMPLATE.md | 2 ++ 2 files changed, 4 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4ef214ffa27..8fc6c8aea06 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -287,6 +287,8 @@ There is no strict process when it comes to merging pull requests, pull requests * If your pull request is accepted, the code you add no longer belongs exclusively to you but to everyone; everyone is free to work on it, but you are also free to object to any changes being made, which will be noted by a Project Lead or Project Manager. It is a shame this has to be explicitly said, but there have been cases where this would've saved some trouble. +* Please explain why you are submitting the pull request, and how you think your change will be beneficial to the game. Failure to do so will be grounds for rejecting the PR. + ## Banned content Do not add any of the following in a Pull Request or risk getting the PR closed: * National Socialist Party of Germany content, National Socialist Party of Germany related content, or National Socialist Party of Germany references diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 490e045f3da..895871decf1 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -16,3 +16,5 @@ imagedel: deleted some icons and images spellcheck: fixed a few typos experiment: added an experimental thingy /:cl: + +[]: # (Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding:)