From 1196e7d087b674e6a9d984bb61ad79fe1dac35f6 Mon Sep 17 00:00:00 2001
From: Tad Hardesty <tad@platymuus.com>
Date: Mon, 2 Jul 2018 13:18:41 -0700
Subject: [PATCH] Add a warning for bad design icons, fix existing instances
 (#38840)

* Add a warning for bad design icons, fix existing instances

* Use non-line-numbered warning
---
 .../machinery/components/binary_devices/circulator.dm       | 2 +-
 code/modules/client/asset_cache.dm                          | 6 +++++-
 code/modules/modular_computers/computers/item/tablet.dm     | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/code/modules/atmospherics/machinery/components/binary_devices/circulator.dm b/code/modules/atmospherics/machinery/components/binary_devices/circulator.dm
index cf1d0e18660..7740398fbae 100644
--- a/code/modules/atmospherics/machinery/components/binary_devices/circulator.dm
+++ b/code/modules/atmospherics/machinery/components/binary_devices/circulator.dm
@@ -6,7 +6,7 @@
 /obj/machinery/atmospherics/components/binary/circulator
 	name = "circulator/heat exchanger"
 	desc = "A gas circulator pump and heat exchanger."
-	icon_state = "circ-off"
+	icon_state = "circ-off-0"
 
 	var/active = FALSE
 
diff --git a/code/modules/client/asset_cache.dm b/code/modules/client/asset_cache.dm
index a31fb63c319..b57aebb2cde 100644
--- a/code/modules/client/asset_cache.dm
+++ b/code/modules/client/asset_cache.dm
@@ -587,7 +587,11 @@ GLOBAL_LIST_EMPTY(asset_datums)
 			if (machine)
 				item = machine
 		var/icon_file = initial(item.icon)
-		var/icon/I = icon(icon_file, initial(item.icon_state), SOUTH)
+		var/icon_state = initial(item.icon_state)
+		if (!(icon_state in icon_states(icon_file)))
+			warning("design [D] with icon '[icon_file]' missing state '[icon_state]'")
+			continue
+		var/icon/I = icon(icon_file, icon_state, SOUTH)
 
 		// computers (and snowflakes) get their screen and keyboard sprites
 		if (ispath(item, /obj/machinery/computer) || ispath(item, /obj/machinery/power/solar_control))
diff --git a/code/modules/modular_computers/computers/item/tablet.dm b/code/modules/modular_computers/computers/item/tablet.dm
index f075a8464b2..54e43a8731d 100644
--- a/code/modules/modular_computers/computers/item/tablet.dm
+++ b/code/modules/modular_computers/computers/item/tablet.dm
@@ -1,7 +1,7 @@
 /obj/item/modular_computer/tablet  //Its called tablet for theme of 90ies but actually its a "big smartphone" sized
 	name = "tablet computer"
 	icon = 'icons/obj/modular_tablet.dmi'
-	icon_state = "tablet"
+	icon_state = "tablet-red"
 	icon_state_unpowered = "tablet"
 	icon_state_powered = "tablet"
 	icon_state_menu = "menu"