cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-22 12:41:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] fix message spam for manual pipe crafting [MDB IGNORE] (#9637)

Browse Source 
* fix message spam for atmos construction (#62796)

About The Pull Request

partial fix to #62783
the check was never meant to have feedback messages added in it because it runs every UI tick. Added the message as additional requirement text.
GBP no update please
Why It's Good For The Game

fix
Changelog

cl
fix: fix message spam for manual pipe crafting
/cl

* fix message spam for manual pipe crafting

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
This commit is contained in:
SkyratBot
2021-11-23 04:09:45 +00:00
committed by GitHub
co-authored by Ghilker
parent 99ee1bdbe2
commit 12ba73b7e2
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/datums/components/crafting/recipes.dm
+15 -2
View File
@@ -34,7 +34,7 @@
tool_paths = string_list(tool_paths)
/**
* Run custom pre-craft checks for this recipe
* Run custom pre-craft checks for this recipe, don't add feedback messages in this because it will spam the client
*
* user: The /mob that initiated the crafting
* collected_requirements: A list of lists of /obj/item instances that satisfy reqs. Top level list is keyed by requirement path.
@@ -50,7 +50,6 @@
var/obj/item/pipe/required_pipe = collected_requirements[/obj/item/pipe][1]
if(ispath(required_pipe.pipe_type, /obj/machinery/atmospherics/pipe/smart))
return TRUE
to_chat(user, span_boldwarning("You can't craft \a [name] without a pipe fitting!"))
return FALSE
/datum/crafting_recipe/improv_explosive
@@ -1370,6 +1369,7 @@
/obj/item/stack/sheet/iron = 1)
time = 1 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/layer_adapter/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1390,6 +1390,7 @@
/obj/item/stack/sheet/iron = 1)
time = 1 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/color_adapter/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1410,6 +1411,7 @@
/obj/item/stack/sheet/iron = 1)
time = 1 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/he_pipe/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1430,6 +1432,7 @@
/obj/item/stack/sheet/iron = 1)
time = 1 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/he_junction/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1451,6 +1454,7 @@
/obj/item/stack/cable_coil = 5)
time = 2 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/pressure_pump/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1471,6 +1475,7 @@
/obj/item/stack/sheet/iron = 1)
time = 2 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/manual_valve/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1492,6 +1497,7 @@
/obj/item/stack/cable_coil = 5)
time = 2 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/vent/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1513,6 +1519,7 @@
/obj/item/stack/cable_coil = 5)
time = 2 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/scrubber/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1534,6 +1541,7 @@
/obj/item/stack/cable_coil = 5)
time = 2 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/filter/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1555,6 +1563,7 @@
/obj/item/stack/cable_coil = 5)
time = 2 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/mixer/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1575,6 +1584,7 @@
/obj/item/stack/sheet/iron = 1)
time = 2 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/connector/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1595,6 +1605,7 @@
/obj/item/stack/sheet/iron = 1)
time = 2 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/passive_vent/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1616,6 +1627,7 @@
/obj/item/stack/cable_coil = 5)
time = 2 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/injector/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)
@@ -1636,6 +1648,7 @@
/obj/item/stack/sheet/plasteel = 1)
time = 2 SECONDS
category = CAT_ATMOSPHERIC
additional_req_text = " smart pipe fitting"
/datum/crafting_recipe/he_exchanger/check_requirements(mob/user, list/collected_requirements)
return atmos_pipe_check(user, collected_requirements)