From 12ebe064fc2bdeb70fa7152668f4978ef5205afa Mon Sep 17 00:00:00 2001 From: Lucy Date: Sat, 16 Aug 2025 21:31:15 -0400 Subject: [PATCH] don't use `get_all_contents` every process for family heirlooms (#92576) ## About The Pull Request the family heirloom quirk runs `get_all_contents` on the quirk holder every process. which is kinda dumb and wasteful when we are looking to see if the quirk holder has an item _that we already have a reference to_... `/atom/proc/contains` exists and works just fine for this. ## Why It's Good For The Game `get_all_contents` is very wasteful and unneeded for this use-case ## Changelog no user-facing changes --- code/datums/quirks/negative_quirks/family_heirloom.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/datums/quirks/negative_quirks/family_heirloom.dm b/code/datums/quirks/negative_quirks/family_heirloom.dm index 8d2a080c534..8b3d826cb84 100644 --- a/code/datums/quirks/negative_quirks/family_heirloom.dm +++ b/code/datums/quirks/negative_quirks/family_heirloom.dm @@ -58,7 +58,7 @@ /datum/quirk/item_quirk/family_heirloom/process() var/obj/family_heirloom = heirloom?.resolve() - if(family_heirloom && (family_heirloom in quirk_holder.get_all_contents())) + if(family_heirloom && quirk_holder.contains(family_heirloom)) quirk_holder.clear_mood_event("family_heirloom_missing") quirk_holder.add_mood_event("family_heirloom", /datum/mood_event/family_heirloom) else