Part 4: Storage Improvements (#90783)

- Address
https://github.com/tgstation/tgstation/pull/90476#discussion_r2051701283.
Makes pill bottle code cleaner
- Datumized some more storage values(monkey guncase toolbox & crafter
toolbox) making their init slightly faster
- Moved all standard storage subtypes(bags, boxes, lockboxes etc) that
is scattered across various files & folders in the codebase into their
respective files under `code/game/objects/item/storage` folder.
This means for e.g. if you want to see all boxes in the game you can
find them in `code/game/objects/item/storage/boxes` folder & don't have
to go looking for hidden subtypes in various module files or folders
where they were hidden away.
  Makes looking for stuff & modifying these storages much saner & easier

🆑
code: organized storage subtypes under the same files & folders
/🆑

---------

Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com>
This commit is contained in:
SyncIt21
2025-05-08 19:02:00 -04:00
committed by Roxy
co-authored by _0Steven
parent 2b4c5aa010
commit 1428f663e0
55 changed files with 1864 additions and 1956 deletions
@@ -194,54 +194,6 @@ GLOBAL_DATUM(current_anonymous_theme, /datum/anonymous_theme)
/datum/anonymous_theme/wizards/anonymous_ai_name(is_ai = FALSE)
return "Crystallized Knowledge [is_ai ? "Nexus" : "Sliver"] +[rand(1,99)]" //Could two people roll the same number? Yeah, probably. Do I CARE? Nawww
/obj/item/storage/box/wizard_kit
name = "Generic Wizard Cosplay Kit"
/obj/item/storage/box/wizard_kit/PopulateContents()
new /obj/item/clothing/head/wizard(src)
new /obj/item/clothing/suit/wizrobe(src)
new /obj/item/clothing/shoes/sandal(src)
/obj/item/storage/box/wizard_kit/red
name = "Evocation Wizard Cosplay Kit"
/obj/item/storage/box/wizard_kit/red/PopulateContents()
new /obj/item/clothing/head/wizard/red(src)
new /obj/item/clothing/suit/wizrobe/red(src)
new /obj/item/clothing/shoes/sandal(src)
/obj/item/storage/box/wizard_kit/yellow
name = "Translocation Wizard Cosplay Kit"
/obj/item/storage/box/wizard_kit/yellow/PopulateContents()
new /obj/item/clothing/head/wizard/yellow(src)
new /obj/item/clothing/suit/wizrobe/yellow(src)
new /obj/item/clothing/shoes/sandal(src)
/obj/item/storage/box/wizard_kit/magusred
name = "Conjuration Wizard Cosplay Kit"
/obj/item/storage/box/wizard_kit/yellow/PopulateContents()
new /obj/item/clothing/head/wizard/magus(src)
new /obj/item/clothing/suit/wizrobe/magusred(src)
new /obj/item/clothing/shoes/sandal(src)
/obj/item/storage/box/wizard_kit/magusblue
name = "Transmutation Wizard Cosplay Kit"
/obj/item/storage/box/wizard_kit/yellow/PopulateContents()
new /obj/item/clothing/head/wizard/magus(src)
new /obj/item/clothing/suit/wizrobe/magusblue(src)
new /obj/item/clothing/shoes/sandal(src)
/obj/item/storage/box/wizard_kit/black
name = "Necromancy Wizard Cosplay Kit"
/obj/item/storage/box/wizard_kit/black/PopulateContents()
new /obj/item/clothing/head/wizard/black(src)
new /obj/item/clothing/suit/wizrobe/black(src)
new /obj/item/clothing/shoes/sandal(src)
/datum/anonymous_theme/spider_clan
name = "Spider Clan"