cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-29 16:18:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

all logs are now externally formatted (#75972)

Browse Source 
Internal formatting should only be used for logs that include their own
timestamp or don't want one printed.

atm internal formatting does not add the continuation market to newlines
which is an issue that is causing info leak of private loglines.

two logs that always used newlines were manually moved to external
formatting in the original pr, this now makes that the default. a log
type must have a valid reason to format internally now and specifically
request this.

(None of this impacts json logs)

🆑
server: fix logging infoleak from the lack of continuation markets on
new lines.
/🆑
This commit is contained in:
Kyle Spier-Swenson
2023-06-10 19:24:04 +00:00
committed by GitHub
parent 94d95b5c46
commit 14f9ba0af1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/logging/log_category.dm
+1 -1
View File
@@ -21,7 +21,7 @@
var/secret = FALSE
/// Whether the readable version of the log message is formatted internally instead of by rustg
var/internal_formatting = TRUE
var/internal_formatting = FALSE
/// List of log entries for this category
var/list/entries = list()