From 15e9d0485f28f294659edc8f8924da18bd423156 Mon Sep 17 00:00:00 2001 From: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Date: Sun, 27 Feb 2022 05:16:38 -0800 Subject: [PATCH] Adds a seperate pick proc to work on lists (#65178) Because of how arglist() works, _pick was only working on args matching the format pick(1, 2 ,3) Because this is logic that happens inside pick itself, and I can't figure out the proper way to actually pass things in, I've created _pick_list so admins have a sane way to pick from lists. --- code/modules/admin/verbs/SDQL2/SDQL_2_wrappers.dm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/code/modules/admin/verbs/SDQL2/SDQL_2_wrappers.dm b/code/modules/admin/verbs/SDQL2/SDQL_2_wrappers.dm index be10e2b3666..e9816d89c4c 100644 --- a/code/modules/admin/verbs/SDQL2/SDQL_2_wrappers.dm +++ b/code/modules/admin/verbs/SDQL2/SDQL_2_wrappers.dm @@ -123,6 +123,16 @@ /proc/_pick(...) return pick(arglist(args)) +/// Allow me to explain +/// for some reason, if pick() is passed arglist(args) directly and args contains only one list +/// it considers it to be a list of lists +/// this means something like _pick(list) would fail +/// need to do this instead +/// +/// I hate this timeline +/proc/_pick_list(list/pick_from) + return pick(pick_from) + /proc/_prob(P) return prob(P)