cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-28 23:58:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes fake feedback link if db calls fail (#90209)

Browse Source 
## About The Pull Request

We were nullchecking this instead of falsey checking it (TAKE THAT
ISNULL POSTERS) so it'd see FALSE, go "oh that's not null", and then try
and link clients to 0. Dumb
This commit is contained in:
LemonInTheDark
2025-03-25 16:53:31 +01:00
committed by GitHub
parent 8ac8fd086d
commit 1714a941ea
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/admin/holder2.dm
+3 -3
View File
@@ -172,18 +172,18 @@ GLOBAL_PROTECT(href_token)
return cached_feedback_link
if (!SSdbcore.IsConnected())
return FALSE
return null
var/datum/db_query/feedback_query = SSdbcore.NewQuery("SELECT feedback FROM [format_table_name("admin")] WHERE ckey = '[owner.ckey]'")
if(!feedback_query.Execute())
log_sql("Error retrieving feedback link for [src]")
qdel(feedback_query)
return FALSE
return null
if(!feedback_query.NextRow())
qdel(feedback_query)
return FALSE // no feedback link exists
return null // no feedback link exists
cached_feedback_link = feedback_query.item[1] || NO_FEEDBACK_LINK
qdel(feedback_query)