cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-16 02:24:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Frame stacking fix and unit test addition. (#56287)

Browse Source 
* Reverts #56205

* Allow things without density to bypass checks

* The rest of the owl

* The rest of the owl

* Doc and tweak

* More feex

* RCD machine frame unit test

* I suck

* AAAAA

* Bad at unit tests

* Revert unit tests (for including in another PR)

* Fix windoor_assembly return logic

* Comment /mob/living/proc/PushAM logic

* Windoor assembley logic tweak

* Fix frame stacking

* Unit test

* Better wording from macros?
This commit is contained in:
Timberpoes
2021-01-22 13:18:05 +00:00
committed by GitHub
parent 294a2518fb
commit 1989497576
17 changed files with 242 additions and 194 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/_unit_tests.dm
+1
View File
@@ -60,6 +60,7 @@
#include "pills.dm"
#include "plantgrowth_tests.dm"
#include "projectiles.dm"
#include "rcd.dm"
#include "reagent_id_typos.dm"
#include "reagent_mod_expose.dm"
#include "reagent_mod_procs.dm"
code/modules/unit_tests/rcd.dm
+46
View File
@@ -0,0 +1,46 @@
/**
* Simple unit test to ensure there's no regression in behaviour where machine frames should not be stacked.
*
* We attempt to use the RCD to build multiple stacked machine frames on a turf. If we end up with any number that
* is not equal to 1, this means we've either built no machine frames (bad) or built more than one (regression).
*
* If this is successful, we attempt to spawn in some no-density machines that result in machine frames and we run
* the test again on our turf containing our single frame, deconstructing the machines! This should also not spawn
* any stacked machine frames.
*/
/datum/unit_test/frame_stacking/Run()
// First test - RCDs stacking frames.
var/obj/item/construction/rcd/rcd = allocate(/obj/item/construction/rcd/combat/admin)
var/mob/living/carbon/human/engineer = allocate(/mob/living/carbon/human)
engineer.put_in_hands(rcd, forced = TRUE)
rcd.mode = RCD_MACHINE
var/list/adjacent_turfs = get_adjacent_open_turfs(engineer)
if(!length(adjacent_turfs))
Fail("RCD Test failed - Lack of adjacent open turfs. This may be an issue with the unit test.")
var/turf/adjacent_turf = adjacent_turfs[1]
for(var/i in 1 to 10)
adjacent_turf.rcd_act(engineer, rcd, rcd.mode)
var/frame_count = 0
for(var/obj/structure/frame/machine_frame in adjacent_turf.contents)
frame_count++
TEST_ASSERT_EQUAL(frame_count, 1, "Expected RCD machine frame stacking test to end up with exactly 1 machine frame.")
// Second test - Deconstructing stacked machines to stack frames. We'll recycle our old turf to accomplish this.
for(var/i in 1 to 10)
// This should be a type path to a machine with no density, that can be wrenched on a turf with another machine of the same type.
var/obj/machinery/new_machine = new /obj/machinery/recharger(adjacent_turf)
new_machine.deconstruct(TRUE)
frame_count = 0
for(var/obj/structure/frame/machine_frame in adjacent_turf.contents)
frame_count++
TEST_ASSERT_EQUAL(frame_count, 1, "Expected no density machine deconstruction frame stacking test to end up with exactly 1 machine frame.")