cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-16 02:24:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Generalizes mining voucher behavior (#90297)

Browse Source 
## About The Pull Request

Adds `/datum/element/voucher_redeemer`, expands `/datum/voucher_set` a
bit, bumps all mining stuff down a level to `/datum/voucher_set/mining`.

## Why It's Good For The Game

Having a generic way to 
`input item -> output a choice of a set of items`
would be really handy. 

## Changelog

🆑 Melbert
refactor: Minor mining voucher refactor, report any oddities.
/🆑
This commit is contained in:
MrMelbert
2025-04-02 16:37:34 -05:00
committed by Shadow-Quill
parent c724f12ec7
commit 1b035fd838
4 changed files with 124 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/mining/voucher_sets.dm
+42 -20
View File
@@ -1,32 +1,54 @@
/**
* # Voucher Set
*
* A set consisting of a various equipment that can be then used as a reward for redeeming a mining voucher.
* A set consisting of a various equipment that can be then used as a reward for redeeming a voucher.
*
* See [Voucher Redeemer](/datum/element/voucher_redeemer) for where these sets are handled.
*/
/datum/voucher_set
/// Name of the set
/// Required, Name of the set.
var/name
/// Description of the set
/// Optional, description of the set
var/description
/// Icon of the set
/// Optional, Icon of the set. Defaults to first item if not set.
var/icon
/// Icon state of the set
/// Optional, Icon state of the set. Defaults to first item if not set.
var/icon_state
/// List of items contained in the set
var/list/set_items = list()
/// Required, List of items contained in the set
var/list/atom/set_items
/// Optional, what key to use for blackbox feedback. No data will be recorded if not set.
var/blackbox_key
/datum/voucher_set/crusher_kit
/datum/voucher_set/New()
. = ..()
if(!length(set_items))
stack_trace("Voucher set [type] has no items set.")
return
if(isnull(icon))
icon = initial(set_items[1].icon)
if(isnull(icon_state))
icon_state = initial(set_items[1].icon_state)
if(isnull(name))
stack_trace("Voucher set [type] has no name set.")
/datum/voucher_set/proc/spawn_set(atom/spawn_loc)
for(var/item in set_items)
new item(spawn_loc)
/datum/voucher_set/mining
blackbox_key = "mining_voucher_redeemed"
/datum/voucher_set/mining/crusher_kit
name = "Crusher Kit"
description = "Contains a kinetic crusher and a pocket fire extinguisher. Kinetic crusher is a versatile melee mining tool capable both of mining and fighting local fauna, however it is difficult to use effectively for anyone but most skilled and/or suicidal miners."
icon = 'icons/obj/mining.dmi'
icon_state = "crusher"
set_items = list(
/obj/item/extinguisher/mini,
/obj/item/kinetic_crusher,
)
/obj/item/extinguisher/mini,
)
/datum/voucher_set/extraction_kit
/datum/voucher_set/mining/extraction_kit
name = "Extraction and Rescue Kit"
description = "Contains a fulton extraction pack and a beacon signaller, which allows you to send back home minerals, items and dead bodies without having to use the mining shuttle. And as a bonus, you get 30 marker beacons to help you better mark your path."
icon = 'icons/obj/fulton.dmi'
@@ -35,28 +57,28 @@
/obj/item/extraction_pack,
/obj/item/fulton_core,
/obj/item/stack/marker_beacon/thirty,
)
)
/datum/voucher_set/resonator_kit
/datum/voucher_set/mining/resonator_kit
name = "Resonator Kit"
description = "Contains a resonator and a pocket fire extinguisher. Resonator is a handheld device that creates small fields of energy that resonate until they detonate, crushing rock. It does increased damage in low pressure."
icon = 'icons/obj/mining.dmi'
icon_state = "resonator"
set_items = list(
/obj/item/extinguisher/mini,
/obj/item/resonator,
)
/obj/item/extinguisher/mini,
)
/datum/voucher_set/survival_capsule
/datum/voucher_set/mining/survival_capsule
name = "Survival Capsule and Explorer's Webbing"
description = "Contains an explorer's webbing, which allows you to carry even more mining equipment and already has a spare shelter capsule in it."
icon = 'icons/obj/clothing/belts.dmi'
icon_state = "explorer1"
set_items = list(
/obj/item/storage/belt/mining/vendor,
)
)
/datum/voucher_set/minebot_kit
/datum/voucher_set/mining/minebot_kit
name = "Minebot Kit"
description = "Contains a little minebot companion that helps you in storing ore and hunting wildlife. Also comes with an upgraded industrial welding tool (80u), a welding mask and a KA modkit that allows shots to pass through the minebot."
icon = 'icons/mob/silicon/aibots.dmi'
@@ -66,9 +88,9 @@
/obj/item/weldingtool/hugetank,
/obj/item/clothing/head/utility/welding,
/obj/item/borg/upgrade/modkit/minebot_passthrough,
)
)
/datum/voucher_set/conscription_kit
/datum/voucher_set/mining/conscription_kit
name = "Mining Conscription Kit"
description = "Contains a whole new mining starter kit for one crewmember, consisting of a proto-kinetic accelerator, a survival knife, a seclite, an explorer's suit, mesons, an automatic mining scanner, a mining satchel, a gas mask, a mining radio key and a special ID card with a basic mining access."
icon = 'icons/obj/storage/backpack.dmi'