mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-22 05:25:15 +01:00
Dunking handle_atom_del() in the trash bin. (#77339)
Whatever you do, if it warrants the use of something like `handle_atom_del`, chances are `Exited` can do it better, as most of these cases involve movables that shouldn't be moved out of their loc (`Destroy` forcefully moves movables to nullspace) without calling specific procs, and for the remaining few, `handle_atom_del` doesn't even cover the eventuality of a movable being deleted outside the source atom, so it's quite garbage. Beside, I feel confident in saying `handle_atom_del()` is older than the DCS, an echo on the workarounds done at the time.
This commit is contained in:
@@ -281,18 +281,18 @@
|
||||
QDEL_NULL(boots)
|
||||
return ..()
|
||||
|
||||
/obj/item/mod/construction/shell/handle_atom_del(atom/deleted_atom)
|
||||
if(deleted_atom == core)
|
||||
/obj/item/mod/construction/shell/Exited(atom/movable/gone, direction)
|
||||
. = ..()
|
||||
if(gone == core)
|
||||
core = null
|
||||
if(deleted_atom == helmet)
|
||||
if(gone == helmet)
|
||||
helmet = null
|
||||
if(deleted_atom == chestplate)
|
||||
if(gone == chestplate)
|
||||
chestplate = null
|
||||
if(deleted_atom == gauntlets)
|
||||
if(gone == gauntlets)
|
||||
gauntlets = null
|
||||
if(deleted_atom == boots)
|
||||
if(gone == boots)
|
||||
boots = null
|
||||
return ..()
|
||||
|
||||
#undef START_STEP
|
||||
#undef CORE_STEP
|
||||
|
||||
Reference in New Issue
Block a user